From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AA85B385843E for ; Thu, 31 Mar 2022 21:04:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AA85B385843E Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-150-GkZAfuPPMe-WivI3U1mHMA-1; Thu, 31 Mar 2022 17:04:29 -0400 X-MC-Unique: GkZAfuPPMe-WivI3U1mHMA-1 Received: by mail-wm1-f71.google.com with SMTP id i65-20020a1c3b44000000b00385c3f3defaso334685wma.3 for ; Thu, 31 Mar 2022 14:04:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lZdA9ug9EguTqWtLZTiCjodfVWlxdABaQvImqT57Z28=; b=Cir6s1HvQWmqFn4IODFkVAla6w4FXa+ptEIo1uYXED/kqT6Jb/WJ85SUuPxPpanidw 3UShjFVEsl1SIf3EZh2wDEaNWOdzKbajnIdnO0bx7Nn/GYGbzNC/bR2Lu1PhuFBVMwr0 HCqVfqViVImeoq2QA3ilBjEv5bM8VcgN/6GV3p67OSDWxqv7Yqm0RKDx/aYd5cAa/aGm NVX5HihKo1cZFGY/dsjC6Jj/NYZViYfm7K6aonKz6Mw7Tu+La05WqPZSJ/cvt6DxejRK QJwyym1aheZtcg54ZK/F0Gn8b40OgzHRE3PNdsO3EizVqRaNO70yCdk5qbupCq+D2dtG qL3g== X-Gm-Message-State: AOAM533KcyMWiwJMhSTe/fZZofVK268K51qOTkf6GL7yVExJSudpsGcm m/olyVKTqe8s+5SCSiESjIewTxB906P4ueXJ3m6RcBXiuIfKvJapYuxtceiS5eXYfeUOM11j58z aar5VTCYYSkyBryvxqhHeRWMl+omyMNNYWZIPQHzjKzyp2GoNF2QW0pzHV+1wAvteTEQjnZL+5Q == X-Received: by 2002:a05:600c:6001:b0:38c:6c43:4427 with SMTP id az1-20020a05600c600100b0038c6c434427mr6051778wmb.186.1648760668413; Thu, 31 Mar 2022 14:04:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3H5uNvcGVa6fOqNNI5gFcIe1oSSrvLAMdAsE6l0Boxthj4TI7Wrn4JYbaUics59jlv50seA== X-Received: by 2002:a05:600c:6001:b0:38c:6c43:4427 with SMTP id az1-20020a05600c600100b0038c6c434427mr6051763wmb.186.1648760668106; Thu, 31 Mar 2022 14:04:28 -0700 (PDT) Received: from localhost (host86-169-131-113.range86-169.btcentralplus.com. [86.169.131.113]) by smtp.gmail.com with ESMTPSA id p8-20020a5d4e08000000b002054b5437f2sm371126wrt.115.2022.03.31.14.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 14:04:27 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 00/16] Default register groups, and general related cleanup Date: Thu, 31 Mar 2022 22:04:06 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 21:04:33 -0000 This work started with this thread: https://sourceware.org/pipermail/gdb-patches/2022-March/187071.html In which it was discovered that the ppc targets don't add the default register groups during gdbarch initialisation. I've run into this problem before, and every time I wonder why the default register groups aren't added by default in all cases. So, looked at doing just that. But the register group management code was feeling a bit crusty, so I thought I'd clean it up. Then I hit some bugs, which I figured I'd fix. Anyway, patch #9 is what I set out to do. Everything else is me trying to improve the register group handling code. All feedback welcome. Thanks, Andrew --- Andrew Burgess (16): gdb: don't try to use readline before it's initialized gdb: add some const in gdb/reggroups.c gdb: make gdbarch_register_reggroup_p take a const reggroup * gdb: switch to using 'const reggroup *' in tui-regs.{c,h} gdb: use 'const reggroup *' in python/py-registers.c file gdb: have reggroup_find return a const gdb/tui: avoid theoretical bug with 'tui reg' command gdb/tui: fix 'tui reg next/prev' command when data window is hidden gdb: always add the default register groups gdb: convert reggroups to use a std::vector gdb: remove reggroup_next and reggroup_prev gdb: more 'const' in gdb/reggroups.{c,h} gdb: make the pre-defined register groups const gdb: convert reggroup to a C++ class with constructor, etc gdb: move struct reggroup into reggroups.h header gdb: update comments throughout reggroups.{c,h} files gdb/aarch64-tdep.c | 19 +-- gdb/alpha-tdep.c | 2 +- gdb/amd64-linux-tdep.c | 2 +- gdb/arc-tdep.c | 17 -- gdb/arm-tdep.c | 2 +- gdb/completer.c | 8 +- gdb/csky-tdep.c | 14 +- gdb/gdbarch-components.py | 2 +- gdb/gdbarch-gen.h | 4 +- gdb/gdbarch.c | 2 +- gdb/i386-linux-tdep.c | 2 +- gdb/i386-tdep.c | 13 +- gdb/i386-tdep.h | 2 +- gdb/ia64-tdep.c | 2 +- gdb/infcmd.c | 14 +- gdb/lm32-tdep.c | 13 +- gdb/m32c-tdep.c | 9 +- gdb/m68hc11-tdep.c | 13 +- gdb/mep-tdep.c | 12 +- gdb/mips-tdep.c | 4 +- gdb/msp430-tdep.c | 2 +- gdb/nds32-tdep.c | 32 ++-- gdb/or1k-tdep.c | 14 +- gdb/python/py-registers.c | 32 ++-- gdb/regcache-dump.c | 9 +- gdb/reggroups.c | 298 ++++++++++++--------------------- gdb/reggroups.h | 94 +++++++---- gdb/riscv-tdep.c | 18 +- gdb/rl78-tdep.c | 2 +- gdb/rs6000-tdep.c | 2 +- gdb/s390-tdep.c | 2 +- gdb/sh-tdep.c | 2 +- gdb/target-descriptions.c | 6 +- gdb/target-descriptions.h | 2 +- gdb/testsuite/gdb.tui/regs.exp | 26 +++ gdb/tui/tui-regs.c | 111 +++++++----- gdb/tui/tui-regs.h | 9 +- gdb/utils.c | 17 +- gdb/xtensa-tdep.c | 25 +-- 39 files changed, 373 insertions(+), 486 deletions(-) -- 2.25.4