From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EC5B13949E29 for ; Tue, 28 Jun 2022 14:29:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC5B13949E29 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-14-ywVyNLyNN2O21XjYgtwKNw-1; Tue, 28 Jun 2022 10:29:03 -0400 X-MC-Unique: ywVyNLyNN2O21XjYgtwKNw-1 Received: by mail-wr1-f72.google.com with SMTP id n5-20020adf8b05000000b00219ece7272bso1847894wra.8 for ; Tue, 28 Jun 2022 07:29:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RnwqoO5AulzUUIsUd6Zjdvs7Gz3aqbYbn6B+Yx1bpkc=; b=jqqS+vCQ1d8zGDFcgTIJTybJSCiC9EQyLGML65UaMovFX/WFpK+4tPpkspqCU17L/A Kh6gBSvZa1LRgvlvsFb/XFPG2z63pYLJmozMQnt+Leb0L5++c2oKwjCcMWjET/Aol3cn XOifqVjL/uhY4rq2gLZbWg1crmQYAiR5FuVbjD+jVyzbQxXhoH0/7ArInDXQ/cAb2eLU WLfDfYc/YA5Sm632cL9VXqrq1tqn9USyEJV8SjKLPpauN0zAY2ftF5jUNBEBYeT/uxCC ZbkFta24tFVvNbSE75zCqfY5FAqdoHvz4ATkfeBZuR2/qcBFF9R9LFtRTci48y+F4qgG swBw== X-Gm-Message-State: AJIora83AwGgl2AB0tqMcaKLlgbrINGWQJvzaomwCOkw0Wdq/2sbhhaJ H3kRQ2GIW6JJGvnVpzYiTfbX3dUwoOzyB9rFfa5ojVkULiJTyPeotei/XjvUQSHfp/39LgeaVng f+m3eVpyzZDH2xvfOKGpqOKRcKHNT/M2NG0w8G4u7GcGGqgdrwnDBehEBj56P/pA2nU28UaaGFA == X-Received: by 2002:a5d:6d09:0:b0:21a:1321:55b6 with SMTP id e9-20020a5d6d09000000b0021a132155b6mr17951865wrq.117.1656426541804; Tue, 28 Jun 2022 07:29:01 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s3OlzDXZ2ZzATvLCm6x8RSsEzTAyGHpn+JClCIulH0T7aWHTdLC7l+YBcKZPoGFb0CwB9uGQ== X-Received: by 2002:a5d:6d09:0:b0:21a:1321:55b6 with SMTP id e9-20020a5d6d09000000b0021a132155b6mr17951839wrq.117.1656426541484; Tue, 28 Jun 2022 07:29:01 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id bs30-20020a056000071e00b0021bb9071374sm12385309wrb.53.2022.06.28.07.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 07:29:01 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv4 0/6] Detect invalid casts of gdbarch_tdep structures Date: Tue, 28 Jun 2022 15:28:51 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 14:29:06 -0000 Changes since v3: - Title of series has changed as the last patch, relating to detection of incorrect architecture with a native target, have been dropped. - Patches #1 and #2 are unchanged, - Patch #3 has had minor updates based on feedback from Luis and Pedro, - Patch #4 is unchanged, - Patch #5 is new, based on Pedro's feedback, - Patch #6 has been updated to make use of the work added in patch #5. Changes since v2: - Patch #3 has been replaced after feedback from Luis. New patch fixes sider issues for arm, mips, and frv targets, this includes the issue the v2 patch fixed. - Nothing else has changed. Changes since v1: - Patches #1 and #2 are unchanged. - Patch #3 is new in this version. - Patch #4 is unchanged (was patch 3). - Patch #5 is updated inline with John's feedback (was patch 4). - Patch #6 is extended to handle multi-arch case for rs6000/ppc and arm/aarch64, commit message is updated to discuss these cases, as well as mentioning i386/x86-64 (was patch 5). --- Andrew Burgess (6): gdb/arm: move fetch of arm_gdbarch_tdep to a more inner scope gdb/mips: rewrite show_mask_address gdb: select suitable thread for gdbarch_adjust_breakpoint_address gdb: move the type cast into gdbarch_tdep gdbsupport: add checked_static_cast gdb: ensure the cast in gdbarch_tdep is valid gdb/aarch64-fbsd-nat.c | 4 +- gdb/aarch64-fbsd-tdep.c | 6 +- gdb/aarch64-linux-nat.c | 20 ++-- gdb/aarch64-linux-tdep.c | 10 +- gdb/aarch64-newlib-tdep.c | 2 +- gdb/aarch64-tdep.c | 48 ++++----- gdb/aix-thread.c | 28 +++--- gdb/alpha-linux-tdep.c | 2 +- gdb/alpha-netbsd-tdep.c | 2 +- gdb/alpha-obsd-tdep.c | 2 +- gdb/alpha-tdep.c | 14 +-- gdb/amd64-darwin-tdep.c | 2 +- gdb/amd64-fbsd-nat.c | 4 +- gdb/amd64-fbsd-tdep.c | 4 +- gdb/amd64-linux-tdep.c | 8 +- gdb/amd64-netbsd-tdep.c | 2 +- gdb/amd64-obsd-tdep.c | 2 +- gdb/amd64-sol2-tdep.c | 2 +- gdb/amd64-tdep.c | 34 +++---- gdb/amd64-windows-tdep.c | 2 +- gdb/arc-linux-tdep.c | 4 +- gdb/arc-newlib-tdep.c | 2 +- gdb/arc-tdep.c | 8 +- gdb/arch-utils.c | 6 +- gdb/arm-fbsd-nat.c | 4 +- gdb/arm-fbsd-tdep.c | 6 +- gdb/arm-linux-nat.c | 8 +- gdb/arm-linux-tdep.c | 4 +- gdb/arm-netbsd-nat.c | 8 +- gdb/arm-netbsd-tdep.c | 4 +- gdb/arm-none-tdep.c | 2 +- gdb/arm-obsd-tdep.c | 2 +- gdb/arm-tdep.c | 142 ++++++++++++++------------- gdb/arm-wince-tdep.c | 2 +- gdb/avr-tdep.c | 12 +-- gdb/bfin-tdep.c | 4 +- gdb/breakpoint.c | 27 +++-- gdb/cris-linux-tdep.c | 2 +- gdb/cris-tdep.c | 18 ++-- gdb/csky-tdep.c | 8 +- gdb/frv-tdep.c | 4 +- gdb/ft32-tdep.c | 2 +- gdb/gdbarch.h | 27 ++++- gdb/hppa-bsd-tdep.c | 2 +- gdb/hppa-linux-tdep.c | 4 +- gdb/hppa-tdep.c | 12 +-- gdb/i386-bsd-tdep.c | 2 +- gdb/i386-darwin-tdep.c | 4 +- gdb/i386-fbsd-tdep.c | 4 +- gdb/i386-gnu-tdep.c | 2 +- gdb/i386-go32-tdep.c | 2 +- gdb/i386-linux-tdep.c | 4 +- gdb/i386-netbsd-tdep.c | 4 +- gdb/i386-nto-tdep.c | 6 +- gdb/i386-obsd-tdep.c | 2 +- gdb/i386-sol2-tdep.c | 2 +- gdb/i386-tdep.c | 98 +++++++++--------- gdb/i386-windows-tdep.c | 2 +- gdb/i387-tdep.c | 20 ++-- gdb/ia64-linux-tdep.c | 2 +- gdb/ia64-tdep.c | 12 +-- gdb/loongarch-linux-tdep.c | 2 +- gdb/loongarch-tdep.c | 4 +- gdb/m32c-tdep.c | 58 +++++------ gdb/m68hc11-tdep.c | 12 +-- gdb/m68k-bsd-tdep.c | 2 +- gdb/m68k-linux-tdep.c | 2 +- gdb/m68k-tdep.c | 38 +++---- gdb/mep-tdep.c | 6 +- gdb/mips-linux-tdep.c | 4 +- gdb/mips-tdep.c | 85 ++++++++-------- gdb/mn10300-tdep.c | 2 +- gdb/mn10300-tdep.h | 2 +- gdb/msp430-tdep.c | 12 +-- gdb/nds32-tdep.c | 20 ++-- gdb/nios2-linux-tdep.c | 2 +- gdb/nios2-tdep.c | 4 +- gdb/or1k-tdep.c | 8 +- gdb/ppc-fbsd-nat.c | 4 +- gdb/ppc-fbsd-tdep.c | 8 +- gdb/ppc-linux-nat.c | 22 ++--- gdb/ppc-linux-tdep.c | 18 ++-- gdb/ppc-netbsd-nat.c | 6 +- gdb/ppc-netbsd-tdep.c | 2 +- gdb/ppc-obsd-nat.c | 4 +- gdb/ppc-obsd-tdep.c | 2 +- gdb/ppc-sysv-tdep.c | 22 ++--- gdb/ppc64-tdep.c | 2 +- gdb/riscv-linux-tdep.c | 2 +- gdb/riscv-tdep.c | 26 ++--- gdb/rl78-tdep.c | 8 +- gdb/rs6000-aix-nat.c | 6 +- gdb/rs6000-aix-tdep.c | 16 +-- gdb/rs6000-lynx178-tdep.c | 4 +- gdb/rs6000-tdep.c | 132 ++++++++++++------------- gdb/rx-tdep.c | 2 +- gdb/s390-linux-tdep.c | 20 ++-- gdb/s390-tdep.c | 42 ++++---- gdb/sh-linux-tdep.c | 2 +- gdb/sh-netbsd-tdep.c | 2 +- gdb/sh-tdep.c | 8 +- gdb/sparc-linux-tdep.c | 4 +- gdb/sparc-netbsd-tdep.c | 2 +- gdb/sparc-sol2-tdep.c | 2 +- gdb/sparc-tdep.c | 14 +-- gdb/sparc64-fbsd-tdep.c | 2 +- gdb/sparc64-linux-tdep.c | 4 +- gdb/sparc64-netbsd-tdep.c | 2 +- gdb/sparc64-obsd-tdep.c | 2 +- gdb/sparc64-sol2-tdep.c | 2 +- gdb/sparc64-tdep.c | 10 +- gdb/tic6x-linux-tdep.c | 6 +- gdb/tic6x-tdep.c | 6 +- gdb/v850-tdep.c | 6 +- gdb/windows-nat.c | 2 +- gdb/xtensa-linux-nat.c | 4 +- gdb/xtensa-linux-tdep.c | 2 +- gdb/xtensa-tdep.c | 54 +++++----- gdb/z80-tdep.c | 8 +- gdbsupport/gdb-checked-static-cast.h | 68 +++++++++++++ 120 files changed, 811 insertions(+), 700 deletions(-) create mode 100644 gdbsupport/gdb-checked-static-cast.h -- 2.25.4