From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F41EE3857407 for ; Wed, 20 Jul 2022 13:15:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F41EE3857407 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-296-uwCs7ts4Nh-9FrC5bEt1VQ-1; Wed, 20 Jul 2022 09:14:53 -0400 X-MC-Unique: uwCs7ts4Nh-9FrC5bEt1VQ-1 Received: by mail-wm1-f72.google.com with SMTP id r127-20020a1c4485000000b003a2fdeea756so1251732wma.2 for ; Wed, 20 Jul 2022 06:14:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0nBgpwMYfSXLNSKbPVy7VJQdCWOifNMmnGngtvxtO10=; b=EE63wh5EmgRD/48dsaEWLuekSs2Abd5i0MU5rW0rl6ojrGMGfCYN+tfxiDef0Z9SzV FSadf1cpWtbg2kSRwoGqsjSbpGO7sgCXr31rG1Aniv3v1yVeC4oai7gvGzWb/IxBQRwe gDabAhEWu23XfKcj4k6JX+uEjgbu28MOIIQgJcjeDfkzGM4Vu0pMgY9hJ6MciphTQUfk TdvdIcDIGQ45Q7ovX7q/DU5OeZWlzzFVFTY0sUAV4Sw7ugHpEQruvozKWoBA3mgLj1qD xsbATq77VBFXQZHlsGrhdrS8pXdxl8E3+IefxOy5BDQy7doEG4WsY50VaTMbidaxiHEh Wo5Q== X-Gm-Message-State: AJIora+NJ3Cz0TjRu8OYxmRws34zTeKFdybSis0njf3LEdsJocZh6IgL OnbaF1iKKm2gj82fDSQIBfZrKZvQE97lnFAmzGGcJJ7OszoKIM5PXAiVoDSUSdeOaKKdz9faIlJ 7hp9+56Lu5yTCP0EStYyciIEP1kXmTKguVIr8Ie7iaEz8HvfMB3+M+1SIb37XNVwHyD78B3qahg == X-Received: by 2002:a05:600c:1d8a:b0:3a3:1104:88ad with SMTP id p10-20020a05600c1d8a00b003a3110488admr3655486wms.179.1658322892479; Wed, 20 Jul 2022 06:14:52 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uVpKiwv6ktEKLCITLyv32U7blEf25aWNgmV44crdz0kbHCp6uE7LrNv5PocsZeUP1R59bu8Q== X-Received: by 2002:a05:600c:1d8a:b0:3a3:1104:88ad with SMTP id p10-20020a05600c1d8a00b003a3110488admr3655462wms.179.1658322892201; Wed, 20 Jul 2022 06:14:52 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id l7-20020a05600c1d0700b003a02de5de80sm2953163wms.4.2022.07.20.06.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 06:14:51 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/2] Fix some undefined haviour bugs in Python disassembler API Date: Wed, 20 Jul 2022 14:14:35 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: <60eaedb1-8caf-1a52-0875-e3c5f5c8d8d4@simark.ca> References: <60eaedb1-8caf-1a52-0875-e3c5f5c8d8d4@simark.ca> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2022 13:15:10 -0000 Simon, Thanks for finding this problem. The first patch here fixes the problem you found. While testing this first patch I found another issue, which is what the second patch fixes. I'll probably push these in a few days unless I get some objections. Let me know if you have any thoughts, Thanks, Andrew --- Andrew Burgess (2): gdb: fix use of uninitialised gdb_printing_disassembler::m_in_comment gdb/python: fix invalid use disassemble_info::stream gdb/disasm.h | 2 +- gdb/python/py-disasm.c | 2 +- gdb/testsuite/gdb.python/py-disasm.c | 8 +++++++- gdb/testsuite/gdb.python/py-disasm.exp | 22 ++++++++++++++-------- gdb/testsuite/gdb.python/py-disasm.py | 3 --- 5 files changed, 23 insertions(+), 14 deletions(-) -- 2.25.4