From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9D76D3835DDE for ; Tue, 30 Aug 2022 14:17:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D76D3835DDE Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-613-x-aJGZV_M-CdnIm7kqjf_A-1; Tue, 30 Aug 2022 10:17:00 -0400 X-MC-Unique: x-aJGZV_M-CdnIm7kqjf_A-1 Received: by mail-wm1-f70.google.com with SMTP id ay21-20020a05600c1e1500b003a6271a9718so6734189wmb.0 for ; Tue, 30 Aug 2022 07:17:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=Habmb2T0bQX5q6jVtjvVDmPAmSFt5+tYLGrhyP8EjJU=; b=KCafkKBpTyB1oWuAIeeqMTRY7sI+tZ5ruZ1KsyM8bSu2ZKnjwahj6LHxtb4+mFrhsQ lmUYhAtji7qxVWVgFRxWzzR+7aHitIy/H4qd0IGf2zHlDS5feOWZjhwBczCPybtnLe78 DdGdZ6tABp9IBidHGGwdpTSK2mmnMe1HaDPxny2zj8YrNE9c0kvZVPo7VFYgKjbFNVlm ihG2qmW0vk3PXY4okBOAbIzscB8+FVhEmvpTunz0nLuPYYf4pkV1yOf+yLNn5oGDJMBW vUUyftoh0NL4J/BPX2U6uKbVB24y+CEcdeBV0DmguV7A79vdHU14Ulc7HnepAAb9R+i8 jV9w== X-Gm-Message-State: ACgBeo1Ff6glWK+ReGZMWfeAK9LmfnNURMaEZvezcDfwyHKTOV6qjlLv 7PHszsFSMufS7oOf9V7brsW3P69Pw8hQx4JyWR6cGcaex0lV7rH6tSXvVp/+hd7gedO72ArmGT2 T3CSkksCkbRDzJFQ+M1caAVy5pezsk+O0v6hFIaa8jVgKE1hhWCOZQJx7KNJTA3UxGv30TvTLeg == X-Received: by 2002:a05:600c:1d16:b0:3a6:1fa1:41f7 with SMTP id l22-20020a05600c1d1600b003a61fa141f7mr9448617wms.103.1661869019330; Tue, 30 Aug 2022 07:16:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR46wUUzpFmbHVq9EHoXmbTfs+yUtIt7RsCNY32XeWldYo0hyM1BlsQdZIvJn41Ymzr05NYWFQ== X-Received: by 2002:a05:600c:1d16:b0:3a6:1fa1:41f7 with SMTP id l22-20020a05600c1d1600b003a61fa141f7mr9448600wms.103.1661869019055; Tue, 30 Aug 2022 07:16:59 -0700 (PDT) Received: from localhost ([31.111.84.229]) by smtp.gmail.com with ESMTPSA id ci7-20020a5d5d87000000b00224f67bfc95sm9997346wrb.62.2022.08.30.07.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 07:16:58 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PATCH 0/3] Improvements for Pygments based disassembly styling Date: Tue, 30 Aug 2022 15:16:50 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2022 14:17:08 -0000 This series was inspired by this stackoverflow post: https://stackoverflow.com/questions/73491793/why-is-there-a-%c2%b1-in-lea-rax-rip-%c2%b1-0xeb3 which highlighted some issues with the Python Pygments based disassembler styling that was being used for all architectures in GDB 12. The next release of GDB will use libopcodes styling for many of the most popular architectures, but lots of the smaller architectures are still using Pygments, and Pygments can still be used for all architectures if a user chooses to disable use of libopcodes styling, though I don't know why they would want to do that. --- Andrew Burgess (3): gdb/testsuite: extend styling test for libopcodes styling gdb: improve disassembler styling when Pygments raises an exception gdb/disasm: better intel flavour disassembly styling with Pygments gdb/disasm.c | 69 ++++++++++---- gdb/disasm.h | 21 +++- gdb/python/lib/gdb/styling.py | 59 +++++++++++- gdb/testsuite/gdb.base/style.exp | 159 +++++++++++++++++++++++++------ 4 files changed, 250 insertions(+), 58 deletions(-) -- 2.25.4