From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 08C6D3858D1E for ; Thu, 8 Sep 2022 06:04:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 08C6D3858D1E Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id E16BD300089; Thu, 8 Sep 2022 06:04:23 +0000 (UTC) From: Tsukasa OI To: Tsukasa OI , Pedro Alves Cc: gdb-patches@sourceware.org Subject: [PATCH 0/1] gdbsupport: Fix config.status dependency Date: Thu, 8 Sep 2022 06:04:19 +0000 Message-Id: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2022 06:04:33 -0000 Hello, While I'm digging the build pipeline using the maintainer mode, I found something that will prevent building gdbsupport (luckily, it didn't occur by another mistake). Commit 171fba11ab27 ("Make GDBserver abort on internal error in development mode") created a new substitution CONFIG_STATUS_DEPENDENCIES but this is used by Makefile.in (which is not regenerated by that commit). This is not good but prevented the problem I'll describe later. After regenerating it, it is found that CONFIG_STATUS_DEPENDENCIES value is not valid, making gdbsupport fail to build. Since the CONFIG_STATUS_DEPENDENCIES value is used in the Makefile, macro substitution must have a Makefile format but commit 171fba11ab27 used shell format "$srcdir/../bfd/development.sh". PATCH 1/1 fixes this issue by substituting "$srcdir" (shell format) to "$(srcdir)" (Makefile format). It preserves the dependency as Pedro intended and fixes the build problem. It also regenerates corresponding files with the maintainer mode. Thanks, Tsukasa Tsukasa OI (1): gdbsupport: Fix config.status dependency gdbsupport/Makefile.in | 1 + gdbsupport/configure | 2 +- gdbsupport/configure.ac | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) base-commit: f42546b6cc7468ac7d929181ed7b965ab60958ac -- 2.34.1