public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/2] More detailed filenames for in-memory BFD objects
Date: Wed,  5 Oct 2022 20:33:51 +0100	[thread overview]
Message-ID: <cover.1664998256.git.aburgess@redhat.com> (raw)

We currently generate a filename for every in-memory BFD object that
GDB created (as part of the JIT interface).  The generated name is
"<in-memory>" for every symfile, which can make it hard to tell
multiple such files apart.

This series changes the generated name to "<in-memory@ADDRESS>", wher
ADDRESS is, obviously, the actual address of the symfile in memory.

I believe that this filename is only ever exposed in the output of
maintenance commands, so I haven't mentioned this change in the NEWS
file.  Maybe I should though?

---

Andrew Burgess (2):
  gdb: remove filename arg from gdb_bfd_open_from_target_memory
  gdb: include the base address in in-memory bfd filenames

 gdb/gdb_bfd.c                           |  59 ++++++---
 gdb/gdb_bfd.h                           |   7 +-
 gdb/testsuite/gdb.base/jit-bfd-name.exp | 155 ++++++++++++++++++++++++
 gdb/testsuite/lib/gdb.exp               |  22 ++++
 gdb/testsuite/lib/jit-elf-helpers.exp   |  12 +-
 5 files changed, 234 insertions(+), 21 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/jit-bfd-name.exp

-- 
2.25.4


             reply	other threads:[~2022-10-05 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 19:33 Andrew Burgess [this message]
2022-10-05 19:33 ` [PATCH 1/2] gdb: remove filename arg from gdb_bfd_open_from_target_memory Andrew Burgess
2022-10-05 19:33 ` [PATCH 2/2] gdb: include the base address in in-memory bfd filenames Andrew Burgess
2022-10-07 19:04 ` [PATCH 0/2] More detailed filenames for in-memory BFD objects Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1664998256.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).