From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
Andrew Burgess <aburgess@redhat.com>,
Mike Frysinger <vapier@gentoo.org>,
Stephane Carrez <Stephane.Carrez@gmail.com>,
"Frank Ch . Eigler" <fche@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: [PATCH v2 0/7] sim, sim/ARCH: Add ATTRIBUTE_PRINTF
Date: Thu, 6 Oct 2022 06:36:26 +0000 [thread overview]
Message-ID: <cover.1665038133.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <cover.1664095452.git.research_trasio@irq.a4lg.com>
Hello,
[Background]
When we build Binutils and GDB with Clang, it causes a build failure due to
warnings generated by Clang and the default -Werror configuration.
I MOSTLY managed to make ALL ARCHITECTURE ENABLED Binutils and GDB
-Werror-free on Clang 15.0.0 (note that this does not necessarily mean
warning-free) and this patchset is a part of it (simulator:
printf-like functions).
- It still requires -Wno-implicit-function-declaration on the
LatticeMicro32 and M32R simulators. Except them, most of Binutils / GDB
components can be built with Clang by default with my tree.
- I noticed that the assembler is not tested enough (because just with
--enable-targets=all, it builds only host assembler).
Full Clang 15.0.0 -Werror-free branch in development is available at:
<https://github.com/a4lg/binutils-gdb/tree/clang-nowarn-dev>
Tested configuration:
- Ubuntu 22.04.1 LTS (x86_64)
- LLVM / Clang 15.0.0 (built from source)
- Configuration examples:
$srcdir/configure \
--enable-targets=all \
--enable-multilib --enable-ld --enable-gold --enable-nls \
CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \
CFLAGS=' -O2 -g -Wno-implicit-function-declaration' \
CXXFLAGS='-O2 -g -Wno-implicit-function-declaration'
$srcdir/configure \
--target=riscv64-unknown-linux-gnu \
--enable-multilib --enable-ld --enable-gold --enable-nls \
CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \
CFLAGS='-O2 -g' CXXFLAGS='-O2 -g'
[About this Patchset]
Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral"). On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).
To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.
This patchset adds ATTRIBUTE_PRINTF to all functions that require
ATTRIBUTE_PRINTF macro.
[Changes: v1 -> v2]
- We only append ATTRIBUTE_PRINTF at function declarations,
not definitions (based on the feedback by Andrew Burgess).
- Fixed indents
- Removed ChangeLog from commit messages
(based on the feedback [to another patchset by me] by Bruno Larsen).
Thanks,
Tsukasa
Tsukasa OI (7):
sim: Add ATTRIBUTE_PRINTF
sim/cris: Add ATTRIBUTE_PRINTF
sim/erc32: Add ATTRIBUTE_PRINTF
sim/m32c: Add ATTRIBUTE_PRINTF
sim/m68hc11: Add ATTRIBUTE_PRINTF
sim/ppc: Add ATTRIBUTE_PRINTF
sim/rl78: Add ATTRIBUTE_PRINTF
sim/common/sim-utils.c | 2 +-
sim/cris/traps.c | 2 +-
sim/erc32/interf.c | 2 +-
sim/erc32/sis.c | 2 +-
sim/m32c/trace.c | 4 ++--
sim/m68hc11/m68hc11_sim.c | 2 +-
sim/ppc/main.c | 2 +-
sim/ppc/misc.c | 4 ++--
sim/ppc/sim_calls.c | 2 +-
sim/rl78/trace.c | 4 ++--
10 files changed, 13 insertions(+), 13 deletions(-)
base-commit: a13886e2198beb78b81c59839043b021ce6df78a
--
2.34.1
next prev parent reply other threads:[~2022-10-06 6:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 8:44 [PATCH " Tsukasa OI
2022-09-25 8:44 ` [PATCH 1/7] sim: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 2/7] sim/cris: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 3/7] sim/erc32: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 4/7] sim/m32c: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 5/7] sim/m68hc11: " Tsukasa OI
2022-09-25 8:44 ` [PATCH 6/7] sim/ppc: " Tsukasa OI
2022-10-05 10:57 ` Andrew Burgess
2022-10-06 5:32 ` Tsukasa OI
2022-09-25 8:44 ` [PATCH 7/7] sim/rl78: " Tsukasa OI
2022-10-06 6:36 ` Tsukasa OI [this message]
2022-10-06 6:36 ` [PATCH v2 1/7] sim: " Tsukasa OI
2022-10-11 14:24 ` Andrew Burgess
2022-10-06 6:36 ` [PATCH v2 2/7] sim/cris: " Tsukasa OI
2022-10-06 6:36 ` [PATCH v2 3/7] sim/erc32: " Tsukasa OI
2022-10-06 6:36 ` [PATCH v2 4/7] sim/m32c: " Tsukasa OI
2022-10-06 6:36 ` [PATCH v2 5/7] sim/m68hc11: " Tsukasa OI
2022-10-11 14:25 ` Andrew Burgess
2022-10-06 6:36 ` [PATCH v2 6/7] sim/ppc: " Tsukasa OI
2022-10-11 14:27 ` Andrew Burgess
2022-10-12 8:29 ` Jan-Benedict Glaw
2022-10-12 9:39 ` Andrew Burgess
2022-10-12 10:36 ` Jan-Benedict Glaw
2022-10-12 12:15 ` Jan-Benedict Glaw
2022-10-12 12:50 ` Jan-Benedict Glaw
2022-10-12 13:16 ` Tsukasa OI
2022-10-12 12:38 ` [PATCH 0/1] sim/ppc: Fix erroneous error calls (supplement) Tsukasa OI
2022-10-12 12:38 ` [PATCH 1/1] sim/ppc: Fix core_find_mapping diagnostics Tsukasa OI
2022-10-12 13:50 ` Andrew Burgess
2022-10-23 12:46 ` [PATCH v2 6/7] sim/ppc: Add ATTRIBUTE_PRINTF Mike Frysinger
2022-10-06 6:36 ` [PATCH v2 7/7] sim/rl78: " Tsukasa OI
2022-10-11 14:23 ` [PATCH v2 0/7] sim, sim/ARCH: " Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1665038133.git.research_trasio@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=Stephane.Carrez@gmail.com \
--cc=aburgess@redhat.com \
--cc=fche@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).