From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 6DC1B3853543 for ; Thu, 6 Oct 2022 06:43:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6DC1B3853543 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 775A7300089; Thu, 6 Oct 2022 06:43:56 +0000 (UTC) From: Tsukasa OI To: Tsukasa OI , Andrew Burgess , Mike Frysinger Cc: gdb-patches@sourceware.org Subject: [PATCH v3 0/5] sim: Suppress warnings if built with Clang Date: Thu, 6 Oct 2022 06:43:48 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2022 06:44:05 -0000 Hello, This is the version 2 patchset to suppress Clang compiler warnings (causes a build failure due to default -Werror). [Background] When we build Binutils and GDB with Clang, it causes a build failure due to warnings generated by Clang and the default -Werror configuration. I MOSTLY managed to make ALL ARCHITECTURE ENABLED Binutils and GDB -Werror-free on Clang 15.0.0 (note that this does not necessarily mean warning-free) and this patchset is a part of it (common simulator parts). - It still requires -Wno-implicit-function-declaration on the LatticeMicro32 and M32R simulators. Except them, most of Binutils / GDB components can be built with Clang by default with my tree. - I noticed that the assembler is not tested enough (because just with --enable-targets=all, it builds only host assembler). Full Clang 15.0.0 -Werror-free branch in development is available at: Tested configuration: - Ubuntu 22.04.1 LTS (x86_64) - LLVM / Clang 15.0.0 (built from source) - Configuration examples: $srcdir/configure \ --enable-targets=all \ --enable-multilib --enable-ld --enable-gold --enable-nls \ CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \ CFLAGS=' -O2 -g -Wno-implicit-function-declaration' \ CXXFLAGS='-O2 -g -Wno-implicit-function-declaration' $srcdir/configure \ --target=riscv64-unknown-linux-gnu \ --enable-multilib --enable-ld --enable-gold --enable-nls \ CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \ CFLAGS='-O2 -g' CXXFLAGS='-O2 -g' [About this Patchset] This patchset contains four five fixes to the files under sim{,/common}. Each contains minor fixes to suppress Clang / GCC warnings. Each change is detailed in the each patch. [Changes: v2 -> v3] - PATCH 2/5: Rewritten predicate macros from (!!x) to (x != 0). (This is based on the feedback by Andrew Burgess). - PATCH 3/5: Replaced with a patch by Andrew Burgess (slightly modified by me). - PATCH 4/5: Fix cached variable from ld_cv_* to sim_cv_*. - Removed ChangeLog from commit messages (based on the feedback [to another patchset by me] by Bruno Larsen). [Changes: v1 -> v2] - Commit messages are improved - PATCH v1 1/4 is Moved to another patchset - PATCH v1 2-4/4 -> PATCH v2 1-3/5 - New: Check known getopt definition on sim (PATCH v2 4/5) This test is already performed on binutils, gas, gprof and ld and this commit does the same to sim. - New: Initialize pbb_br_* by default (PATCH v2 5/5) It did not generate warnings on Clang but GCC creates some warnings (although those are not reported as errors). This is due to uninitialized pbb_br_* variables and this commit fixes the issue by initializing them by a harmless value. Thanks, Tsukasa Tsukasa OI (5): sim: Remove self-assignments sim: Make WITH_{TRACE,PROFILE}-based macros bool sim: Suppress non-literal printf warning sim: Check known getopt definition existence sim: Initialize pbb_br_* by default sim/common/genmloop.sh | 8 ++++---- sim/common/hw-tree.c | 2 -- sim/common/sim-hw.c | 26 ++++++++++++++++---------- sim/common/sim-profile.h | 12 ++++++------ sim/common/sim-trace.h | 4 ++-- sim/config.h.in | 3 +++ sim/configure | 32 ++++++++++++++++++++++++++++++++ sim/configure.ac | 10 ++++++++++ 8 files changed, 73 insertions(+), 24 deletions(-) base-commit: a13886e2198beb78b81c59839043b021ce6df78a -- 2.34.1