From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 086433858D33 for ; Fri, 6 Jan 2023 10:25:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 086433858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673000748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ayN7pXbd9rreHs9HiV0/dMvBRi0uNfaZFO74k2hudbM=; b=btTEw80EIfZi29i9iFoDnlwmINAOe+Vh9ESHbb2dkAK//ibwBhexlw7L7qvCRAx1hF3nRF 4F2U4LL6dBdc/ZfmTjUw6xnJaIrm24L96EP5s+7UvikST4zUjXT32gPpamTGwmNenDVydi JjgXXg+ayem52CWg5RT7Y1KwggPXO1I= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-662-YFCjIe61NfGlqtGjqxeLFA-1; Fri, 06 Jan 2023 05:25:47 -0500 X-MC-Unique: YFCjIe61NfGlqtGjqxeLFA-1 Received: by mail-ej1-f71.google.com with SMTP id hs18-20020a1709073e9200b007c0f9ac75f9so871490ejc.9 for ; Fri, 06 Jan 2023 02:25:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ayN7pXbd9rreHs9HiV0/dMvBRi0uNfaZFO74k2hudbM=; b=iPRY7WaVafysXYIkc/AMLiO3ue0ZX6KLb9hL/z4c1LmN+yZA1KtqA2ceQKxYjAPhzW 2hQazxMG9zEjZoSGtFj+ydT2doYpCYe3NP/RT8q9ajtPQVqpEBYc1mL/IpW2xTXn41AZ IcuOKgTUNPllf9+pSBBRDmTbMabVJDSLHBQQ+SmZxuCW68EIlRiiw4vJQ4fKb3dqRXs2 /+qYU5G/xwq/DWbwhJYPzLg8TYm953NyYS/ftlidBdrbReNoW5nmWTUIShgH0JmAoC9X mUgooJ9QZBbHv8guCc2pvFn3SdeWwC5DQnxAfKj4ZJPGJGaAFS86RcEmDBxu6SnOps73 gchA== X-Gm-Message-State: AFqh2kp4s1ZsgNfiNcBMHMIVMl3mYHAZ0zlWZVWshdapXR74BvSvi0Y2 guhAWX3ahX/+Rkk4TL6qN5k8WsGMvSbCL32kbis2slKpwiPh6JZ87ZpB9BZcWtK3rjmHSWeMkEJ NFHzJ7GenO3Yc2YKtLi/SbV81yb+09zxljHX7naOoKajZNUcGkj4ojd8vHNAtBwGU5Yd2SU0cVA == X-Received: by 2002:a05:6402:685:b0:46b:4011:9863 with SMTP id f5-20020a056402068500b0046b40119863mr47191735edy.39.1673000746517; Fri, 06 Jan 2023 02:25:46 -0800 (PST) X-Google-Smtp-Source: AMrXdXunVRf+L7KmvCDSdZVs22WkU2a1POXkpHDhjZbx9exM/9aDMCTOS7pFdhumG2aI5UoYYBPoaw== X-Received: by 2002:a05:6402:685:b0:46b:4011:9863 with SMTP id f5-20020a056402068500b0046b40119863mr47191717edy.39.1673000746293; Fri, 06 Jan 2023 02:25:46 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id b12-20020a05640202cc00b0046ee136fa3bsm346325edx.69.2023.01.06.02.25.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 02:25:45 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 00/15] Mixed bag of TUI tests and fixes Date: Fri, 6 Jan 2023 10:25:27 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This series started as a passing observation that an existing TUI tests was no longer working as expected. Then I noticed a gap in the testing... ... which exposed a bug ... ... and things spiralled from there :/ Thanks, Andrew --- Andrew Burgess (15): gdb/testsuite: extend gdb.tui/tui-layout.exp test script gdb/testsuite: update gdb.tui/tui-disasm-long-lines.exp gdb/testsuite: update gdb.tui/tui-nl-filtered-output.exp gdb/testsuite/tui: more testing of the 'focus' command gdb/tui: convert if/error to an assert gdb/tui: better filtering of tab completion results for focus command gdb/testsuite: fix line feed scrolling in tuiterm.exp gdb/tui: improve errors from tui focus command gdb/tui: disable tui mode when an assert triggers gdb/tui: make m_horizontal_offset private gdb/tui: rewrite of tui_source_window_base to handle very long lines gdb/tui: avoid extra refresh_window on horizontal scroll gdb/tui: avoid extra refresh_window on vertical scroll gdb/tui: more debug output gdb/tui: make use of a scoped_restore gdb/event-top.c | 8 + gdb/testsuite/gdb.tui/completion.exp | 18 +- .../gdb.tui/tui-disasm-long-lines.exp | 15 +- gdb/testsuite/gdb.tui/tui-focus.c | 22 ++ gdb/testsuite/gdb.tui/tui-focus.exp | 137 +++++++++++ gdb/testsuite/gdb.tui/tui-layout.exp | 57 ++++- .../gdb.tui/tui-nl-filtered-output.exp | 41 ++-- gdb/testsuite/lib/tuiterm.exp | 18 +- gdb/tui/tui-io.c | 10 +- gdb/tui/tui-layout.c | 11 +- gdb/tui/tui-layout.h | 45 ++++ gdb/tui/tui-win.c | 74 +++++- gdb/tui/tui-winsource.c | 216 ++++++++++++++++-- gdb/tui/tui-winsource.h | 69 +++++- gdb/tui/tui.h | 3 + gdb/utils.c | 7 +- 16 files changed, 656 insertions(+), 95 deletions(-) create mode 100644 gdb/testsuite/gdb.tui/tui-focus.c create mode 100644 gdb/testsuite/gdb.tui/tui-focus.exp base-commit: dcd469925324f430e8cf656c7f63538dd7a01d08 -- 2.25.4