public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 0/3] Python/TUI Window Creation / Destruction Fixes
Date: Thu, 12 Jan 2023 19:19:19 +0000	[thread overview]
Message-ID: <cover.1673550880.git.aburgess@redhat.com> (raw)

Patch #1 started with an observation that the behaviour of
gdb.register_window_type doesn't appear to exactly match up with the
documentation.

While fixing this I observed that the destruction of Python window
factory callbacks (as used by gdb.register_window_type) is
inconsistent, and that GDB knowingly leaks some memory in this area
too.  Patches #2 and #3 fix this and make the destruction behaviour
consistent.

All feedback welcome.

Thanks,
Andrew

---

Andrew Burgess (3):
  gdb/python: allow Python TUI windows to be replaced
  gdb/python: deallocate tui window factories at Python shut down
  gdb/tui: don't leak the known_window_types map

 gdb/python/py-tui.c                           |  52 +++++++-
 gdb/python/python-internal.h                  |   1 +
 gdb/python/python.c                           |   1 +
 .../gdb.python/tui-window-factory.exp         | 112 ++++++++++++++++++
 .../gdb.python/tui-window-factory.py          |  48 ++++++++
 gdb/tui/tui-layout.c                          |  39 +++---
 6 files changed, 232 insertions(+), 21 deletions(-)
 create mode 100644 gdb/testsuite/gdb.python/tui-window-factory.exp
 create mode 100644 gdb/testsuite/gdb.python/tui-window-factory.py


base-commit: 1a26a53a0dee39106ba58fcb15496c5f13074652
-- 
2.25.4


             reply	other threads:[~2023-01-12 19:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 19:19 Andrew Burgess [this message]
2023-01-12 19:19 ` [PATCH 1/3] gdb/python: allow Python TUI windows to be replaced Andrew Burgess
2023-01-12 19:19 ` [PATCH 2/3] gdb/python: deallocate tui window factories at Python shut down Andrew Burgess
2023-01-12 19:19 ` [PATCH 3/3] gdb/tui: don't leak the known_window_types map Andrew Burgess
2023-01-25 13:56 ` [PATCHv2 0/3] Python/TUI Window Creation / Destruction Fixes Andrew Burgess
2023-01-25 13:56   ` [PATCHv2 1/3] gdb/python: allow Python TUI windows to be replaced Andrew Burgess
2023-01-25 13:56   ` [PATCHv2 2/3] gdb/python: deallocate tui window factories at Python shut down Andrew Burgess
2023-01-25 13:56   ` [PATCHv2 3/3] gdb/tui: don't leak the known_window_types map Andrew Burgess
2023-01-27 16:34   ` [PATCHv3 0/3] Python/TUI Window Creation / Destruction Fixes Andrew Burgess
2023-01-27 16:34     ` [PATCHv3 1/3] gdb/python: allow Python TUI windows to be replaced Andrew Burgess
2023-01-27 16:34     ` [PATCHv3 2/3] gdb/python: deallocate tui window factories at Python shut down Andrew Burgess
2023-01-27 16:34     ` [PATCHv3 3/3] gdb/tui: don't leak the known_window_types map Andrew Burgess
2023-02-13 12:32     ` [PATCHv3 0/3] Python/TUI Window Creation / Destruction Fixes Andrew Burgess
2023-02-13 14:11       ` Tom Tromey
2023-02-13 14:52         ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1673550880.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).