From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 527DA3857803 for ; Thu, 23 Feb 2023 15:47:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 527DA3857803 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677167221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WuPB2Akj8mAneUFG8Uitliw2Ujz1C3k0HkVm6qRx1ts=; b=BdX1k2Zq6q777x2OjEjPakSPuBjoXpjoxAbErIqwabdOnzkBe/YzEn8CJRFzRs+i6oY5IP QBbm5tTMrxyz8gwApeu0+RRA4K09b2F7STLxgdkJzTOmy7Ss/RI4qtJilAau5EAtF17KJP /l4AMyf9i4lfA4cEa28mLbd4K1BaKlE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-629-1zxY94rQPkC-LhZZRZ3fTw-1; Thu, 23 Feb 2023 10:47:00 -0500 X-MC-Unique: 1zxY94rQPkC-LhZZRZ3fTw-1 Received: by mail-wm1-f69.google.com with SMTP id l23-20020a7bc457000000b003e206cbce8dso5181460wmi.7 for ; Thu, 23 Feb 2023 07:47:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WuPB2Akj8mAneUFG8Uitliw2Ujz1C3k0HkVm6qRx1ts=; b=pMfy4eSOMJ9eop3au5sKPREsxmtUutS7Lmg8/0k8RMDSl91e+UVJzQCHy9ICCpbswG Vt5zdlaug2qDDf015RVLWtWYUivx18LcEQ8Mdf68kamPoUGrj+yVgYxIvSFRrNeFdM17 09dN3eCV75So2STVNint6Jx9tkERVRdvaLNG2RhnV7HMdQ4V7QvCx2k/Iz1rnpHRrRYw Saz9xWR7EDa/HJh/eD3nQCLuacaEQ8poaTx/ejHTwwfa/h5OxrlRP/wrnXvi31pj0JZ4 gsfzLKpO7V6kaDJGCZHbvh5RtAE4woKNvioN9iJ4C4St61q+FrMCwLYdBIPbqH9wo0nD Myzg== X-Gm-Message-State: AO0yUKV7gz+Ng5XSqTX4DfTZBaNK+Kr9y0gmpw8WcpDydYNnXBMexAsU JFKj2xkAaUOWb3E3cBSCmrQ5GMbEb7T+PjmhIxDMkRsz1FKbd1NIrK8cwdyOlYpsFWQu57YEFHW 9xIEiv084tws44YtxyEOvzmNToiZjhVpG2lS4fviMEDDXQnuXJJKKTJo7NOlHwcAMtfGG4/TgqZ USWmQ= X-Received: by 2002:a05:600c:1d10:b0:3e7:b17f:9af1 with SMTP id l16-20020a05600c1d1000b003e7b17f9af1mr7100007wms.22.1677167219419; Thu, 23 Feb 2023 07:46:59 -0800 (PST) X-Google-Smtp-Source: AK7set9VAuyKFODphLU6kBc8XUXdwhS8CJ7kCslPlomOVMjbR1y1sGOvamkKgCT1+YxlE0WZRQ50JQ== X-Received: by 2002:a05:600c:1d10:b0:3e7:b17f:9af1 with SMTP id l16-20020a05600c1d1000b003e7b17f9af1mr7099995wms.22.1677167219086; Thu, 23 Feb 2023 07:46:59 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id n3-20020a1c7203000000b003dc522dd25esm11577380wmc.30.2023.02.23.07.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 07:46:58 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/3] AMD64 Displaced Stepping Fix Date: Thu, 23 Feb 2023 15:46:51 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I started looking at PR gdb/22921, which turns out to be a bug in our displaced stepping implementation. Patch #1 adds some extra debug output that I found super useful. Patch #2 is a minor cleanup. Patch #3 fixes the amd64 bug, but does change the displaced stepping logic a little (specifically how we fixup after displaced stepping), so this is what needs to most reviewing. All feedback welcome. Thanks, Andrew --- Andrew Burgess (3): gdb: more debug output for displaced stepping gdb: remove gdbarch_displaced_step_fixup_p gdb: fix reg corruption from displaced stepping on amd64 gdb/aarch64-tdep.c | 19 ++- gdb/aarch64-tdep.h | 3 +- gdb/amd64-tdep.c | 28 ++--- gdb/amd64-tdep.h | 2 +- gdb/arm-tdep.c | 27 ++++- gdb/arm-tdep.h | 3 +- gdb/displaced-stepping.c | 113 ++++++++++++------ gdb/displaced-stepping.h | 3 + gdb/gdbarch-components.py | 26 ++-- gdb/gdbarch-gen.h | 25 ++-- gdb/gdbarch.c | 18 +-- gdb/i386-tdep.c | 28 ++--- gdb/i386-tdep.h | 2 +- gdb/infrun.c | 35 ------ gdb/infrun.h | 3 - gdb/rs6000-tdep.c | 15 ++- gdb/s390-tdep.c | 16 ++- .../gdb.arch/amd64-disp-step-signal.c | 30 +++++ gdb/testsuite/gdb.arch/amd64-disp-step.S | 15 +++ gdb/testsuite/gdb.arch/amd64-disp-step.exp | 106 +++++++++++++--- 20 files changed, 348 insertions(+), 169 deletions(-) create mode 100644 gdb/testsuite/gdb.arch/amd64-disp-step-signal.c base-commit: 5e39600a691e3ba76acf6ab94edb24844c2e82b7 -- 2.25.4