From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCHv2 0/5] Add new gdbarch::displaced_step_buffer_length field
Date: Mon, 6 Mar 2023 15:31:52 +0000 [thread overview]
Message-ID: <cover.1678116328.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1677602918.git.aburgess@redhat.com>
Changes in v2:
- The final patch (#5), actually adding displaced_step_buffer_length
has been updated inline with Simon's feedback. The changes are
pretty minor so I've added the Approved-By tag.
- Patches #1 and #2 are new in this version. These two patches are
removing fields from gdbarch_components.py that have no effect on
the generated source. Removing these fields makes it easier to
refactor the gdbarch.py code in later commits.
- Patch #3 is from the v1 series and hasn't changed significantly.
I dropped the comment change on max_insn_length. Simon was
correct in his feedback, the changes I made to this comment made
little sense. The rest of the patch is basically unchagned.
- Patch #4 is new in this version. This makes the changes Simon
wanted to see about the 'invalid' field no longer being able to
take the value 'None', and also we can now have both a predicate
and a string 'invalid' field.
I did play with splitting these two changes (invalid can't be None
and predicate+string invalid), but this made little sense, and was
really forced. Allowing the second seems to fall naturally out of
refactoring the 'invalid' field to stop it taking the value 'None'.
Thoughts?
Thanks,
Andrew
---
Andrew Burgess (5):
gdb/gdbarch: remove unused 'invalid=True' from gdbarch_components.py
gdb/gdbarch: remove yet more 'invalid=True' from gdbarch_components.py
gdb/gdbarch: split postdefault setup from invalid check in gdbarch.py
gdb/gdbarch: remove the 'invalid=None' state from
gdbarch_components.py
gdb: add gdbarch::displaced_step_buffer_length
gdb/aarch64-linux-tdep.c | 4 +-
gdb/arm-tdep.c | 4 +-
gdb/displaced-stepping.c | 6 +-
gdb/gdbarch-gen.h | 12 +++-
gdb/gdbarch.c | 42 ++++++++++++
gdb/gdbarch.py | 60 ++++++++---------
gdb/gdbarch_components.py | 131 ++++++++++----------------------------
gdb/gdbarch_types.py | 7 +-
gdb/linux-tdep.c | 2 +-
gdb/rs6000-tdep.c | 6 +-
10 files changed, 134 insertions(+), 140 deletions(-)
base-commit: 6a208145d24c47912c8beb4f1f4b9abeb8d51134
--
2.25.4
next prev parent reply other threads:[~2023-03-06 15:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 16:51 [PATCH 0/2] Add new gdbarch::displaced_step_max_buffer_length field Andrew Burgess
2023-02-28 16:51 ` [PATCH 1/2] gdb: updates to gdbarch.py algorithm Andrew Burgess
2023-03-01 3:09 ` Simon Marchi
2023-03-02 10:13 ` Andrew Burgess
2023-03-02 16:49 ` Simon Marchi
2023-03-01 15:58 ` Tom Tromey
2023-02-28 16:51 ` [PATCH 2/2] gdb: add gdbarch::displaced_step_max_buffer_length Andrew Burgess
2023-03-02 18:28 ` Simon Marchi
2023-03-06 15:31 ` Andrew Burgess [this message]
2023-03-06 15:31 ` [PATCHv2 1/5] gdb/gdbarch: remove unused 'invalid=True' from gdbarch_components.py Andrew Burgess
2023-03-06 15:31 ` [PATCHv2 2/5] gdb/gdbarch: remove yet more " Andrew Burgess
2023-03-06 15:31 ` [PATCHv2 3/5] gdb/gdbarch: split postdefault setup from invalid check in gdbarch.py Andrew Burgess
2023-03-06 18:26 ` Simon Marchi
2023-03-06 15:31 ` [PATCHv2 4/5] gdb/gdbarch: remove the 'invalid=None' state from gdbarch_components.py Andrew Burgess
2023-03-06 20:13 ` Simon Marchi
2023-03-07 15:17 ` Tom Tromey
2023-03-07 15:20 ` Simon Marchi
2023-03-06 15:31 ` [PATCHv2 5/5] gdb: add gdbarch::displaced_step_buffer_length Andrew Burgess
2023-03-06 21:15 ` Simon Marchi
2023-03-10 18:43 ` [PATCHv3 0/9] Add new gdbarch::displaced_step_buffer_length field Andrew Burgess
2023-03-10 18:43 ` [PATCHv3 1/9] gdb/gdbarch: remove unused 'invalid=True' from gdbarch_components.py Andrew Burgess
2023-03-10 18:43 ` [PATCHv3 2/9] gdb/gdbarch: remove yet more " Andrew Burgess
2023-03-10 18:43 ` [PATCHv3 3/9] gdb/gdbarch: split postdefault setup from invalid check in gdbarch.py Andrew Burgess
2023-03-10 18:43 ` [PATCHv3 4/9] gdb/gdbarch: remove the 'invalid=None' state from gdbarch_components.py Andrew Burgess
2023-03-10 18:43 ` [PATCHv3 5/9] gdbarch: use predefault for more value components within gdbarch Andrew Burgess
2023-03-10 18:43 ` [PATCHv3 6/9] gdbarch: improve generation of validation in gdbarch getters Andrew Burgess
2023-03-11 2:57 ` Simon Marchi
2023-03-10 18:43 ` [PATCHv3 7/9] gdbarch: remove some unneeded predefault="0" from gdbarch_components.py Andrew Burgess
2023-03-10 18:43 ` [PATCHv3 8/9] gdbarch: make invalid=True the default for all Components Andrew Burgess
2023-03-10 18:43 ` [PATCHv3 9/9] gdb: add gdbarch::displaced_step_buffer_length Andrew Burgess
2023-03-11 2:57 ` [PATCHv3 0/9] Add new gdbarch::displaced_step_buffer_length field Simon Marchi
2023-03-13 22:01 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1678116328.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).