From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 35E143858D35 for ; Thu, 16 Mar 2023 16:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35E143858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678984852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cmWTf4OgE3HEIyegZ+GRESiwAr/GAWxGJi+c3goP4Wk=; b=SqYDwiVlDwa2LFlu73W/cwgLENMGxueBW9p+j5N2BdnQ6oeP9TdNNaj3VBUZAuQO5cXGma lqbcdYrGuE0TMgQdfS9q7TTQC94+uiyHeY/sxSWAPdgurQl8Y4xJDoMbhgHBjNvhFlUysC Z3H0RojOdKVb356zf8PEvatCNF4Uh4g= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-cChwC1Y2Ouiap5pcEdM3ng-1; Thu, 16 Mar 2023 12:40:51 -0400 X-MC-Unique: cChwC1Y2Ouiap5pcEdM3ng-1 Received: by mail-ed1-f72.google.com with SMTP id ev6-20020a056402540600b004bc2358ac04so3876225edb.21 for ; Thu, 16 Mar 2023 09:40:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678984850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cmWTf4OgE3HEIyegZ+GRESiwAr/GAWxGJi+c3goP4Wk=; b=DdPdxKzohbplF2nTRy592+d7W3RzXgHPUqBX2/JOnopituwj/BUOHfZvJJxi/bRJt9 qY6nzdzm3kKAqu5CcMXegXxu7ZAOTduzPGOi4o3+xwqpuh61KAG9QwYn/w0iKBtuUfkM vXK4KWYBtyjf+4TVAgSZ9HgE8yI93ZZSV4lBkxoE+W/4REVEOztmTta7hwGuuDSx3K3L PaupeDt6kQ/hy5ZmlfDBWz8xkS9tWLv3senE0smWBdaDuYyhkYDgeO+JuI+OVrDBjd1i 4fsWBphtwYA2XHc7BXO87YskHQqvBgsx6NYOTlKRK1gCfARxoapmBm0XrFX+IEAgsCRo x8kw== X-Gm-Message-State: AO0yUKXUeIePTjX0CBPkE6qProQBPPpf4Tk87JEvUIy9n6IRAL1+lYwj 0jzu7Jr0j+7Q15daB5MttdPg71+L6xS7cYQQ5NZb+HMkjUzjdudu4RVqnorapdGYfqEbYinNhLP XK2tbQdKdN2tBJK+ohv+8ZZrbOWAzFeDGZu5RBl9hyuEW+H/NEihU0x+DDmxvaDxKSUDMC+1hMx WgAeCrgQ== X-Received: by 2002:aa7:d5c7:0:b0:4fa:ada1:796d with SMTP id d7-20020aa7d5c7000000b004faada1796dmr240006eds.10.1678984850236; Thu, 16 Mar 2023 09:40:50 -0700 (PDT) X-Google-Smtp-Source: AK7set+5zLOSYK6ek/J7jmy3GC+IDQvtJzJ+YLG+eUPaOU+kbHMMaYRI+T2Iz4vrO9yu4btiNZW/sg== X-Received: by 2002:aa7:d5c7:0:b0:4fa:ada1:796d with SMTP id d7-20020aa7d5c7000000b004faada1796dmr239987eds.10.1678984849891; Thu, 16 Mar 2023 09:40:49 -0700 (PDT) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id i9-20020a50d749000000b004af6163f845sm4062284edj.28.2023.03.16.09.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 09:40:49 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 0/4] AMD64 Displaced Stepping Fix Date: Thu, 16 Mar 2023 16:39:28 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I started looking at PR gdb/22921, which turns out to be a bug in our displaced stepping implementation. Patch #1 adds some extra debug output that I found super useful. Patch #2 is a minor cleanup. Patch #3 fixes the amd64 bug, but does change the displaced stepping logic a little (specifically how we fixup after displaced stepping), so this is what needs to most reviewing. Patch #4 is new in V2, and removes some code that is no longer needed after patch #3. In V2: - Rebased to current HEAD of master, - Added patch #4. Thanks, Andrew --- Andrew Burgess (4): gdb: more debug output for displaced stepping gdb: remove gdbarch_displaced_step_fixup_p gdb: fix reg corruption from displaced stepping on amd64 gdb: remove redundant signal passing gdb/aarch64-tdep.c | 19 ++- gdb/aarch64-tdep.h | 3 +- gdb/amd64-tdep.c | 28 ++--- gdb/amd64-tdep.h | 2 +- gdb/arm-tdep.c | 27 +++- gdb/arm-tdep.h | 3 +- gdb/displaced-stepping.c | 116 ++++++++++++------ gdb/displaced-stepping.h | 6 +- gdb/gdbarch-gen.h | 29 +++-- gdb/gdbarch.c | 22 +--- gdb/gdbarch_components.py | 27 ++-- gdb/i386-tdep.c | 28 ++--- gdb/i386-tdep.h | 2 +- gdb/infrun.c | 51 +------- gdb/infrun.h | 3 - gdb/linux-tdep.c | 4 +- gdb/linux-tdep.h | 2 +- gdb/rs6000-tdep.c | 20 ++- gdb/s390-tdep.c | 16 ++- .../gdb.arch/amd64-disp-step-signal.c | 30 +++++ gdb/testsuite/gdb.arch/amd64-disp-step.S | 15 +++ gdb/testsuite/gdb.arch/amd64-disp-step.exp | 106 +++++++++++++--- 22 files changed, 366 insertions(+), 193 deletions(-) create mode 100644 gdb/testsuite/gdb.arch/amd64-disp-step-signal.c base-commit: 5a9affd7b875ac183a66ce41f3f226819f0790ed -- 2.25.4