[PATCHv3 0/2] Inferior specific breakpoints

[Andrew Burgess <aburgess@redhat.com>]

Changes in v3:

  - Patches #2, #3, and #4 from the previous series have been merged.

  - Patch #1 is removed from this series in favour of a future patch
    from Pedro as mentioned here:

    https://sourceware.org/pipermail/gdb-patches/2023-February/196557.html

  - Patch #6 has been removed.  The core part of this patch (changing
    how the 'start' breakpoint is created) has been merged back into
    patch #5.  The extra tests added in the old #6 are no longer
    relevant and have been dropped.  The 'start' command is already
    tested in our testsuite, so this extra change should be well tested.

  - In patch #5:

    + The docs are unchanged (actually I fixed 'a' to 'an' in one place).

    + Inferior breakpoints are deleted when the inferior is removed,
      not when it exits.

    + We still don't filter breakpoint locations based on the inferior
      program space, but this is now discussed in the commitmessage.
      Bascially doing this opens a huge can of worms.  I am working on
      this, but see this as a future optimisation rather than a
      blocker for this initial change.

    + Pedro's feedback about how inferior specific breakpoints were
      deleted has been addressed.  Since Pedro's initial feedback I've
      fixed how thread-specific breakpoints are deleted (I had
      originally just copied this code), and I've now copied the fixed
      code.

    + The patch no longer adds inferior specific watchpoints.  As
      Pedro pointed out this feature would only have had a very
      limited niche use case, and I didn't see the value of trying to
      include that change in this commit.  If a user tries to create
      an inferior-specific watchpoint they'll now get an error.  We
      could change this in the future if we're keen.

Changes in v2:

  - Biggest changes are in patch #3, as suggested by Baris, I've now
    removed the 'thread' and 'inferior' tags from the end of each
    location in the 'info breakpoints' output.  The information was
    already available in the condition line, so this removes some
    duplication.  For Ada task conditions I've added a condition line
    as this was missing.

  - Doc updates in #4 and #5 to fix the issues Eli pointed out.  These
    all seemed pretty minor so I don't think there should be anything
    too surprising there.

  - Updated patch #5 based on feedback from Baris, this was all pretty
    minor stuff though, formatting, and rewording some error messages,

  - Updated patch #6 based on feedback from Baris, this is a minor
    test cleanup.

Thanks,
Andrew

---

Andrew Burgess (2):
  gdb: cleanup around some set_momentary_breakpoint_at_pc calls
  gdb: add inferior-specific breakpoints

 gdb/NEWS                                      |  15 ++
 gdb/breakpoint.c                              | 237 ++++++++++++++----
 gdb/breakpoint.h                              |  14 +-
 gdb/doc/gdb.texinfo                           |  72 +++++-
 gdb/doc/python.texi                           |  26 +-
 gdb/guile/scm-breakpoint.c                    |   7 +-
 gdb/infcmd.c                                  |  15 +-
 gdb/inferior.h                                |  11 +
 gdb/infrun.c                                  |  12 +-
 gdb/linespec.c                                |   4 +-
 gdb/mi/mi-cmd-break.c                         |  11 +-
 gdb/mi/mi-main.c                              |  18 +-
 gdb/mi/mi-main.h                              |   6 +
 gdb/python/py-breakpoint.c                    |  96 ++++++-
 gdb/python/py-finishbreakpoint.c              |   2 +-
 gdb/testsuite/gdb.ada/tasks.exp               |   2 +
 gdb/testsuite/gdb.linespec/cpcompletion.exp   |   4 +-
 gdb/testsuite/gdb.linespec/explicit.exp       |   1 +
 gdb/testsuite/gdb.mi/new-ui-bp-deleted.c      |  29 +++
 gdb/testsuite/gdb.mi/new-ui-bp-deleted.exp    | 108 ++++++++
 .../gdb.multi/inferior-specific-bp-1.c        |  52 ++++
 .../gdb.multi/inferior-specific-bp-2.c        |  52 ++++
 .../gdb.multi/inferior-specific-bp.exp        | 179 +++++++++++++
 gdb/testsuite/gdb.python/py-breakpoint.exp    |  43 ++++
 gdb/testsuite/lib/completion-support.exp      |   2 +-
 gdb/testsuite/lib/mi-support.exp              |  20 +-
 26 files changed, 946 insertions(+), 92 deletions(-)
 create mode 100644 gdb/testsuite/gdb.mi/new-ui-bp-deleted.c
 create mode 100644 gdb/testsuite/gdb.mi/new-ui-bp-deleted.exp
 create mode 100644 gdb/testsuite/gdb.multi/inferior-specific-bp-1.c
 create mode 100644 gdb/testsuite/gdb.multi/inferior-specific-bp-2.c
 create mode 100644 gdb/testsuite/gdb.multi/inferior-specific-bp.exp


base-commit: 5a9affd7b875ac183a66ce41f3f226819f0790ed
-- 
2.25.4