From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A2C7B3858D39 for ; Mon, 3 Apr 2023 14:01:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2C7B3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680530484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dIOKmFjkNLd8m3em7//cnXsWm7C+wYjd8jWO5l3Q8Ak=; b=bDHAQ73bViMqTvwBPhR9E9KSjs1L4hHlJ1LfUJg7lwcNc90zHY6lT8KzECOwBJAoqmblWt ye7MqMoHVUNtf2L9ZIMVEAwk/os63cioWPRwVRznrEVNEkdIKxLhClwWGEHtNEd51GofOq 9oP/gWxLjjoLZejC1VIlFaVNKNh7RKA= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-huL5XQGZM2W5HvqrT_X2fg-1; Mon, 03 Apr 2023 10:01:22 -0400 X-MC-Unique: huL5XQGZM2W5HvqrT_X2fg-1 Received: by mail-oi1-f200.google.com with SMTP id n205-20020acabdd6000000b003846654dd65so7048514oif.19 for ; Mon, 03 Apr 2023 07:01:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680530481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dIOKmFjkNLd8m3em7//cnXsWm7C+wYjd8jWO5l3Q8Ak=; b=0wmhRfoTcnmeVQny7u6+IjEN5ZOcOFLPCJGV4y96718aZE8WfZZxfFuJGM1D7Uan8E V3tbAIsyk6qrHFZtHiAFefrzP3GwExpqcdpa1uAh2xG7J9ehJfZbGaptopFFLrgvdtSY zszYs140hJKLA7QVSKCZHI7APUe02Z9ChPUmekg+QmMJ1Wc66sdU+1CZ5VIqqkvuZXqg pIC2QmND4DgapBe2IwCiE72t56UvWcGjLSbaZasd6M8XV50Kx1v6XE2H5n4xbJix0JMv QZv8nhY6wI26MhKp8MkOc7NKNl+55XA7i9flqXway7pZipDGR50PEto3ZnwpJegXwua7 evSA== X-Gm-Message-State: AAQBX9eXQ03+VtH8eVBi+VCZ185Sw+MMBmhRC6CM7ZjMGOIXopqKt1CV Qhw0OtN/qNR4M1Sa62d/oNNX5gddcRrKEVcyYVq1UV0sl1uKdfAnHdYyJBlrGOPwwXa4UmD/M2q HTzLkxTplSKiaLQ2ANpa+1exo1wu+hJwwBfLSDAikx0A5jaTvrwG3VvXqxJVZubWvxUQ02ZB7P7 4Nx2hbuA== X-Received: by 2002:a05:6808:280f:b0:389:4a00:51b5 with SMTP id et15-20020a056808280f00b003894a0051b5mr11450552oib.8.1680530481715; Mon, 03 Apr 2023 07:01:21 -0700 (PDT) X-Google-Smtp-Source: AKy350aYQ2JlxwOfssTHYSfU4gY40vZNtCZJg3kKhqI5mCTyMzKI1CesVCuv6XwXFx25w1H1hTnsQA== X-Received: by 2002:a05:6808:280f:b0:389:4a00:51b5 with SMTP id et15-20020a056808280f00b003894a0051b5mr11450527oib.8.1680530481367; Mon, 03 Apr 2023 07:01:21 -0700 (PDT) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id p1-20020a05621415c100b005dd8b9345b8sm2660360qvz.80.2023.04.03.07.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 07:01:21 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv6 0/6] Infcalls from B/P conditions in multi-threaded inferiors Date: Mon, 3 Apr 2023 15:01:12 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In v6: - Pushed the 5 initial patches. These were the smaller fixes, and, I felt were pretty obvious fixes. I'm sure folk will raise objections if they disagree. - Of the remaining patches, #1 to #5 really needs review before they can be merged. Patch #6 is an obvious cleanup once the first five have been merged. - I've rebased onto current HEAD of master, there's no significant changes. - All other documentation changes have been reviewed and approved. In v5: - Rebased to current HEAD of master, minor merge conflict resolved. No other code or documentation changes. - First patch, which was pure documentation, has now been merged. - All other documentation changes have been reviewed and approved. In v4: - I believe all the docs changes have been reviewed and approved by Eli, - Rebased onto current master, - Dropped patch #2 from the V3 series, - I have addressed all the issues Baris pointed out, including the fixes for the patch #9 ('gdb: add timeouts for inferior function calls'), which I forgot to do in V3. In v3: - Updates for review feedback, biggest changes in #10 and #11, but minor changes to most patches. In V2: - Rebased onto something closer to HEAD of master, - Patches #1, #2, #12, and #13 are new in this series, - Patches #3 to #9, and #11 are unchanged since their V1 iteration, - Patches #10 has changed slightly in implementation since v1, and the docs have been significantly updated. --- Andrew Burgess (6): Revert "gdb: remove unnecessary parameter wait_ptid from do_target_wait" gdb: fix b/p conditions with infcalls in multi-threaded inferiors gdb: add timeouts for inferior function calls gdb/remote: avoid SIGINT after calling remote_target::stop gdb: introduce unwind-on-timeout setting gdb: rename unwindonsignal to unwind-on-signal gdb/NEWS | 38 +++ gdb/breakpoint.c | 2 + gdb/doc/gdb.texinfo | 105 ++++++- gdb/gdbthread.h | 3 + gdb/infcall.c | 296 +++++++++++++++++- gdb/infrun.c | 70 ++++- gdb/infrun.h | 3 +- gdb/remote.c | 10 + gdb/testsuite/gdb.base/callfuncs.exp | 4 +- gdb/testsuite/gdb.base/help.exp | 2 +- gdb/testsuite/gdb.base/infcall-failure.exp | 4 +- gdb/testsuite/gdb.base/infcall-timeout.c | 36 +++ gdb/testsuite/gdb.base/infcall-timeout.exp | 98 ++++++ gdb/testsuite/gdb.base/unwindonsignal.exp | 36 ++- gdb/testsuite/gdb.compile/compile-cplus.exp | 2 +- gdb/testsuite/gdb.compile/compile.exp | 2 +- gdb/testsuite/gdb.cp/gdb2495.exp | 16 +- gdb/testsuite/gdb.fortran/function-calls.exp | 2 +- gdb/testsuite/gdb.mi/mi-syn-frame.exp | 2 +- .../infcall-from-bp-cond-other-thread-event.c | 135 ++++++++ ...nfcall-from-bp-cond-other-thread-event.exp | 174 ++++++++++ .../gdb.threads/infcall-from-bp-cond-simple.c | 89 ++++++ .../infcall-from-bp-cond-simple.exp | 235 ++++++++++++++ .../gdb.threads/infcall-from-bp-cond-single.c | 139 ++++++++ .../infcall-from-bp-cond-single.exp | 117 +++++++ .../infcall-from-bp-cond-timeout.c | 169 ++++++++++ .../infcall-from-bp-cond-timeout.exp | 174 ++++++++++ .../gdb.threads/thread-unwindonsignal.exp | 8 +- 28 files changed, 1903 insertions(+), 68 deletions(-) create mode 100644 gdb/testsuite/gdb.base/infcall-timeout.c create mode 100644 gdb/testsuite/gdb.base/infcall-timeout.exp create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-other-thread-event.c create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-other-thread-event.exp create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.exp create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-single.c create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-single.exp create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-timeout.c create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-timeout.exp base-commit: 2e411b8c68eb2b035b31d5b00d940d4be1a0928b -- 2.25.4