From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 14B3F3858404 for ; Wed, 7 Jun 2023 10:01:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14B3F3858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686132085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BG3puUrMv9ohJnwO6QQSu4l3GKCg4uBURDoCi100y5g=; b=LQil7E8lQfleLu5gkPu/m1KgE80YWhSLsNGOs25DmUW/MN0RdsYaKNfu4GiY/BTCeIsHe2 oTxKfI8+iQuY5SodhsrgQfgt6cL8FaywDr8ji9EghMPgnkkb5wsYScyJm1YzfoheVjYmbJ Yx1wK3drhj6FW3PtpJjtQMsv6V0bJrs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-UVkmg7T_Mv6EyIfZOm44nQ-1; Wed, 07 Jun 2023 06:01:24 -0400 X-MC-Unique: UVkmg7T_Mv6EyIfZOm44nQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-30c6060eb32so8461712f8f.1 for ; Wed, 07 Jun 2023 03:01:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686132083; x=1688724083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BG3puUrMv9ohJnwO6QQSu4l3GKCg4uBURDoCi100y5g=; b=B5jEKCviXGlT+uNExnXqVcZhdZJmp89OWGO044l1ddZ25OtdQ+4fJ9T8RAmk2INin9 pnaIkrHwlrB2Czf9oNE2Zmms3nT8C6bjqiwTyFeMbuDiS/kTTYPLdovyWVlL8teH4YAP QamPp5Qh8FfW/Qbpjp4gYgUa2VCthr18XpwqvKp6CicUvO0N7AKu0ZSws+C1OllDA9Dj RGTkANHsyBskzyuwAmrzbcdjBjImxBweetlxs8km8ztysF9k0RTp6qzPTlFRHL1XTKkC MVTo7oblD2+Koguk9/GkGimil1sFBs+gwYop5XjZiMJLZ6HHykfMpGBLr7d6zkj7wKmm SO0w== X-Gm-Message-State: AC+VfDzmuNG0m92/wk68mIstwtTOnzWIvrsfI18u905MO+Te6Fo6vCNt r4lt77IXz9PO+LD0tDvN+sCFVltowVBrOwjrQs0zIXj35pLbn7GYJBK4E4/GbGqF5KrSA9Jn+Ia zfPgdbqoYXpY6O0y7iuGxP7CVzXLkPwaaUpxEKrW+dlX3YnJFL7RrQ7hI09vVSDckpaDw8adaNQ uFHg6iSg== X-Received: by 2002:adf:e4c9:0:b0:307:9473:fe26 with SMTP id v9-20020adfe4c9000000b003079473fe26mr4614056wrm.26.1686132082884; Wed, 07 Jun 2023 03:01:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ46hbPn68DlmUPkxHBNqk5INl7fBc2HCGkLKUCq/EMKPQQ8m2mJ6ay72KxdePtNk74aESpq6A== X-Received: by 2002:adf:e4c9:0:b0:307:9473:fe26 with SMTP id v9-20020adfe4c9000000b003079473fe26mr4614027wrm.26.1686132082404; Wed, 07 Jun 2023 03:01:22 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id u4-20020a5d5144000000b003062b2c5255sm15017455wrt.40.2023.06.07.03.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 03:01:21 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv8 0/6] Infcalls from B/P conditions in multi-threaded inferiors Date: Wed, 7 Jun 2023 11:01:12 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In v8: - Rebased onto current upstream/master and retested. - Addressed feedback from Baris on patches 1, 2, 3, & 4. This was mostly minor stuff, comment typos and some improvements to the testsuite. There was one real (but minor) GDB change in patch 4. In v7: - Rebased onto current upstream/master, fixed use of find_thread_ptid which is now a process_stratum_target method, - Retested, with no regressions seen. In v6: - Pushed the 5 initial patches. These were the smaller fixes, and, I felt were pretty obvious fixes. I'm sure folk will raise objections if they disagree. - Of the remaining patches, #1 to #5 really needs review before they can be merged. Patch #6 is an obvious cleanup once the first five have been merged. - I've rebased onto current HEAD of master, there's no significant changes. - All other documentation changes have been reviewed and approved. In v5: - Rebased to current HEAD of master, minor merge conflict resolved. No other code or documentation changes. - First patch, which was pure documentation, has now been merged. - All other documentation changes have been reviewed and approved. In v4: - I believe all the docs changes have been reviewed and approved by Eli, - Rebased onto current master, - Dropped patch #2 from the V3 series, - I have addressed all the issues Baris pointed out, including the fixes for the patch #9 ('gdb: add timeouts for inferior function calls'), which I forgot to do in V3. In v3: - Updates for review feedback, biggest changes in #10 and #11, but minor changes to most patches. In V2: - Rebased onto something closer to HEAD of master, - Patches #1, #2, #12, and #13 are new in this series, - Patches #3 to #9, and #11 are unchanged since their V1 iteration, - Patches #10 has changed slightly in implementation since v1, and the docs have been significantly updated. --- Andrew Burgess (6): Revert "gdb: remove unnecessary parameter wait_ptid from do_target_wait" gdb: fix b/p conditions with infcalls in multi-threaded inferiors gdb: add timeouts for inferior function calls gdb/remote: avoid SIGINT after calling remote_target::stop gdb: introduce unwind-on-timeout setting gdb: rename unwindonsignal to unwind-on-signal gdb/NEWS | 38 +++ gdb/breakpoint.c | 2 + gdb/doc/gdb.texinfo | 105 ++++++- gdb/gdbthread.h | 3 + gdb/infcall.c | 296 +++++++++++++++++- gdb/infrun.c | 70 ++++- gdb/infrun.h | 3 +- gdb/remote.c | 23 +- gdb/testsuite/gdb.base/callfuncs.exp | 4 +- gdb/testsuite/gdb.base/help.exp | 2 +- gdb/testsuite/gdb.base/infcall-failure.exp | 4 +- gdb/testsuite/gdb.base/infcall-timeout.c | 36 +++ gdb/testsuite/gdb.base/infcall-timeout.exp | 97 ++++++ gdb/testsuite/gdb.base/unwindonsignal.exp | 36 ++- gdb/testsuite/gdb.compile/compile-cplus.exp | 2 +- gdb/testsuite/gdb.compile/compile.exp | 2 +- gdb/testsuite/gdb.cp/gdb2495.exp | 16 +- gdb/testsuite/gdb.fortran/function-calls.exp | 2 +- gdb/testsuite/gdb.mi/mi-syn-frame.exp | 2 +- .../infcall-from-bp-cond-other-thread-event.c | 135 ++++++++ ...nfcall-from-bp-cond-other-thread-event.exp | 174 ++++++++++ .../gdb.threads/infcall-from-bp-cond-simple.c | 89 ++++++ .../infcall-from-bp-cond-simple.exp | 235 ++++++++++++++ .../gdb.threads/infcall-from-bp-cond-single.c | 139 ++++++++ .../infcall-from-bp-cond-single.exp | 117 +++++++ .../infcall-from-bp-cond-timeout.c | 169 ++++++++++ .../infcall-from-bp-cond-timeout.exp | 173 ++++++++++ .../gdb.threads/thread-unwindonsignal.exp | 8 +- 28 files changed, 1902 insertions(+), 80 deletions(-) create mode 100644 gdb/testsuite/gdb.base/infcall-timeout.c create mode 100644 gdb/testsuite/gdb.base/infcall-timeout.exp create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-other-thread-event.c create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-other-thread-event.exp create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.exp create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-single.c create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-single.exp create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-timeout.c create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-timeout.exp base-commit: baab375361c365afee2577c94cbbd3fdd443d6da -- 2.25.4