From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 445203857B93 for ; Wed, 27 Sep 2023 14:22:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 445203857B93 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695824531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7xLdGbtZ0ajg4xcySF+nTmEuYRRz1MlxrjJLivW0j2g=; b=aTz8DlxomIKa+AcdeiDc5R8Jbzv2MtnYyZbG9hnatvgPBBMHWvk2FJrMqVa9VwH46jNqkb nEQeuoedpzNs/qDBvHDcmMsXe4GTDlbAgo+JPw8nTiPvdpde4cBy3Rj2tYjp8jGKFplpu7 boB1wQxoTG5o60HoxekdEA1ZlFrpwVw= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-BE1OfISJNZ-9lX14sJpsKA-1; Wed, 27 Sep 2023 10:22:10 -0400 X-MC-Unique: BE1OfISJNZ-9lX14sJpsKA-1 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-45266ea607eso6737964137.3 for ; Wed, 27 Sep 2023 07:22:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695824530; x=1696429330; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7xLdGbtZ0ajg4xcySF+nTmEuYRRz1MlxrjJLivW0j2g=; b=FyTtx0asvZHqWIYMUspsHpVwt7PSsKJAJ4s9SYou+qyvty99re9+yd3bEa10QuOKze eeIhqi01VvorjGGbeyo4i1NfACieLhgWjXw43RMUmxsWA2OW6tiKoTethaUgcooRTqRr iQQRK7IME11zeH+U7fskLR+H6LOiIavuzoQN3CHFhLj6BB+2eKZYGMRqKgJCGpQycyrh vI4bcFxaaIqEHEBjTRUIGI5GtjIiWmpRQ713aj7GtTqUpk/3dNZbyeJwboUHPSaUS39o Bn9xGf6JLReezsBcC+gQ2q4FlHU/yIsIXY/uoYSwKFx8tl9VOfdymd45bw6APr/vxNBJ /Unw== X-Gm-Message-State: AOJu0YymOub/HDzKi08XAbTk0rIL4YIrdeXVly4jixveyDgrt0lmUAdh Ib2P5v3bua6X45d/mig/IgSQ86ktuORfTax86CjkwApQf+cRK25KMvzLAdoDpHT6FDSBAbgX0yK lNFK3zCAJX/DVcsSmy9NOmN5FraxIbKqBHJM0zrCLJ3BWq3HBCJUxu2wwjc3HDr9uhM8gYibHtB 1WcYgHSw== X-Received: by 2002:a05:6102:3163:b0:452:5d45:6345 with SMTP id l3-20020a056102316300b004525d456345mr1809301vsm.34.1695824529803; Wed, 27 Sep 2023 07:22:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkX/WfGkSgP3CuI4NjOIA0hCmk4d2p09diJoSvtuxDDIlagA+LdnB0sVsMmQ2KUygsGzfBSw== X-Received: by 2002:a05:6102:3163:b0:452:5d45:6345 with SMTP id l3-20020a056102316300b004525d456345mr1809268vsm.34.1695824529189; Wed, 27 Sep 2023 07:22:09 -0700 (PDT) Received: from localhost ([31.111.84.209]) by smtp.gmail.com with ESMTPSA id h3-20020a0cf403000000b00655d711180dsm869301qvl.17.2023.09.27.07.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 07:22:08 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/5] Fix using an exec file with target: prefix Date: Wed, 27 Sep 2023 15:22:00 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I spotted that if a user specifies an executable with a target: prefix, e.g.: (gdb) file target:/path/to/exec Then GDB _almost_ does what we'd want. This is definitely suppsosed to work as there's some code in place to support this .... but there's also a bug. Patch #5 fixes this issue. Patches #1 to #4 are various bits of cleanup and refactoring that fell out while I was working on patch #5. --- Andrew Burgess (5): gdb: some additional filename styling gdb: use archive name in warning when appropriate gdb: remove use of a static buffer for building error strings gdb: remove print_sys_errmsg gdb: fix reread_symbols when an objfile has target: prefix gdb/inflow.c | 3 +- gdb/main.c | 7 +- gdb/procfs.c | 32 ++-- gdb/source.c | 18 +- gdb/symfile.c | 30 ++- gdb/target.c | 15 ++ gdb/target.h | 39 ++++ gdb/testsuite/gdb.server/target-exec-file.c | 22 +++ gdb/testsuite/gdb.server/target-exec-file.exp | 174 ++++++++++++++++++ gdb/utils.c | 9 +- gdb/utils.h | 8 +- gdb/windows-nat.c | 2 +- 12 files changed, 313 insertions(+), 46 deletions(-) create mode 100644 gdb/testsuite/gdb.server/target-exec-file.c create mode 100644 gdb/testsuite/gdb.server/target-exec-file.exp base-commit: f586e3409b752748bf213520c2dbb0b44e0005d8 -- 2.25.4