From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D919E3858D39 for ; Tue, 3 Oct 2023 21:29:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D919E3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696368589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=688rTXE805h/s5fx/SRKQYmTPPbAp1+cQkrJcZqrfEQ=; b=i9ze49nGFsy7vlKYLjT+NcfuCib7tBfK8dYiSN6lvB0w44qHmPepAAjLNbwuH4SgGGmbK8 3b+F13E07Tr/cNorNk9qYtfPs3+sASwZsk0+00s95c98lajpDlgoNhaWT/Eazz5uBCcErP 0OnFdFXP6D3p7iIEBqhmh9tv9Y99awE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-p-hzP5JRPOWlFq70f3t9Lw-1; Tue, 03 Oct 2023 17:29:48 -0400 X-MC-Unique: p-hzP5JRPOWlFq70f3t9Lw-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-99bca0b9234so121725966b.2 for ; Tue, 03 Oct 2023 14:29:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696368587; x=1696973387; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=688rTXE805h/s5fx/SRKQYmTPPbAp1+cQkrJcZqrfEQ=; b=D/rU1opP9H1IuUV8U6n977N3FRLLCSoOX3gMQY85t2+nOOZfzOjJypsIfKY1YjqeQo cfVRGkUFmS5dPVHsEotH10oA0O+/yh5DtUhihvkypJtQ1hEnL9tO6VnfqFSEVcdvnleN /XeSWdBKlY2DVTgxA3RjjMDkKqpwk1/VwvBtxW/Cfz6ragNmeZNRk1PCtqtVS8dvRWXC HAShHKSUsbvA8av/rwA5B8xwodeM6qFWapqnHgugDlMAU2eDkDB5UbKUw6jdodI5/mb7 KVEQrzds6TgL4D0COH8c1xcyAv0iz4P6v+GTyIeAAhbL6+rmj2UwTbzOURSh3AW28la3 nHdA== X-Gm-Message-State: AOJu0Yw7OaHS9Bv0n+d3l4/PZvDzNyWz15Bz3lNcewezethq+FNQa+3Y mZD/ThQk7aCvYz92zdXvt0fXHWntEVwj8z0euQjacK8KdQmaYOR/7hwZV9V5rN4vu5Qdt7kVv9Q A8TEFNNaI4v2oG6TCBum+/STTFg3bk9trgckWaD7qg84kb3qQnzCdQ0vKLm/8Y9PjYaBNG5Sla/ WIJydPqg== X-Received: by 2002:a17:906:2011:b0:9ae:6ff4:9f15 with SMTP id 17-20020a170906201100b009ae6ff49f15mr363147ejo.11.1696368587206; Tue, 03 Oct 2023 14:29:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDrVGjnw+fK+o9zk28dD/g9z3XSpvR055dbrynYxmqcL/hz9cYjD1ca8VYyBRXypyO5xS2VA== X-Received: by 2002:a17:906:2011:b0:9ae:6ff4:9f15 with SMTP id 17-20020a170906201100b009ae6ff49f15mr363114ejo.11.1696368586175; Tue, 03 Oct 2023 14:29:46 -0700 (PDT) Received: from localhost ([31.111.84.209]) by smtp.gmail.com with ESMTPSA id fy17-20020a170906b7d100b009adca8ada31sm1656542ejb.12.2023.10.03.14.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 14:29:44 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess , Lancelot SIX Subject: [PATCHv5 00/10] thread-specific breakpoints in just some inferiors Date: Tue, 3 Oct 2023 22:29:33 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In v5: - Updates after Lancelot's feedback, including, -force-condition can no longer be abbreviated to '-', and can't be used immediately after the breakpoint condition. - More tests to check some of the edge cases. In v4: - Big update, this series now handles thread-specific and inferior-specific breakpoints. In v3: - Rebased on to current upstream/master, this includes all Simon's recent breakpoint changes. Retested with no regressions seen. In v2: - Rebased on current upstream/master and retested, - No changes to code or docs. --- Andrew Burgess (10): gdb: create_breakpoint: add asserts and additional comments gdb: create_breakpoint: asserts relating to extra_string/parse_extra gdb: change 'if' to gdb_assert in update_dprintf_command_list gdb: build dprintf commands just once in code_breakpoint constructor gdb: don't display inferior list for pending breakpoints gdb: parse pending breakpoint thread/task immediately gdb: don't set breakpoint::pspace for in create_breakpoint gdb: remove breakpoint_re_set_one gdb: remove tracepoint_probe_create_sals_from_location_spec gdb: only insert thread-specific breakpoints in the relevant inferior gdb/Makefile.in | 2 + gdb/NEWS | 11 + gdb/ada-lang.c | 6 +- gdb/break-catch-throw.c | 6 +- gdb/break-cond-parse.c | 463 +++++++++++ gdb/break-cond-parse.h | 49 ++ gdb/breakpoint.c | 757 +++++++++--------- gdb/breakpoint.h | 101 ++- gdb/testsuite/gdb.ada/tasks.exp | 6 +- gdb/testsuite/gdb.base/condbreak.exp | 57 +- gdb/testsuite/gdb.base/pending.exp | 23 +- gdb/testsuite/gdb.linespec/explicit.exp | 4 +- gdb/testsuite/gdb.mi/mi-dprintf-pending.exp | 3 +- gdb/testsuite/gdb.mi/new-ui-bp-deleted.exp | 8 +- .../gdb.mi/user-selected-context-sync.exp | 4 +- .../gdb.multi/bp-thread-specific.exp | 7 +- .../gdb.multi/inferior-specific-bp.exp | 16 +- .../gdb.multi/multi-target-continue.exp | 2 +- .../gdb.multi/multi-target-ping-pong-next.exp | 4 +- .../gdb.multi/pending-bp-del-inferior.c | 28 + .../gdb.multi/pending-bp-del-inferior.exp | 214 +++++ gdb/testsuite/gdb.multi/pending-bp-lib.c | 22 + gdb/testsuite/gdb.multi/pending-bp.c | 66 ++ gdb/testsuite/gdb.multi/pending-bp.exp | 336 ++++++++ gdb/testsuite/gdb.multi/tids.exp | 6 +- .../gdb.threads/del-pending-thread-bp-lib.c | 22 + .../gdb.threads/del-pending-thread-bp.c | 85 ++ .../gdb.threads/del-pending-thread-bp.exp | 108 +++ 28 files changed, 1947 insertions(+), 469 deletions(-) create mode 100644 gdb/break-cond-parse.c create mode 100644 gdb/break-cond-parse.h create mode 100644 gdb/testsuite/gdb.multi/pending-bp-del-inferior.c create mode 100644 gdb/testsuite/gdb.multi/pending-bp-del-inferior.exp create mode 100644 gdb/testsuite/gdb.multi/pending-bp-lib.c create mode 100644 gdb/testsuite/gdb.multi/pending-bp.c create mode 100644 gdb/testsuite/gdb.multi/pending-bp.exp create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp-lib.c create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp.c create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp.exp base-commit: e030ce2c79feee6a35665a6580a23dcf937ea46f -- 2.25.4