From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9B0193858D20 for ; Fri, 29 Mar 2024 11:42:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B0193858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9B0193858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711712560; cv=none; b=JOVJ33h5SZzvt1oaTe81/HDC8y9dlitZhglgy64kCxmTieVBOKLfDHIwDEpg1ukt4kYMcw1EylYeyAvjeFrSq3qzXhhqBpCci+ntFfCuJDogwj/VNyt0sUIoXv1XCEuAJd6lNiFpZ3Gxw5iiVAvPMZTaYK07o+u8xRbCgQAhcv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711712560; c=relaxed/simple; bh=nx/BvR5IVNGKGpm6/iHSV0qAY2stCtyfFPXmd0NwWt4=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=FGM3a+U4EMA9OXUDJPTrihnP3DSTmzd8tD4T9z1GT/QStjAGERRI4mYquYogmmN8ODkIR/wKQtnERKtjVARpO0pR2EZwoYSv6dVm3lNnTvdbtVWum78HUNMuiNXbgnGnrMSs2Hi9g2QBrLrjQpRIjC6tJldHT8LDXf/VIXUeJEk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711712557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3qUOLbKUc3dR30I/aYkK97hM1XTlgQJ/HEd4XzPvIxo=; b=Ty7b1dXfWRwKArtQeAeD+aTRc5qPpiigrlwINsd0AIKEkKBAnlBIk0PXpMDaQa6XIQqiNC 5m2/A6FfFYvnnPgc8o/sg/gQwuf+WDgEkz8acpBJK7+w2owebZ0jbl15aXF0Ux5rvheM53 odxdN6eNEYk2zrL32j41UZTX1PZeNo4= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-cjWzG0upPgqj2K5CdMicyQ-1; Fri, 29 Mar 2024 07:42:36 -0400 X-MC-Unique: cjWzG0upPgqj2K5CdMicyQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a4dfdbdaf06so103076966b.3 for ; Fri, 29 Mar 2024 04:42:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711712554; x=1712317354; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3qUOLbKUc3dR30I/aYkK97hM1XTlgQJ/HEd4XzPvIxo=; b=RabyVno9/jLqHLLxvK2OZmiPR4T7lL8NI0am5NFuPAnJM7nGhyWFbcBVsdPkhDSg4a Ew2Q1TYFyGymnSbAKo2RNQfo/FDicdxFa53V8bLqYOSoPhhZk5TxSief2x9qk3sAgqhX dAKlx0PFGVdXZbhM+UT+shrsfHnzSrUWy36SBGcutG0EEJXG88r1Cw+XHh8z1ntcKfvz YgDYWD9/GyPNHakeRgV3lpbMHrRZbyFuO2g1frCvLMw/vmubhzq1ZgDtJZLq1YTnmUjx ujmCgg1M/lVh90SMb9BmHe0MwlxyqdhaeTbZTC+TXoer4Ky+Q2qHOjM96rbMI091MP1I sPfA== X-Gm-Message-State: AOJu0YwHgAl4lXV/G7W7m8OKldNmUC646i8yuUzz8YFD4zlun8cE9jYZ YoWHIq+7ehnCaTyPIEgIVUsMAaJGwEZdgTzSitdnnk97Ql49PtCea+nwBwaW3UtKY9cR5nCtFlh 9f3eTT5634AsLlZE6Syz3JiB+SDhgGi13NgscMzXf2w4Q2oTJEVFaVMHgfiNriN3eOQOz4hlYiy /1GgP5fgJ5GZtqphtNT+QKrVKCGcekXMDNssz9742jSqw= X-Received: by 2002:a17:906:4087:b0:a47:3503:cf43 with SMTP id u7-20020a170906408700b00a473503cf43mr1400464ejj.35.1711712554526; Fri, 29 Mar 2024 04:42:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyxAexHwxVGe0jKzeHmywhQO2/Rg/W0v+ufbs45o1oiWA6cEQyX+6vBTKAr/bhLRi839TGEg== X-Received: by 2002:a17:906:4087:b0:a47:3503:cf43 with SMTP id u7-20020a170906408700b00a473503cf43mr1400450ejj.35.1711712553904; Fri, 29 Mar 2024 04:42:33 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id i24-20020a1709063c5800b00a4a3600d2absm1861998ejg.172.2024.03.29.04.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 04:42:33 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/6] Further filename completion improvements Date: Fri, 29 Mar 2024 11:42:26 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This series continues my efforts to improve filename completion. After this series I believe GDB will be ready to add filename options (to the option sub-system), though I haven't done that in this series, I want to see if there are any objections to the direction I'm going in. But even without the filename options, this series adds some nice improvements: GDB's filename completion (both TAB and 'complete' command) now handles escaped whitespace and quotes correctly, and the 'complete' command now correctly displays filenames that require escaping, and better handles the trailing quote when a 'complete' command returns a directory. --- Andrew Burgess (6): gdb: improve escaping when completing filenames gdb: move display of completion results into completion_result class gdb: simplify completion_result::print_matches gdb: add match formatter mechanism for 'complete' command output gdb: apply escaping to filenames in 'complete' results gdb: improve gdb_rl_find_completion_word for quoted words gdb/cli/cli-cmds.c | 26 +- gdb/completer.c | 389 +++++++++++++++--- gdb/completer.h | 47 ++- .../gdb.base/filename-completion.exp | 118 +++++- 4 files changed, 494 insertions(+), 86 deletions(-) base-commit: 56f703d39d6f4793ba73b2364a4ea052e8ad755d -- 2.25.4