From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by sourceware.org (Postfix) with ESMTPS id 704FB385840D for ; Tue, 9 Apr 2024 07:48:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 704FB385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 704FB385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712648935; cv=none; b=CsXZTgA2TcKmAsj+hQPgmdFgDEgUmAeS55AKsHA4DQMrbu2u6n4btDj7lg/D16n7E0rYpZ9BTGftkCHbLItPG+ZWoVyCL4T/YpSOXJNxJZOly8EoHBqZg8I3E+HbD07oeR/QAz1f+Jx3h+mKD9EmRg7xAfPAlcz28ZyPbHv1YnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712648935; c=relaxed/simple; bh=frBYHAv7PwfgVD2YEn7JP7FoTk6htUykd/ne4J/vbU8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=EpXEWUXvR1LcLi8RTyinF80PohbDwq7ISM7649L7aMK6QxA+80daUnW0Eam1mbWVmTaMrU28puIAjgjhGn4+a+YUuZWtINEEYhzTmvxYbRBn5QzNkcSFaK+8mBBzYHJpl5oBsiGiihFJyDxVNlczW0HBikvIeUNAimf8dpIwoms= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712648930; x=1744184930; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=frBYHAv7PwfgVD2YEn7JP7FoTk6htUykd/ne4J/vbU8=; b=Lj/s08vyevzRL5MCUclofm/LaZ6wCe9BeK8Mj4CK9kaxOoe1ZJOdY/mX Iko55zEWD/1gzxFUXcxE+CNdDO1ROrm2QLwbX6qwCkobpc1UhiA6C4S2Q KvhPmKDM5AS3mP9PmOu0mkVMrwwIPYoqjUcy9subSOQi4gUoRcpusoK5e ZgRdTtwqVc+U+xzbMW0ghnSCRFrXffBArhP8d1PjDWn5EbZsa1WmHpHWy jun0UG3pWIe0s0tppuabFgiosF6p8b49h13KsH3MnET5rZG9eDXCVsW8q ZR+VtFMK5WsXshu24Z0qnpoHKRAdFZAFZfnSgfp38a/1LNg7Se5nzYUoG w==; X-CSE-ConnectionGUID: +9OmM5OZRNOWNClyhtbFWw== X-CSE-MsgGUID: UsvAvJiCQlOwk18V78e1nw== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="18517493" X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="18517493" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 00:48:49 -0700 X-CSE-ConnectionGUID: YccGwIpYTd+cNxYtLbOAOw== X-CSE-MsgGUID: C9yvXy6FScOcvIyWbQb8DQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="20261702" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 00:48:47 -0700 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Cc: tom@tromey.com, aburgess@redhat.com Subject: [PATCH v3 0/3] Introduce the 'x' RSP packet Date: Tue, 9 Apr 2024 09:48:08 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, This series introduces the 'x' packet to fetch data from the memory of a remote target in binary format to reduce the transfer overhead. Please see the last patch for time measurements in three sample cases. V1 is available at https://sourceware.org/pipermail/gdb-patches/2024-March/207235.html V2 is available at https://sourceware.org/pipermail/gdb-patches/2024-March/207270.html It made the following updates: * Fine-tune the documentation of the 'm' packet to address Eli's and Tom's comments. * Update the "binary data" section in the documentation to note that 'E' should be escaped. * Remove "(e.g. shared library files)" from a comment message to not create confusion. * Add time measurement of the gcore command for a case before and after applying the patch. * Update the NEWS entry to include the arguments of the 'x' packet. * Update the documentation of the 'x' packet in a similar way to the 'm' packet done in the first bullet. * Remove a DIAGNOSTIC usage for a switch statement. Add a default case instead. * Add handling of the 'x' packet case in the `look_up_one_symbol` function. This version (v3) makes the following updates: * Define the success reply to the 'x' packet to start with a 'b' marker, so that the 'E' byte in binary data does not need to be escaped. * Use probing to check for the 'x' packet support instead using 'qSupported'. A remaining open is to document what happens if a 0-length access is requested in an 'x' packet. Whether this should be a success or failure will be specified based on the discussion of another email thread. Regards Baris Tankut Baris Aktemur (3): doc: fine-tune the documentation of the 'm' RSP packet gdbserver: allow suppressing the next putpkt remote-debug log gdb, gdbserver: introduce the 'x' RSP packet for binary memory read gdb/NEWS | 6 +++ gdb/doc/gdb.texinfo | 40 ++++++++++++--- gdb/remote.c | 86 ++++++++++++++++++++++++++------ gdbserver/debug.cc | 10 ++++ gdbserver/debug.h | 10 ++++ gdbserver/remote-utils.cc | 101 +++++++++++++++++++++++++++++++++----- gdbserver/remote-utils.h | 2 + gdbserver/server.cc | 29 +++++++++++ 8 files changed, 252 insertions(+), 32 deletions(-) -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928