public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>,
	Lancelot SIX <lsix@lancelotsix.com>, Eli Zaretskii <eliz@gnu.org>
Subject: [PATCHv2 0/8] Further filename completion improvements
Date: Sat, 20 Apr 2024 10:10:00 +0100	[thread overview]
Message-ID: <cover.1713603415.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1711712401.git.aburgess@redhat.com>

In V2:

  - Patches #1 and #2 are new in this iteration.  Patches #3 to #8 are
    the patches from V1 rebased onto these two new patches,

  - Patch #1 adds documentation for the formatting of filename
    arguments, this tries to explain the two diffent ways that GDB
    expects filename arguments to be formatted.

  - Patch #2 addresses the problem that Lancelot pointed out: some
    commands don't expect filename arguments to be quoted, or to
    contain escapes.  In this patch I split the filename completion in
    two so the two different filename argument formats are handled
    separately...

  - This clears the way for the rest of the series, which updates how
    completion works for those filename arguments that do accept
    quoting and escaping,

  - Patches #3 to #8 are in principle the same as in V1, but there
    were some changes after rebasing onto the new patch #2.

---

Andrew Burgess (8):
  gdb/doc: document how filename arguments are formatted
  gdb: split apart two different types of filename completion
  gdb: improve escaping when completing filenames
  gdb: move display of completion results into completion_result class
  gdb: simplify completion_result::print_matches
  gdb: add match formatter mechanism for 'complete' command output
  gdb: apply escaping to filenames in 'complete' results
  gdb: improve gdb_rl_find_completion_word for quoted words

 gdb/auto-load.c                               |   4 +-
 gdb/breakpoint.c                              |   5 +-
 gdb/cli/cli-cmds.c                            |  34 +-
 gdb/cli/cli-decode.c                          |  12 +-
 gdb/cli/cli-dump.c                            |   6 +-
 gdb/compile/compile.c                         |   3 +-
 gdb/completer.c                               | 501 +++++++++++++++---
 gdb/completer.h                               |  79 ++-
 gdb/corefile.c                                |   4 +-
 gdb/corelow.c                                 |   4 +-
 gdb/doc/gdb.texinfo                           |  66 +++
 gdb/dwarf2/index-write.c                      |   3 +-
 gdb/exec.c                                    |   7 +-
 gdb/guile/scm-cmd.c                           |   2 +-
 gdb/infcmd.c                                  |  15 +-
 gdb/inferior.c                                |   2 +-
 gdb/jit.c                                     |   2 +-
 gdb/python/py-cmd.c                           |   2 +-
 gdb/record-full.c                             |   5 +-
 gdb/record.c                                  |   2 +-
 gdb/skip.c                                    |   2 +-
 gdb/source.c                                  |   3 +-
 gdb/symfile.c                                 |   7 +-
 gdb/target-descriptions.c                     |   7 +-
 gdb/target.c                                  |   4 +-
 gdb/target.h                                  |   9 +-
 .../gdb.base/filename-completion.exp          | 257 +++++++--
 gdb/tracectf.c                                |   3 +-
 gdb/tracefile-tfile.c                         |   4 +-
 29 files changed, 857 insertions(+), 197 deletions(-)


base-commit: 7a59cf956369336eb9346196a85976e4042019f5
-- 
2.25.4


  parent reply	other threads:[~2024-04-20  9:10 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 11:42 [PATCH 0/6] " Andrew Burgess
2024-03-29 11:42 ` [PATCH 1/6] gdb: improve escaping when completing filenames Andrew Burgess
2024-03-30 23:48   ` Lancelot SIX
2024-03-29 11:42 ` [PATCH 2/6] gdb: move display of completion results into completion_result class Andrew Burgess
2024-03-29 12:14   ` Eli Zaretskii
2024-03-30 23:30     ` Lancelot SIX
2024-03-31  5:49       ` Eli Zaretskii
2024-04-12 17:24         ` Andrew Burgess
2024-04-12 18:42           ` Eli Zaretskii
2024-04-12 22:20             ` Andrew Burgess
2024-04-13  6:36               ` Eli Zaretskii
2024-04-13  9:09                 ` Andrew Burgess
2024-04-13  9:46                   ` Eli Zaretskii
2024-04-12 17:31       ` Andrew Burgess
2024-03-29 11:42 ` [PATCH 3/6] gdb: simplify completion_result::print_matches Andrew Burgess
2024-03-30 23:48   ` Lancelot SIX
2024-03-29 11:42 ` [PATCH 4/6] gdb: add match formatter mechanism for 'complete' command output Andrew Burgess
2024-03-30 23:49   ` Lancelot SIX
2024-03-31  5:55     ` Eli Zaretskii
2024-04-12 17:42       ` Andrew Burgess
2024-04-12 18:44         ` Eli Zaretskii
2024-04-12 22:29           ` Andrew Burgess
2024-04-13  6:39             ` Eli Zaretskii
2024-03-29 11:42 ` [PATCH 5/6] gdb: apply escaping to filenames in 'complete' results Andrew Burgess
2024-03-29 11:42 ` [PATCH 6/6] gdb: improve gdb_rl_find_completion_word for quoted words Andrew Burgess
2024-04-20  9:10 ` Andrew Burgess [this message]
2024-04-20  9:10   ` [PATCHv2 1/8] gdb/doc: document how filename arguments are formatted Andrew Burgess
2024-04-20  9:44     ` Eli Zaretskii
2024-04-27 10:01       ` Andrew Burgess
2024-04-27 10:06         ` Eli Zaretskii
2024-04-29  9:10           ` Andrew Burgess
2024-04-20  9:10   ` [PATCHv2 2/8] gdb: split apart two different types of filename completion Andrew Burgess
2024-04-20  9:10   ` [PATCHv2 3/8] gdb: improve escaping when completing filenames Andrew Burgess
2024-04-20  9:10   ` [PATCHv2 4/8] gdb: move display of completion results into completion_result class Andrew Burgess
2024-04-20  9:10   ` [PATCHv2 5/8] gdb: simplify completion_result::print_matches Andrew Burgess
2024-04-20  9:10   ` [PATCHv2 6/8] gdb: add match formatter mechanism for 'complete' command output Andrew Burgess
2024-04-20  9:10   ` [PATCHv2 7/8] gdb: apply escaping to filenames in 'complete' results Andrew Burgess
2024-04-20  9:10   ` [PATCHv2 8/8] gdb: improve gdb_rl_find_completion_word for quoted words Andrew Burgess
2024-06-05 13:36   ` [PATCHv3 0/7] Further filename completion improvements Andrew Burgess
2024-06-05 13:36     ` [PATCHv3 1/7] gdb: split apart two different types of filename completion Andrew Burgess
2024-06-06 16:18       ` Tom Tromey
2024-06-05 13:36     ` [PATCHv3 2/7] gdb: improve escaping when completing filenames Andrew Burgess
2024-06-05 13:36     ` [PATCHv3 3/7] gdb: move display of completion results into completion_result class Andrew Burgess
2024-06-06 16:19       ` Tom Tromey
2024-06-05 13:36     ` [PATCHv3 4/7] gdb: simplify completion_result::print_matches Andrew Burgess
2024-06-05 13:36     ` [PATCHv3 5/7] gdb: add match formatter mechanism for 'complete' command output Andrew Burgess
2024-06-06 16:14       ` Tom Tromey
2024-06-05 13:36     ` [PATCHv3 6/7] gdb: apply escaping to filenames in 'complete' results Andrew Burgess
2024-06-05 13:36     ` [PATCHv3 7/7] gdb: improve gdb_rl_find_completion_word for quoted words Andrew Burgess
2024-06-06 16:24     ` [PATCHv3 0/7] Further filename completion improvements Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1713603415.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).