From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by sourceware.org (Postfix) with ESMTPS id 001803858D33 for ; Tue, 14 Mar 2023 17:12:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 001803858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf31.google.com with SMTP id g9so12147535qvt.8 for ; Tue, 14 Mar 2023 10:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678813941; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=qrQXRFM5hsn/2kUO3z/GXkPn6DqaqbU61TS2dbSJDBg=; b=IKt2QfVuNJYoUxQUYr0cSBx6MGinIdj7ry69pANYB7y6BRjDVnBTgcGRw2pRbPNYz5 P2/7rKjwiyJVOTCwNCybaaaaVNVESqIFMA6O6VIJxtHR8vzuJvr/+tpd+GzS/G1G9vEU 4nWjtqOryOOr28UE6z7uPP1pUd8mv/BAzRnmNsJiWX3l1UxogozxtA4B3+ilGLCOOZHj 1eyIUmJ8zzhq58b9tWGhH4wKQ+C2utj0drxN06F9aCK396QyD+QJ2DhyLvTttaSjNth2 Uic0O/ZUJHa/SMiP/8mRc1+8cCLDFwHdGDhaLDIhSnV/9q9lzTLatgxEBa0TFlw62SCb JErQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678813941; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qrQXRFM5hsn/2kUO3z/GXkPn6DqaqbU61TS2dbSJDBg=; b=3tpftD+k4842mR3+mHMPyeI2r7xsdvp2aQSdu2I/xGEkOE0lPFNo/iyBUZAOVtGq46 yD8rKsZ8agS/dIVHfyekWkCje+vvUhPCUcbDycgmGb7KXVjciIHlGTspv8gMHXSHAfTx 5t1CpF37+X979gCyqH4ioUoUZ2ZpCE1mFp7tC4tcFrNxuUsq8uWyQG+xipY1uWfoF/fk dMHCTcuWnNFdigy9obVoZJlqLB+hXKYNWyvpy8z6cSURxtPIiWua+QoBV7I5LMvkCIOp m8cktkPGBVfUfoVAXNQypaLvBqxmIod811wX4KEPgviCOup/kKdT9cocuUsx/dy09YYr St8g== X-Gm-Message-State: AO0yUKWcSL08/qlHFmSi+sJ+HbbWo3mVFGrndYFHHbGZNqt5MAWhH/T4 2AYZQ6R15zdlqMYV/mgliDw= X-Google-Smtp-Source: AK7set/IXd5G2pmB+QPuRD6448kedzI4Cg5956UV7xVEFbgXYlZyMhQZW9SzH/F1fXhEzHGaKViILg== X-Received: by 2002:a05:622a:1815:b0:3b6:3787:679d with SMTP id t21-20020a05622a181500b003b63787679dmr65901077qtc.8.1678813941287; Tue, 14 Mar 2023 10:12:21 -0700 (PDT) Received: from [192.168.1.128] (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id e30-20020a05620a015e00b0073b27323c6dsm2045831qkn.136.2023.03.14.10.12.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 10:12:20 -0700 (PDT) Subject: Re: [PATCH 2/2] gdb/doc: uniformize wording for GMP and MPFR entries To: Eli Zaretskii Cc: gdb-patches@sourceware.org, apinski@marvell.com References: <20230306-doc-require-mpfr-fix-v1-0-8f207504dd3e@gmail.com> <20230306-doc-require-mpfr-fix-v1-2-8f207504dd3e@gmail.com> <83ttysxvp9.fsf@gnu.org> <83y1nzsfgu.fsf@gnu.org> From: Philippe Blain Message-ID: Date: Tue, 14 Mar 2023 13:12:19 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <83y1nzsfgu.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Eli, Le 2023-03-14 à 08:08, Eli Zaretskii a écrit : >> Cc: gdb-patches@sourceware.org, apinski@marvell.com >> From: Philippe Blain >> Date: Mon, 13 Mar 2023 12:45:04 -0400 >> >> Hi Eli, >> >> Le 2023-03-10 à 14:17, Eli Zaretskii a écrit : >>>> Date: Fri, 10 Mar 2023 12:46:57 -0500 >>>> Cc: Andrew Pinski >>>> From: Philippe Blain via Gdb-patches >>>> >>>> Make the wording of the GMP and MPFR entries in the "Requirements for >>>> Building GDB" section of the documentation more uniform by: >>>> >>>> - mentioning the configure script in the GMP entry, as is done in the >>>> MPFR entry >>>> - adding the long name of the MPFR library between parenthesis, as is >>>> done in the GMP entry >>>> - removing the second paragraph of the MPFR entry and moving its content >>>> to the first one, mimicking the wording of the GMP entry >>>> --- >>>> gdb/doc/gdb.texinfo | 13 ++++++------- >>>> 1 file changed, 6 insertions(+), 7 deletions(-) >>> >>> I don't mind the changes, but I also don't mind leaving the original >>> text intact: there's nothing wrong with it per se. >>> >>> Thanks. >>> >>> Reviewed-By: Eli Zaretskii >>> >> >> Thanks for the reviwew. I do not have push access, would you be so >> kind as to push both patches ? > > My preference is to install only the first of these, for the reasons I > explained, but I'm waiting to hear opinions of others, if they differ. OK, thanks. let's wait a bit to see if someone else wants to chime in. I guess I was confused by the fact that 'Approved-by' is used here in a different way than in the Git project, where it is an explicit approval (and Approved-by is not used). Maybe an argument for the second patch is that since the first patch makes the GMP and MPFR neighboring entries, it makes more sense to uniformize the wording between the two entries. At least, this is why I made this change: it looked a bit off when I read the doc after only the first patch. Thanks, Philippe.