From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B5A0A3858D20 for ; Thu, 3 Mar 2022 19:42:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5A0A3858D20 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 223JggSr013707 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 3 Mar 2022 14:42:47 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 223JggSr013707 Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4A5151F0D2; Thu, 3 Mar 2022 14:42:42 -0500 (EST) Message-ID: Date: Thu, 3 Mar 2022 14:42:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCHv3] gdb: make thread_info executing and resumed state more consistent Content-Language: tl To: Andrew Burgess , gdb-patches@sourceware.org Cc: Andrew Burgess References: <0491ec20c3c5f489f625383f756d3853a8e48074.1630353626.git.andrew.burgess@embecosm.com> <20220113183406.3577620-1-aburgess@redhat.com> <87bkywb6u1.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87bkywb6u1.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 3 Mar 2022 19:42:42 +0000 X-Spam-Status: No, score=-3033.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2022 19:42:52 -0000 > Simon, > > Thanks for the feedback, and sorry for not following up sooner. This > got pushed down my list of priorities. > > Given how close we are to the GDB 12 branch point, my current plan is to > wait until shortly after we branch, and then update, retest, and push > this patch. > > That will give us (me) as much time as possible to help resolve any > problems that this introduces. I'm expecting there will be some issues > on the targets I've not tested as much, but hopefully they should be > easy enough to resolve. > > Obviously the above plan can change if people object. This is fine with me. I was reminded of this patch because of some bug a colleague hit, which I recorded here: https://sourceware.org/bugzilla/show_bug.cgi?id=28942 In short, the linux-nat target adds threads in the non-resumed state, and that confuses GDB when a thread hits a breakpoint, that breakpoint has a condition, and that condition contains an inferior function call. GDB ends up trying to resume a thread that it thinks is non-resumed but is actually resumed. Simon