From: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>
To: Michael Eager <eager@eagercon.com>,
Pedro Alves <palves@redhat.com>,
Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Vinod Kathail <vinodk@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
"Nagaraju Mekala" <nmekala@xilinx.com>
Subject: RE: [Patch] Microblaze: Port of Linux gdbserver
Date: Thu, 09 Oct 2014 18:54:00 -0000 [thread overview]
Message-ID: <d0a23ff7601a4dbcab91d5b680bc2e13@BY2FFO11FD017.protection.gbl> (raw)
In-Reply-To: <5436B7D0.9060004@eagercon.com>
-----Original Message-----
From: Michael Eager [mailto:eager@eagercon.com]
Sent: Thursday, October 09, 2014 9:59 PM
To: Ajit Kumar Agarwal; Pedro Alves; Joel Brobecker
Cc: gdb-patches@sourceware.org; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch] Microblaze: Port of Linux gdbserver
On 10/08/14 06:51, Ajit Kumar Agarwal wrote:
> Please find the updated patch with feedback comments incorporated.
>>Please don't top post and please trim email.
To send the patches after incorporating the comments, Is there any other way of sending the patches without top post?
I will make sure that I will trim the mail.
>>Please respond to questions/comments inline. This makes it easier to tell whether all issues have been addressed.
Sure. Please find my comments inlined below.
> Microblaze: Port of Linux gdbserver
>
> This patch is the port of Linux gdbserver.
> Tested with gdb regression testsuite with this patch of
> gdbserver.
>
> gdb/:
> 2014-10-08 Ajit Agarwal <ajitkum@xilinx.com>
>
> * configure.tgt (build_gdbserver): New Definition.
>
> gdb/gdbserver/:
>
> * gdbserver/Makefile.in (microblaze-linux.c): New target.
> * gdbserver/configure.srv (microblaze*-*-linux*): New target.
> * gdbserver/linux-microblaze-low.c: New file.
+#define microblaze_breakpoint_len 4
>>Use CAPS for macros.
The MIPS and the ARM gdbserver code does not use the CAPS for the above macro defined.
+ (*the_target->read_memory) (where, (unsigned char *) &insn, 4);
+
+ if (insn == microblaze_breakpoint)
>>Why use the explicit length rather than the macro you just defined?
>>Why not use sizeof (insn)?
To match up with the MIPS target and ARM target they have not used the macro defined. In the Mips 4 is used and in the ARM target for the THUMB_ARM 2 is used and for the ARM Mode code 4 is used.
Pedro:
> I'd much prefer if we had that patch in the tree before accepting further patches that tweak things around register names, etc. Could you send that (as an independent patch, in a new thread).
>>Please address issues with previous patches before moving on to submit dependent patches.
I have already send the patch related to the above Pedro's comment. I have also send the patch after incorporating the Pedro feedback comments.
Pedro:
> Did this kernel port make it upstream without PTRACE_GETREGSET?
> If there's support for that, can you please switch to using it?
>>Please answer all questions.
Sure. The Kernel code(ptrace.h) for Microblaze doesn't have upstream code without PTRACE_GETREGSET.
Pedro:
> PTRACE_GETREGS is supposed to an old way of doing things...
>>And address all comments.
The Microblaze Kernel code PTRACE_GETREGS is always defined and there is no conditional compilation which is without the PTRACE_GETREGS. So I agree with Pedro comment of not using #ifdef PTRACE_GETREGS and in the patch submitted I have removed if #ifdef PTRACE_GETREGS which is not required.
Pedro:
>diff --git a/gdb/regformats/microblaze-with-stack-protect.dat
...
> Please send a preparatory, independent, patch that updates
> features/Makefile instead and generates this file, in a new thread,
> with self-contained description, following the
> checklist:
> https://sourceware.org/gdb/wiki/ContributionChecklist
>>Preparatory means that the patch should be submitted before the current patch.
I will be sending this patch soon.
Thanks & Regards
Ajit
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2014-10-09 18:54 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 13:52 Ajit Kumar Agarwal
2014-10-09 16:29 ` Michael Eager
2014-10-09 18:54 ` Ajit Kumar Agarwal [this message]
2014-10-09 23:42 ` Michael Eager
2014-10-13 16:00 ` Ajit Kumar Agarwal
2014-10-13 17:49 ` Michael Eager
2014-10-14 3:03 ` Ajit Kumar Agarwal
2014-10-14 15:07 ` Michael Eager
2014-10-14 15:33 ` Ajit Kumar Agarwal
2014-10-14 15:42 ` Ajit Kumar Agarwal
2014-10-15 13:27 ` Pedro Alves
2014-10-17 19:22 ` Ajit Kumar Agarwal
2014-12-15 18:02 ` Pedro Alves
2014-12-15 18:13 ` Michael Eager
2014-12-18 8:58 ` Ajit Kumar Agarwal
2014-12-18 16:10 ` Michael Eager
2014-12-18 8:57 ` Ajit Kumar Agarwal
2014-12-18 11:28 ` Pedro Alves
2014-12-18 16:53 ` Ajit Kumar Agarwal
2014-12-18 17:40 ` Pedro Alves
2014-12-19 8:27 ` Ajit Kumar Agarwal
2014-12-19 10:56 ` Pedro Alves
2014-12-19 10:26 ` Ajit Kumar Agarwal
2014-12-19 11:02 ` Pedro Alves
2014-12-19 18:06 ` Ajit Kumar Agarwal
2014-11-26 12:13 ` Ajit Kumar Agarwal
2014-12-15 16:08 ` Ajit Kumar Agarwal
-- strict thread matches above, loose matches on Subject: below --
2014-10-08 14:59 Ajit Kumar Agarwal
2014-09-10 10:14 [Patch, microblaze]: " Ajit Kumar Agarwal
2014-09-10 13:31 ` Michael Eager
2014-09-10 13:46 ` Joel Brobecker
2014-09-10 14:23 ` Ajit Kumar Agarwal
2014-09-10 14:39 ` Michael Eager
2014-09-10 14:59 ` Ajit Kumar Agarwal
2014-09-10 15:12 ` Ajit Kumar Agarwal
2014-09-10 15:27 ` Michael Eager
2014-09-10 15:30 ` Ajit Kumar Agarwal
2014-09-10 15:35 ` Michael Eager
2014-09-10 15:51 ` Ajit Kumar Agarwal
2014-09-10 14:43 ` Joel Brobecker
2014-09-10 15:04 ` Ajit Kumar Agarwal
2014-09-10 15:54 ` Joel Brobecker
2014-09-10 16:10 ` Ajit Kumar Agarwal
2014-09-12 8:01 ` Ajit Kumar Agarwal
2014-09-12 8:39 ` Ajit Kumar Agarwal
2014-09-12 15:38 ` Michael Eager
2014-09-16 6:42 ` Ajit Kumar Agarwal
2014-09-16 12:06 ` Michael Eager
2014-09-17 9:36 ` Ajit Kumar Agarwal
2014-09-17 14:12 ` Michael Eager
2014-09-16 17:04 ` Pedro Alves
2014-09-17 6:16 ` Ajit Kumar Agarwal
2014-09-17 8:15 ` Pedro Alves
2014-09-17 8:20 ` Ajit Kumar Agarwal
2014-09-23 12:49 ` Ajit Kumar Agarwal
2014-09-30 11:43 ` Pedro Alves
2014-09-30 13:27 ` Ajit Kumar Agarwal
2014-09-30 13:37 ` Pedro Alves
2014-09-30 14:21 ` Ajit Kumar Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0a23ff7601a4dbcab91d5b680bc2e13@BY2FFO11FD017.protection.gbl \
--to=ajit.kumar.agarwal@xilinx.com \
--cc=brobecker@adacore.com \
--cc=eager@eagercon.com \
--cc=gdb-patches@sourceware.org \
--cc=nmekala@xilinx.com \
--cc=palves@redhat.com \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).