From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57547 invoked by alias); 20 Jul 2017 18:12:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57465 invoked by uid 89); 20 Jul 2017 18:12:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Jul 2017 18:12:00 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0DC7A461FE for ; Thu, 20 Jul 2017 18:11:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0DC7A461FE Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0DC7A461FE Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40DAA17AEC; Thu, 20 Jul 2017 18:11:57 +0000 (UTC) Subject: Get rid of "set language local"? (was: Re: [PATCH 23/40] Make language_def O(1)) To: Keith Seitz , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-24-git-send-email-palves@redhat.com> <596D4238.7090905@redhat.com> <5ce823d3-1064-f14b-2e79-2ff9efdb28a0@redhat.com> From: Pedro Alves Message-ID: Date: Thu, 20 Jul 2017 18:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5ce823d3-1064-f14b-2e79-2ff9efdb28a0@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00307.txt.bz2 On 07/20/2017 06:40 PM, Pedro Alves wrote: > On 07/18/2017 12:03 AM, Keith Seitz wrote: >> On 06/02/2017 05:22 AM, Pedro Alves wrote: >> >>> Note that "local_language_defn" is gone along the way. AFAICT, it's >>> just a copy of "auto", so the new code simply maps one to the other. >>> One fewer place to update when we need to change the language >>> vector... >> >> I've searched the manual, and the "local" language is mentioned only in two places, once in the description of "set language" (where it explains that "local" and "auto" are the same) and once when we describe -data-evaluate-expression's --language flag. >> >> Honestly, is there any reason to keep it at all given it is a synonym of auto? [I realize that it doesn't cost much to maintain with this patch.] I'm not asking for any changes in this regard, just throwing the possibility out there. TBH, I didn't even know "local" existed. > > I didn't know about "local" until I stumbled on it working on this > series, either. :-) > > I'll send a follow up reply with a different subject > to see if anyone else has comments on that. Does anyone here ever use "set language local" instead of "set language auto"? Do we need to keep "set language local" ? Seems odd to have two ways to do the exact same thing. Thanks, Pedro Alves