From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 292483858C50 for ; Fri, 4 Aug 2023 00:10:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 292483858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5E704218EB; Fri, 4 Aug 2023 00:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691107814; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DbtolZY3Ov+P9GO095UWgYGMjG7Zj51QwsQ1p1lQK1c=; b=W6INFc8+S6ng5QHk6ZeIIfn7L6KbC5Q/lRcwOgmG1+Fd/vhkUIdCLB7gkRj7+QB64GkV7y xsYg+vIMEMmcUqjSEwuELaXSzFV08PFufb9Rp0NRtyz7qR3dLJ+MypV58ysgt11DqBPxgm oYP24JYxc1yDdlem2AUOgNZ4Z+1Il+g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691107814; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DbtolZY3Ov+P9GO095UWgYGMjG7Zj51QwsQ1p1lQK1c=; b=rasIjrQGphczKzxdaZw2zio0nFE/SxPEyWsy8sEEOElbUIEhWrYJwF/eGJWtWHH52DIrRt 487j7yPzVh35FiDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 49EE9134B0; Fri, 4 Aug 2023 00:10:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PF3vEOZBzGSBLwAAMHmgww (envelope-from ); Fri, 04 Aug 2023 00:10:14 +0000 Message-ID: Date: Fri, 4 Aug 2023 02:09:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] [gdb/symtab] Fix data race on bfd::{cacheable,format} Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230802095305.3668-1-tdevries@suse.de> <20230802095305.3668-3-tdevries@suse.de> <87o7jpdyub.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87o7jpdyub.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/2/23 21:32, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Tom> With gdb build with -fsanitize=thread and test-case gdb.base/index-cache.exp I > Tom> run into: > > Thanks again. > > Tom> -index_cache_store_context::index_cache_store_context (const index_cache &ic) > Tom> +index_cache_store_context::index_cache_store_context (const index_cache &ic, > Tom> + dwarf2_per_bfd *per_bfd) > > Ok, I see why explicit isn't needed :) > In the v3 version, I've added explicit in the first patch, and then remove it in the second ( https://sourceware.org/pipermail/gdb-patches/2023-August/201338.html ). Thanks, - Tom > This seems fine to me. > Approved-By: Tom Tromey > > > Tom