From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id AB60E3858405 for ; Tue, 23 Nov 2021 07:56:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AB60E3858405 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DE7ED2177B; Tue, 23 Nov 2021 07:56:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C435113D1A; Tue, 23 Nov 2021 07:56:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cW1BLqCenGF/awAAMHmgww (envelope-from ); Tue, 23 Nov 2021 07:56:16 +0000 Subject: Re: [PATCH v2 00/32] Rewrite the DWARF "partial" reader To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20211104180907.2360627-1-tom@tromey.com> <4a288a6a-63c4-e36e-da20-01ae3fd0955c@suse.de> <87a6i31woz.fsf@tromey.com> <87mtlwx8p6.fsf@tromey.com> <2e54aac8-8f1a-e9ac-9530-c5770ff9a379@suse.de> <878rxfyh5e.fsf@tromey.com> From: Tom de Vries Message-ID: Date: Tue, 23 Nov 2021 08:56:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <878rxfyh5e.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 07:56:19 -0000 On 11/22/21 11:11 PM, Tom Tromey wrote: > Tom> I tried a two-file test-case: > Tom> ... > Tom> $ cat test.c > Tom> #include "test2.c" > Tom> $ cat test2.c > Tom> int > Tom> main (void) > Tom> { > Tom> return 0; > Tom> } > Tom> $ gcc -g test.c > Tom> ... > Tom> and got the same structure. > > For me, with this test, the compiler doesn't mention test.c at all in > its output, so even the unmodified gdb can't find it. [ I've sent an off-list message to discuss how to reproduce this. ] FWIW, I think this is sufficiently cornercase that it's not worth blocking the trunk commit of the branch. Filing this in bugzilla to deal with later and adding a KFAIL in the test should be sufficient. Thanks, - Tom