From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57657 invoked by alias); 24 Nov 2016 18:41:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57646 invoked by uid 89); 24 Nov 2016 18:41:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=uioutc, UD:ui-out.c, ui-out.c, ui_out_level X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Nov 2016 18:41:48 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 363137DD06; Thu, 24 Nov 2016 18:41:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAOIfjkp009764; Thu, 24 Nov 2016 13:41:46 -0500 Subject: Re: [PATCH 16/22] Class-ify ui_out_level To: Simon Marchi , gdb-patches@sourceware.org References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-16-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: Date: Thu, 24 Nov 2016 18:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161124152710.25007-16-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00777.txt.bz2 On 11/24/2016 03:27 PM, Simon Marchi wrote: > This patch changes struct ui_out_level to be a real C++ class. No > behavioral changes. > > gdb/ChangeLog: > > * ui-out.c (struct ui_out_level): Replace with ... > (class ui_out_level): ... this. > (current_level): Update. > (push_level): Update. > (pop_level): Update. > (verify_field): Update. > (ui_out_new): Update. > --- > gdb/ui-out.c | 65 ++++++++++++++++++++++++++++++++++++++++-------------------- > 1 file changed, 44 insertions(+), 21 deletions(-) > > diff --git a/gdb/ui-out.c b/gdb/ui-out.c > index 410f40c..594338a 100644 > --- a/gdb/ui-out.c > +++ b/gdb/ui-out.c > @@ -90,13 +90,41 @@ class ui_out_hdr > std::string m_header; > }; > > -struct ui_out_level > +/* A level of nesting (either a list or a tuple) in a ui_out output. */ > + > +class ui_out_level > +{ > + public: > + > + ui_out_level (ui_out_type type) explicit ? > + : m_type (type), > + m_field_count (0) > { > - /* Count each field; the first element is for non-list fields. */ > - int field_count; > - /* The type of this level. */ > - enum ui_out_type type; > - }; > + } > + > + ui_out_type type (void) const "(void)" is not necessary in C++ (and not very idiomatic). I saw this in several places in the series. > + { > + return m_type; > + } > + > + int field_count (void) const > + { > + return m_field_count; > + } > + > + void inc_field_count (void) > + { > + m_field_count++; > + } Thanks, Pedro Alves