From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29211 invoked by alias); 29 Nov 2017 12:23:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29197 invoked by uid 89); 29 Nov 2017 12:23:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=obey, Hx-languages-length:963, Youll, You'll X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 12:23:06 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB79980F95; Wed, 29 Nov 2017 12:23:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95C7C5C1AB; Wed, 29 Nov 2017 12:23:01 +0000 (UTC) Subject: Re: [PATCH v2] Add support for the --readnever command-line option (DWARF only) To: Sergio Durigan Junior References: <1467838463-15786-1-git-send-email-brobecker@adacore.com> <87o9ntddb6.fsf_-_@redhat.com> <2cb6d01b-b40b-0a73-2df4-65f4e2094731@redhat.com> <87efoodi79.fsf@redhat.com> <87a7zc9syx.fsf@redhat.com> <874lpj8lta.fsf@redhat.com> <8bd72067-dbb3-4c7f-1934-87df87c6f358@redhat.com> <87y3mplx1d.fsf@redhat.com> Cc: Yao Qi , Joel Brobecker , "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: Date: Wed, 29 Nov 2017 12:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87y3mplx1d.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00766.txt.bz2 On 11/29/2017 12:59 AM, Sergio Durigan Junior wrote: > On Monday, November 27 2017, Pedro Alves wrote: >> It's really not a bit deal, but to me it'd be more >> consistent have all readers do the same logically. > > Understood. I switched the logic and now I'm doing all the work on > elf_symfile_read (and consequently dwarf2_has_info, which now is the > right place to put the checks on). > > I wasn't sure if I should modify other *_symfile_read functions to obey > the setting, so I left them alone. Surely you should? You'll need to modify coffread.c and xcoffread.c accordingly. In the earlier iteration you were changing coffstab_build_psymtabs, for example. Basically you're moving checks to the callers instead, so you should end up with roughly the same number of checks as before, not fewer. At least logically. They'll just be in different places. Thanks, Pedro Alves