From: Simon Marchi <simark@simark.ca>
To: John Darrington <john@darrington.wattle.id.au>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] GDB: New target s12z
Date: Sun, 26 Aug 2018 22:55:00 -0000 [thread overview]
Message-ID: <d1239d21-b95b-3cb7-3147-b5253dd29d22@simark.ca> (raw)
In-Reply-To: <510acbee-2338-0c20-8e32-8d6ef83be3e1@simark.ca>
On 2018-08-26 2:15 p.m., Simon Marchi wrote:
> On 2018-08-26 1:41 p.m., John Darrington wrote:
>> Hi Simon,
>>
>> Thanks for the review.
>>
>> On Sun, Aug 26, 2018 at 01:19:29PM -0400, Simon Marchi wrote:
>> Hi John,
>>
>> I did a first pass review and noted a few minor nits. I didn't get too deep in the
>> frame_id/unwind code because I'm not too familiar with that.
>>
>> Pity. I was hoping someone could help me there :{P
>
> I just haven't written enough of those to be able to spot bugs off-hand in them.
>
> Maybe just one insight, it seems (I'm not sure) that s12z_frame_cache uses the SP value of the
> current frame (the one for which we compute the id) in the frame id.
>
> The usual thing to do (I looked at a few other arches) is to use the same value as the
> canonical frame address as defined by DWARF (Section 6.4 in DWARF5.pdf), which is the
> value of the stack pointer just before that frame was created.
>
> This is of course not mandatory, but I suppose that adhering to this de facto rule could
> make things clearer.
>
>> Many of your comments and questions stem from the code which I used as a
>> pattern, so I'm unsure of the answers. But I will find out as best I
>> can and prepare a new patch within the next few days.
>>
>> J'
>
> Thanks,
>
> Simon
I also noticed that the gdb.base/all-architectures test fails when testing s12z. Try to run
make check TESTS="gdb.base/all-architectures-*.exp"
in the gdb build directory, see if you get a bunch of:
FAIL: gdb.base/all-architectures-6.exp: tests: osabi=AIX: arch=s12z: endian=auto: disassemble 0x0,+4 (GDB internal error)
Simon
next prev parent reply other threads:[~2018-08-26 22:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 17:35 [PATCH 1/3] gdb: Added builtin types for 24 bit integers John Darrington
2018-08-23 17:35 ` [PATCH 2/3] GDB: Add support for 24 bit addresses John Darrington
2018-08-24 20:34 ` Simon Marchi
2018-08-25 4:56 ` John Darrington
2018-08-23 17:35 ` [PATCH 3/3] GDB: New target s12z John Darrington
2018-08-23 17:56 ` Eli Zaretskii
2018-08-26 17:19 ` Simon Marchi
2018-08-26 17:41 ` John Darrington
2018-08-26 18:16 ` Simon Marchi
2018-08-26 22:55 ` Simon Marchi [this message]
2018-08-27 6:30 ` John Darrington
2018-08-27 12:54 ` Simon Marchi
2018-08-28 15:35 ` Tom Tromey
2018-08-23 17:55 ` [PATCH 1/3] gdb: Added builtin types for 24 bit integers Eli Zaretskii
2018-08-23 19:41 ` Simon Marchi
2018-08-23 20:04 ` John Darrington
2018-08-23 20:35 ` Simon Marchi
2018-08-24 6:11 ` John Darrington
2018-08-24 15:09 ` Simon Marchi
2018-08-24 15:29 ` John Darrington
2018-08-24 20:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1239d21-b95b-3cb7-3147-b5253dd29d22@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).