From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79203 invoked by alias); 26 Aug 2018 22:55:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79193 invoked by uid 89); 26 Aug 2018 22:55:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=AIX, aix, Hx-languages-length:1652, Section X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 26 Aug 2018 22:55:34 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5A30E1E52D; Sun, 26 Aug 2018 18:55:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1535324133; bh=ONQWCZ4SjXUOxGUby2Jj6N9Ol4/HDbbK0sp874Fx5Jc=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=snK9tIRfiueajKJ4C8Jc74N2Gf1tQvE1CtfxzdGVy+tMs5QVB8uKYZhffUZ3hyNo7 7TBCnkc3Zbij1keVlmh7vb4RCzE48dMC5YqRcxhVdLUlu1zWhBEqZmPeqn0AaESJHj qzr0V7O4rm2o+wHtuBt2XizuDJlp2YtSKvZEzUp8= Subject: Re: [PATCH 3/3] GDB: New target s12z From: Simon Marchi To: John Darrington Cc: gdb-patches@sourceware.org References: <20180823173526.26144-1-john@darrington.wattle.id.au> <20180823173526.26144-3-john@darrington.wattle.id.au> <20180826174127.g2qht4j3tqtpxfmz@jocasta.intra> <510acbee-2338-0c20-8e32-8d6ef83be3e1@simark.ca> Message-ID: Date: Sun, 26 Aug 2018 22:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <510acbee-2338-0c20-8e32-8d6ef83be3e1@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00641.txt.bz2 On 2018-08-26 2:15 p.m., Simon Marchi wrote: > On 2018-08-26 1:41 p.m., John Darrington wrote: >> Hi Simon, >> >> Thanks for the review. >> >> On Sun, Aug 26, 2018 at 01:19:29PM -0400, Simon Marchi wrote: >> Hi John, >> >> I did a first pass review and noted a few minor nits. I didn't get too deep in the >> frame_id/unwind code because I'm not too familiar with that. >> >> Pity. I was hoping someone could help me there :{P > > I just haven't written enough of those to be able to spot bugs off-hand in them. > > Maybe just one insight, it seems (I'm not sure) that s12z_frame_cache uses the SP value of the > current frame (the one for which we compute the id) in the frame id. > > The usual thing to do (I looked at a few other arches) is to use the same value as the > canonical frame address as defined by DWARF (Section 6.4 in DWARF5.pdf), which is the > value of the stack pointer just before that frame was created. > > This is of course not mandatory, but I suppose that adhering to this de facto rule could > make things clearer. > >> Many of your comments and questions stem from the code which I used as a >> pattern, so I'm unsure of the answers. But I will find out as best I >> can and prepare a new patch within the next few days. >> >> J' > > Thanks, > > Simon I also noticed that the gdb.base/all-architectures test fails when testing s12z. Try to run make check TESTS="gdb.base/all-architectures-*.exp" in the gdb build directory, see if you get a bunch of: FAIL: gdb.base/all-architectures-6.exp: tests: osabi=AIX: arch=s12z: endian=auto: disassemble 0x0,+4 (GDB internal error) Simon