From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 938AF3858C3A for ; Mon, 14 Aug 2023 20:34:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 938AF3858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RPmNX0pDGz4L7j; Mon, 14 Aug 2023 20:34:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RPmNW6hqhz4RQp; Mon, 14 Aug 2023 20:34:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692045291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3ScRpekYP+oLbSENx+XlrChJlO3laHNJOZdsYIuiYNc=; b=jSj5i9qit+VKfIPTpCx4eocluzS6FFZpC0LLPQr3990vh1BQtW45/++DImjDEkmxNfFujk gWBR9BvMJo+5tE0XrSgh+L81lRaOJkmOGn2ApzVreBGE+34xiqg4EHX4MAq5TVgSKA/5dx 4xShCMklgtpylzzRwvnlG/LMtH9b3zLoqNrIXtKrpKYg60CtZcgvcjZgs9+Adh7otp3Pgn OHwx6WuGQqoXFuK/a+gOmaUF/ytCheApcRiVL1oj9vlac6ILpTuxi1qIkKFUpYisRd01VG o+cQV5X+69IKi/n2HbtnP5qS9i8BOdfQDztIEdGUCGokgbVm7kICruVwPH+zTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692045291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3ScRpekYP+oLbSENx+XlrChJlO3laHNJOZdsYIuiYNc=; b=Vjxm7ZBrXySTGpKNMhc/nu1j+mc1TApmRKW7jPoPzXklOK+bxRZIrrD2KL67ul3ka8Dgvo Pbe7fvm40KDDVskvLL0l6zrG6USKqfMxuD3DM/lC9OZ8k2UQ0+UzAjXVMu+DzCqKssrP4X dp1o7jcnfw4PJg1o3/Ub1p7NXJ3RnBciZT4bzLfldIuQp1giZEgKT0WCeFP8aZD02creIH nuJAP/YBuGelvebwCYt0KPMAlGL9iQmNFivedxwWy0O4WPCgUS9v9o/oG88EVGZNTAEuSN Xb1iCy8mQvRBZMnwx9Ey6/I3H0kPsWLoXpAAvgXD0p0YmfdJjXx03qQdcRomXQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692045291; a=rsa-sha256; cv=none; b=wPUtA9qHgPvpu79RBxWZ/gwm7zDRwCBFkcsOI0woBtRyHRIadMUoi7Oc2pytdZxCy+ttWd G0ddMRE89OqkZJUn7tOFgzFYaQvhUtgg+LPbvn1rrnDyslIVRopp3igxjMLMHckgl1jgRC zdhTaDos+fU30/c3VV7F9ctT9QC5v5T7E8HrRgDRvA2rJwFGRxD5ss4u+GM1aqQRqx66Sx AkgkCyu02Bkn8BXtfGzywi4rb6del1Dkmypq7n0z+ytytb4JUM1po9DD0SA98DPZD4yJu2 jKUd20D8DX2XVbOD5Ac7C8w4ue41mwAeNWUozGaA5OlHpV1iz/eFrr8Bk3jeww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:648:8683:a9e0:245c:e6ba:2131:1b31] (unknown [IPv6:2601:648:8683:a9e0:245c:e6ba:2131:1b31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RPmNW3s3Xz2Px; Mon, 14 Aug 2023 20:34:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 14 Aug 2023 13:34:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] Mention process_stratum in inferior::priv comment Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230814180733.2158338-1-tromey@adacore.com> From: John Baldwin In-Reply-To: <20230814180733.2158338-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/14/23 11:07 AM, Tom Tromey via Gdb-patches wrote: > From what I can tell, inferior::priv is reserved for the > process_stratum target. It seems to me that it has to be, because > currenlty only such targets use it, and if a target at another stratum > started using this field, then conflicts could occur. This patch > documents this. > --- > gdb/inferior.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/inferior.h b/gdb/inferior.h > index 712f9b3f330..8f300a5bcc5 100644 > --- a/gdb/inferior.h > +++ b/gdb/inferior.h > @@ -633,7 +633,7 @@ class inferior : public refcounted_object, > attach or handling a fork child. */ > bool in_initial_library_scan = false; > > - /* Private data used by the target vector implementation. */ > + /* Private data used by the process_stratum target. */ > std::unique_ptr priv; > > /* HAS_EXIT_CODE is true if the inferior exited with an exit code. Reviewed-by: John Baldwin The only two current users are darwin-nat and remote (and I'm about to add one in fbsd-nat) -- John Baldwin