From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id D4F2B3858D20 for ; Fri, 2 Dec 2022 07:59:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4F2B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1E4D421BDC; Fri, 2 Dec 2022 07:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669967943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rnOIlj2vJ3oxnos1nAiFsVs04oAunyklqJwybTW1p10=; b=JVuxyux4pX4W9al8nElplnWdU4HmcnT+RjK6XRddPN4mO5FDFqetXr3cEVq+A2PXUOHMB5 ulm7uxL25KZ+xKk6Jyj3ygAsWHl6Dj3cEwnkzEl/xlKH1ZejyCPfQBRqMY2Re3ZZvV2ze6 hmYLc0Dk5YhBawCmVq+COjVEC+YIjsg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669967943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rnOIlj2vJ3oxnos1nAiFsVs04oAunyklqJwybTW1p10=; b=yx0mBpJKqErRmHHP7tW+jYvy41/nN7It1yPOxCYkBqzK+FjrvX2to/gU1fQtkRdQQxLAv6 pY80y8miwvgY7XCw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id F2C5913644; Fri, 2 Dec 2022 07:59:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id Vb3rOUawiWPPFgAAGKfGzw (envelope-from ); Fri, 02 Dec 2022 07:59:02 +0000 Message-ID: Date: Fri, 2 Dec 2022 08:59:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.ada/float-bits.exp for powerpc64le Content-Language: en-US To: Luis Machado , gdb-patches@sourceware.org Cc: Carl Love , Ulrich Weigand References: <20221130140006.25890-1-tdevries@suse.de> <0839ffa1-e99b-a6a5-ac01-d8e3fb5fdf1b@arm.com> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/1/22 22:01, Luis Machado wrote: > On 12/1/22 20:51, Luis Machado wrote: >> On 12/1/22 14:40, Tom de Vries wrote: >>> On 12/1/22 14:49, Luis Machado wrote: >>>> This change seems to be causing a timeout on aarch64-linux Ubuntu >>>> 22.04. >>>> >>>> FAIL: gdb.ada/float-bits.exp: maint print architecture (timeout) >>>> >>>> # of expected passes            12 >>>> # of unexpected failures        1 >>>> >>>> It is as if the listing of the architecture fields didn't have time >>>> to finish. >>>> >>> >>> Can you see if this fixes things? >>> >>> Thanks, >>> - Tom >> >> I checked the patch and it doesn't seem to help. It still times out. >> >> I briefly investigated this and it looks like a (gdb) prompt gets >> output when it shouldn't. >> >> gdbarch_dump: read_core_file_mappings = <0xaaaac98fb7f0> >> (gdb) aarch64_dump_tdep: Lowest pc = 0x0x8000 > hitting enter gives another prompt below) >> (gdb) >> >> This doesn't seem to be related to your patch, but something else. > > Ah, the tdep dumper for aarch64 is missing a "\n"! So the prompt seems > to be output in the beginning of the same line. > > Odd, and slightly fragile. > > In any case, this is easily fixed with the \n addition. I'll push an > obvious change for that. > > Sorry for the noise. No problem :) Now that I've done the work anyway, I've pushed the line-by-line reading patch with an updated commit message ( https://sourceware.org/pipermail/gdb-patches/2022-December/194408.html ). Thanks, - Tom