From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id B4E893858C2C for ; Thu, 30 Sep 2021 21:47:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B4E893858C2C Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F0C45224D6; Thu, 30 Sep 2021 21:47:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D7F0513B5C; Thu, 30 Sep 2021 21:47:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mQ+JM2AwVmG9UAAAMHmgww (envelope-from ); Thu, 30 Sep 2021 21:47:12 +0000 Subject: Re: [committed][gdb/testsuite] Disable vgdb tests if xml not supported From: Tom de Vries To: Tom Tromey , Tom de Vries via Gdb-patches References: <20210929135520.GA16103@delia> <87pmsq0y4m.fsf@tromey.com> Message-ID: Date: Thu, 30 Sep 2021 23:47:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------0127BD0748F055C3F80151E5" Content-Language: en-US X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 21:47:15 -0000 This is a multi-part message in MIME format. --------------0127BD0748F055C3F80151E5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 9/30/21 11:41 PM, Tom de Vries wrote: > On 9/30/21 7:30 PM, Tom Tromey wrote: >> Tom> +if { [gdb_skip_xml_test] } { >> Tom> + # Valgrind gdbserver requires gdb with xml support. >> Tom> + return 0 >> Tom> +} >> >> Do we want/need an 'untested' in there? >> > > Ack, will do. > Pushed this patch. Thanks, - Tom --------------0127BD0748F055C3F80151E5 Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Add-untested-for-missing-xml-support-in-gdb.base-valgrind-.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-gdb-testsuite-Add-untested-for-missing-xml-support-in-g"; filename*1="db.base-valgrind-.exp.patch" [gdb/testsuite] Add untested for missing xml support in gdb.base/valgrind*.exp Add untested in case missing xml support is detected in test-cases gdb.base/valgrind*.exp. Tested on x86_64-linux. --- gdb/testsuite/gdb.base/valgrind-bt.exp | 1 + gdb/testsuite/gdb.base/valgrind-disp-step.exp | 1 + gdb/testsuite/gdb.base/valgrind-infcall-2.exp | 1 + gdb/testsuite/gdb.base/valgrind-infcall.exp | 1 + 4 files changed, 4 insertions(+) diff --git a/gdb/testsuite/gdb.base/valgrind-bt.exp b/gdb/testsuite/gdb.base/valgrind-bt.exp index 4b84a45d333..440c6e403e9 100644 --- a/gdb/testsuite/gdb.base/valgrind-bt.exp +++ b/gdb/testsuite/gdb.base/valgrind-bt.exp @@ -15,6 +15,7 @@ if { [gdb_skip_xml_test] } { # Valgrind gdbserver requires gdb with xml support. + untested "missing xml support" return 0 } diff --git a/gdb/testsuite/gdb.base/valgrind-disp-step.exp b/gdb/testsuite/gdb.base/valgrind-disp-step.exp index f9429fbd69a..88ac848ae2d 100644 --- a/gdb/testsuite/gdb.base/valgrind-disp-step.exp +++ b/gdb/testsuite/gdb.base/valgrind-disp-step.exp @@ -20,6 +20,7 @@ if { [gdb_skip_xml_test] } { # Valgrind gdbserver requires gdb with xml support. + untested "missing xml support" return 0 } diff --git a/gdb/testsuite/gdb.base/valgrind-infcall-2.exp b/gdb/testsuite/gdb.base/valgrind-infcall-2.exp index 30881ca72ea..a368717c1e8 100644 --- a/gdb/testsuite/gdb.base/valgrind-infcall-2.exp +++ b/gdb/testsuite/gdb.base/valgrind-infcall-2.exp @@ -31,6 +31,7 @@ if { [gdb_skip_xml_test] } { # Valgrind gdbserver requires gdb with xml support. + untested "missing xml support" return 0 } diff --git a/gdb/testsuite/gdb.base/valgrind-infcall.exp b/gdb/testsuite/gdb.base/valgrind-infcall.exp index 0108f92ceaf..9f49a320f52 100644 --- a/gdb/testsuite/gdb.base/valgrind-infcall.exp +++ b/gdb/testsuite/gdb.base/valgrind-infcall.exp @@ -15,6 +15,7 @@ if { [gdb_skip_xml_test] } { # Valgrind gdbserver requires gdb with xml support. + untested "missing xml support" return 0 } --------------0127BD0748F055C3F80151E5--