From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2085.outbound.protection.outlook.com [40.107.102.85]) by sourceware.org (Postfix) with ESMTPS id A07413858406 for ; Wed, 12 Jan 2022 18:43:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A07413858406 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l6j4HZiYcjliuBMl+hkorHcoW6LJZuRS2lXcbtf0Y8mYLMsyuGfN9ROEPa7SfDNRb66FXJ9P86LM1w7C55A6YA4KkAm4CZXvouyngcG070/bViq1VRLQUHu1ACdmx8uhCOD4eM+dMN2FhfOGpAmTcm7fexdQX+dyO+c1Lz9pVDabJ6RrgtBdIR1BV+VvmWpnTUr+sRzzzhbaqKtHn+7sDc6sXqTstGdvJlRC+q09AOu0Wg9ZZQZA77vXtcprZsN1ODcvt+34UKtC6St3k8Kj4hwhxiEgqjh0294vGfcEUO2wSvLsCGKFzG7/+uo0jpqyB8AXwDqHdfX+o7b80T7yjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aVvi9q4P4UGVUzp6a02H9A52GDZQTpm0sEmuc4O1o5E=; b=gWZhU/5e74EX5WwymbJcDEFXNQPQrG0At8MiTOn8/CZ9FW3cPTDepHPo/vjAn3ZtZOkEagEqykACib5OhuT8jm05IhMJxc0IyxC06i2vZUB3BEXsdG4xJiw6iWJIvrzlazo9fnKUmGnQSMOTRpGtrB/bIvBxJQSJljMGcWse/Y5CJjupM/jkBXoJJup8TqxciXBm31YfQlptWrekJuVqhOT/5X6gQIkTPW4/tiTCpyNbHJcA1kEpQofBqbiflQq9kEXbWgot2Isz4NvduY0aEQiRJ5/pEvanO8EipI6zBSJ6iqUeMZWH41RVqscWzH1uls7NS8iqk3KArwAUxwagzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) by BN9PR12MB5367.namprd12.prod.outlook.com (2603:10b6:408:104::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Wed, 12 Jan 2022 18:43:03 +0000 Received: from BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::8a:f482:ebd8:3135]) by BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::8a:f482:ebd8:3135%5]) with mapi id 15.20.4867.011; Wed, 12 Jan 2022 18:43:03 +0000 Subject: Re: [PATCH v4 05/28] Add to_value method to dwarf_location class To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20211105113849.118800-1-zoran.zaric@amd.com> <20211105113849.118800-6-zoran.zaric@amd.com> <87pmpyyiny.fsf@tromey.com> <7f652c5a-ca89-3f37-a3c1-7c86d7a41006@amd.com> From: Zoran Zaric Message-ID: Date: Wed, 12 Jan 2022 18:42:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <7f652c5a-ca89-3f37-a3c1-7c86d7a41006@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0701CA0007.eurprd07.prod.outlook.com (2603:10a6:203:51::17) To BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0413797a-2b2e-4ec8-5108-08d9d5fb5d87 X-MS-TrafficTypeDiagnostic: BN9PR12MB5367:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hz/wd8rRJKiq9rbzs/z/1LRkHeMzyQjihl6b0UUQWADjy8AmGoFqiFGMTLAIM7AKVnVAvn9cta6a8Uz4fuWgCLRLwhYGmN4tk9qq/Q4ugfndrfkKUgeVwQCkboVZmYYRD7ANTsJ2pHckWp7ycXPj6Qb38qEqXtA7IlEnP5poy37ufxV5JBgYFbYKty5YsSPEIw3PN0svNJTMEZvN2QVGTfMSmEYRTW2aUHOCawgsrHusKiIip96tGH74vtf5Z+5becy5ZnFoUuVViwxFErqrwEzB9a03rYZCu9j0Wz4ND6AFbE+5Mvmfxsu8iQUF4TKjOWy32H1HCA3qlYz+Z/oK0/BPG0f5mA4Oujb254pvhv+NmL3yocFog28u+Vs/5K+Etj3/AGXZ17KJUStLh/0o4XK0Ue/4uQb9lYeOcaU3AkXSP0+cJQf6mrXoQqD3rbNR8YqxB1br5Uz2ditsFJYpNT03y8Dd5p9bV+lwlIN1WKU7Yjj2uy4Mz2x7wCpbvAejiQGIJkr/0JjdSLzWxuHJOdFlWwLeuhxFTBuPOh0AB3yLzlG9gbWAp8Mgctc+4jtXQAhXhXO01aEUZEYp60MmVRYLUR9spbYDZjgVB48j7vPYbbOXJFwS95zPMZk47cR5xeLwb4YaYgDwWFYwH143L0L9aJMzJgj683ySvlWN5J/NU9ZHMinJPDW+7vz9Um4Ju22isvqI2Vh+DW3HXik28CVb7H+XswQGYcU1N+VW3Xfsn18wYKLHuPmJOjMO1zcn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5065.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2616005)(8936002)(86362001)(2906002)(110136005)(83380400001)(36756003)(44832011)(8676002)(508600001)(5660300002)(6486002)(31696002)(38100700002)(6506007)(316002)(66556008)(66476007)(66946007)(6512007)(31686004)(6666004)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEJqL0RmWlNhRlR2K3JIQktCam5LQWgvQVZ0R2hCNFBCV2JWbEtUTGpISGZj?= =?utf-8?B?cUNRNUh2SEJ0dXRDQ1ZEdW1OQmFDSHZmZkVjV0FDTkptVmJJbEd0dDhzK213?= =?utf-8?B?NGFlVUVhd05aVE1KZ1pZS3UrTWlCVDB5QVVxNm1KbjRBcXR4VkhPTHk3Qndp?= =?utf-8?B?K1A0a29yNUlEaHl2TzNGb3h5SzBtS1lvY0VYSm9oQjRvdklMcEVpbFkvb0RQ?= =?utf-8?B?ci9XRERtRUlkcnVIcFJ6TmRQaUQzMDY1T3B4UEdaeGJDaEh0MzdpSzBTc3BY?= =?utf-8?B?NzRlSTA4aWdpOEFLeEpUcUVnS0I0WG5tVUJXSmtnZmNoQVhiK001THhjaU0r?= =?utf-8?B?ZGxZTU0yZzNoSVQyakhmYlhTK25IeC9lbmpueXhDQU45cEhwbmF4SDhKUytY?= =?utf-8?B?aW9Ga081SWYwL0pjS1RKV2dnRjdwWmdHZ2diOUdQcnB0bWMwdnE5MEN2TThF?= =?utf-8?B?dTA3VFRLY252MTViWkR0VTRnQ0t6bUFSZ1dxQUpEeEx3VWFnQmZFNFVYWDll?= =?utf-8?B?QVFMRGN5WXhsellhajF2T1RyVTN6SlV0ZGp3TkdiWGlMZHdta1hob0ExOGFk?= =?utf-8?B?QnJCWG43Ym5UWStJNENHS0ZZbHdvcnkwOWJiTnpqSXFEcm9OZHRsVkd0aFZl?= =?utf-8?B?UFo4RTZlbThTK0pOLzM4SCtacFpJUUYrdlplMTg0Yk8zbjlXQWlPc2N4bVFT?= =?utf-8?B?WFlsbCszZVF0THRtWGRPTnI4U2YvTlEyaUNDb1BHQVhpcElkNFdaNW0zUFpm?= =?utf-8?B?bjdRT1RZOS9oTjk1bFVJVjN3dFlXbFp3YjI3bUtCTi9md2VnVGVRYWRnWmpr?= =?utf-8?B?cEJFdWZoemcyM3FLd1VFbTNFMmRGZ25WcU1nUVBNek81U3BBTHJENzkzVk56?= =?utf-8?B?eDdDb1MzY28wajR2ZFd4ckNVYWtKVkRhOEl6VlQ5MHlnU3NKRmZJUmppcmtD?= =?utf-8?B?Q29WRkVXMHphNzBWZ2dybzJ4UnBDMWZnUGNDdUw0R3lZUEMrN05FN0tXc2RT?= =?utf-8?B?Sng5SnlQeTNKMkR4TjB0eThJdW85aE8xR3VJdG53U2padE00TXJLS2NCandp?= =?utf-8?B?TSt3azludXgxbUdRUjY5ZE8vTXNHSVU5ZFFKZUs4aVFqcDlYTFlYUklocGc0?= =?utf-8?B?aFlvcUZPTmRWMlI4LzJnV1lDNkN3Q0hWRkFMZE5XK0ZMdW1PMGU5a292bHZo?= =?utf-8?B?M0d5dlprdlhmWEp4bWpXWXFSZTRoaFRMU0JCNWk3a290VGRBTnRPWEFtWFg5?= =?utf-8?B?VjdQekxhSzFMejlsRTNvVzhjcHFmbHQ3clpjV2RGT0NvOFJPcnZGT1lTKzNj?= =?utf-8?B?V3htZDF2UEdBVVNiRm9SQ3NXNkNuQ3BKT25TQURZSWk0TSsweEdvU29hTXlr?= =?utf-8?B?TFRLcXVnaitnM1lzQzZ2Zi9QRnkwVkN5VHJxcWRJakZjajZrSHd0ejRtTUpM?= =?utf-8?B?QjFVVWFuYkJqMDVFOVU4eTN6d1ZLWVdZb2x6SHNTZElPYldOc2xCV3pqNGhs?= =?utf-8?B?aG5zTUU2dDdQVmQvZTFTenRxM21nSDI0VGw2M3R5YjIrbU5tekRTQ2ovN29G?= =?utf-8?B?bEs1cXh5LzdhOG8zMTRDVkQ5dVNsTWdlaHRXc3QxNldRYjQ5V1dteXM5c3Mz?= =?utf-8?B?Y05GZVpGZkUvcXhiOExKUTFxQW96bkY2c0dDdGpJVExnaEdxWWl6ZmNTM3U2?= =?utf-8?B?a1pndGsxUHI5b0dJUFVJRWtyYVlSTmd3ek4xdDFYb0lXK2wyeGJZY2czTjFi?= =?utf-8?B?SGhsMHJNL3dqWDBDeDVNZ3hmdFBiRDBpM1R6RCsrQU1sOTJZc21MdGVQbTl2?= =?utf-8?B?NkhKaW9FVVlNdDBIWmVWMlRkdm9RMkpIQWt5U3NZVTAydm9QVlM0L1VYRVQr?= =?utf-8?B?WU9STUlyOW41N0x5eVJJbU11L2xuMkFISDBLUFpLU2huTUVJaEwvNVpGeGJN?= =?utf-8?B?d0pZY2o3RTM4UFdwNldmQm9jWVMrTkNUSXQ2NUFKVWkyTEEzQzVBdUs5d3BN?= =?utf-8?B?TlJYb25VNEowOEVvNlpBL1JvQUplbzBQc0F1blBWVzRUbVp2MmNmcHlVWGJu?= =?utf-8?B?OGZCckRkVGtlZ2FpQnpyTVphTVJtZFA1TzZpYnAyY2ZGOGpFWi8zaVU2RkdC?= =?utf-8?B?cDd0RTZ1ZmFDYlVlaVJEVVFwM3NZVEhHNEowYjlaYTZkZ0ZHcVBORS9nVjh2?= =?utf-8?B?Y2dTMUpTTmh1T040WE95M2JrdE9xbWRqY0NETnpWV21acEpzbzhWUngrbFcv?= =?utf-8?Q?BwfS+fz1I+9k2g+mfRn+UD2xDvr7llINm5PaJWJRAc=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0413797a-2b2e-4ec8-5108-08d9d5fb5d87 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5065.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2022 18:43:03.4948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WXmIJROwqXCnpiJxj7nzFDjjk3YOzPeqLbHXrCxxWD34WSzzdMiaoTlPOhTDKIrc0l+QCydGrfOq+1eg9Xs64A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5367 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2022 18:43:09 -0000 > > Also, there were some suggestions of operations that would use the value > on the top of the stack as a register number or an index to a register > bank. In that world, the expression could push a register location > description (as a base of indexing), convert it to some kind of value > representation, apply index calculation to it and then use that new > operation on the result. > To be clear here, I am not suggesting for anyone to do this because that would mean that there would be a target specific conversion from a register location into a DWARF register numbering value or (even worse) to the architecture register numbering and then apply index calculation which again either needs to have pre-baked knowledge of the DWARF register to arch register mapping or assume that the mapping was already by the conversion. So all in all a very BAD example from my part and DWARF should never be extended/used like that, but I guess my point was that I didn't want to restrict the implementation more then it was needed. However, I could just remove that comment from the commit message to reduce the confusion and then if we find that there is a usable conversion (like from the implicit location example) we can just add it in later. Zoran