Re: [PATCH v3 5/7] gdb: Introduce is_address_tagged target hook

[Luis Machado <luis.machado@arm.com>]

On 4/4/24 17:12, Gustavo Romero wrote:
> Hi Luis,
> 
> On 4/4/24 12:45 PM, Luis Machado wrote:
>> On 4/4/24 07:48, Gustavo Romero wrote:
>>> This commit introduces a new target hook, target_is_address_tagged,
>>> which is used instead of the gdbarch_tagged_address_p gdbarch hook in
>>> the upper layer (printcmd.c).
>>>
>>> This change allows the memory tagging address checking to be specialized
>>> easily per target in the future. Since target_is_address_tagged
>>> continues to use the gdbarch_tagged_address_p hook there is no change
>>> in behavior for the targets using the new target hook (the remote.c,
>>> aarch64-linux-nat.c, and corelow.c targets).
>>
>> The above block...
>>
>>>
>>> This change enables easy specialization of memory tagging address
>>> check per target in the future. As target_is_address_tagged continues
>>> to utilize the gdbarch_tagged_address_p hook, there is no change in
>>> behavior for all the targets that use the new target hook (i.e., the
>>> remote.c, aarch64-linux-nat.c, and corelow.c targets).
>>
>> ... seems to be somewhat duplicated above in the commit message.
> 
> Right, it's duplicated. I'll drop the first block in v4. Thanks.
> 
> 
>> Also, as general rule, we usually make updates clear at the top of the
>> commit message. for instace:
>>
>> Updates in v3:
>>
>> - Something something.
>> - Fixed breakage.
>>
>> And then those update blocks don't get pushed when the series is
>> approved (sometimes some do push it).
> 
> hmm, k, I'll put the updates at the top next, however I put them always in the
> cover letter and never in the commit messages. Are you recommending putting
> them per commit?"

Yes, we usually add them per-patch in the series. As one edits the patches in a
series (after reviews), they can add the updates one by one and git send-email
the series again.

You don't have to do it for this series though. Just a heads-up.