From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2078.outbound.protection.outlook.com [40.107.247.78]) by sourceware.org (Postfix) with ESMTPS id 87A683858C98 for ; Thu, 4 Apr 2024 16:21:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87A683858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87A683858C98 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.247.78 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712247674; cv=pass; b=tbBWAzEteE5EPc09pht+S35WAf1dOuQq4B2lPNX2wpRB7ZeuFV62zdo1aGXgjDd+92C++LVl29w5u5o3ZCrIw1nSnHdN1UYahmB6V0tScxYd4keldTYMapaIp5Myq5Rf8T++Jjas6I6I4BfWG9WC73/SgwQ+tc89BX/afGU7jEQ= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712247674; c=relaxed/simple; bh=ET0pWfi6/7NV29K73VLBQMjJ5yZGzDVimiMTQjyaQcg=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=mv8h6qEzlEkrIQQ73GkJtfLUUOWvTVxDRUBJuAJ+DpIaPy18vytVXkvaIRLY/RehYMjCKBwHiqv2+W1TdVRhqh3K05U6n+Kzm8RHgqErqRmoNKR7CiOUY0JxYX5c6r9spePMNDpUNJzvGZ5PAUGw63oY+f885jdtF97ZVfxEejQ= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LEzqsh18BmssUj7urn9iUW+OwFVjCR1H2gYUe28myrBawubJq7UCbkZuRD62mw3h8piaDB7GqLGf7g4LdDKMUA1iw6DWC6unSHMbgJOPVCQ/EYisHlGimDkpMYedFXP3GPTeHvvZVRERciTGJo5I2NIhDdXWFTgrZQfv+75CKIt0D8FQK5rvXLyx5JqmO9nclvnKuxKe+IRSZK3HrLtJldVYXe7vK3LedtygDIBoqAy8/kwrs0GlBfl1v/KI/owrrr9+HbuHV1jOQjEzfE2N2x9J09Zq43G3tI2eZT7VNglVPpTEnicGBCy8nhVQBJ1EFemWcncdP6dGT9ZQXH31Wg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4kcbDJJIFrnlwxodchgG3EwS3f2FP2dr4e32ojywSVU=; b=gUyBbvuo/99XTcib3+mw5Jhs3dhYmIdY5I933pSjXOLytZDtHDEb+D0SqrR1r4cvY8uYDxPakJOby/m+vex48GzH7BRMSah4rmxlU2kqAwOcfWxaBPjLsmd5QX+qUKb4LFeqA4/cf/ExjZC2i5h2UIw2Au0mtXOM92amPVYqGIi6goF60Za4ZG5oZ+OKMrwwb7/0PfDmr2Ao8NyqJIkNyLysmEZgFQilyHkZI62Da2Oo9Jlb5cceYBp7jEDKw95U54bOAKwquOsuoEENqtSG4RiUuRV2xTa8tcRGoR72Zjyyg2XrbyC/RaKXBTYo70hPx6xZdftUOZEF/Z+HUOvUQQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4kcbDJJIFrnlwxodchgG3EwS3f2FP2dr4e32ojywSVU=; b=oQ1F9JYva+nJP16XGzi22OzAeb2uTmFoU38mdCPmuM6dQDK2GpTWNrc3wYw7Qg3woNKpLuVyotqi5l7fycCv4wKARsiVmCrwZF9QGyDLdVZEx1ip4fP3z/AybCNPuVcPvG2K9J65zIyourEV3jAlPF2t/eIWXz4+Ez5MOWO1LRo= Received: from AS8PR04CA0017.eurprd04.prod.outlook.com (2603:10a6:20b:310::22) by DBBPR08MB10745.eurprd08.prod.outlook.com (2603:10a6:10:52c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 16:21:08 +0000 Received: from AMS0EPF000001B4.eurprd05.prod.outlook.com (2603:10a6:20b:310:cafe::f7) by AS8PR04CA0017.outlook.office365.com (2603:10a6:20b:310::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46 via Frontend Transport; Thu, 4 Apr 2024 16:21:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001B4.mail.protection.outlook.com (10.167.16.168) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Thu, 4 Apr 2024 16:21:08 +0000 Received: ("Tessian outbound e26069fc76b9:v300"); Thu, 04 Apr 2024 16:21:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8cd0b61817efe885 X-CR-MTA-TID: 64aa7808 Received: from 4d0b90807c05.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0F3C618B-DA15-404E-AB4B-C0BEF5D69A1C.1; Thu, 04 Apr 2024 16:21:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4d0b90807c05.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 Apr 2024 16:21:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EOmqWZ2+8CVezXIbr5M51l9Qk0+iRLe0mT5ksimZN6ai6X2rybEvcTFOL9A+9Uc6ahmjrF57PxSVN6In9HUuqkcHQJpz2ZFqxbpWm2rl+etKYYnGZqkvOdWNdrmt4mS/NH++CAB/Oqqkbgb2/q5mIoeJWzL9zh5biRZkZQEWrG4Su6tyJ3E2W4g8rYnllNsmggMK86ykq41YmiDD0bKgZLfWQmDLeuWCmMSkRzf7oB3RMGxKMFPUmC1RU4hCnvQtwHT3BoXw6ia08QbLGNpSC8lbOIg2rgPjO9GfIWwMiRypeZlX4WRBipk+T822qyF0v7mzAerp/8yuluw1FAtkIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4kcbDJJIFrnlwxodchgG3EwS3f2FP2dr4e32ojywSVU=; b=IJVJOdt1Rd837EMPjVLfEC7cP4V8kSyMhWVk6A60wgTlyToGmrIdDUXyx2oB+Y4k+zGmIy3Ush5KZByHl2uK5wbCpBI9mCWTSDRkyJur/6O4SjHmHDsBXMIJzCRix1HX6qUY7hAeVek/cgDHLQ+CuO2xZbrpdxa5EEOsJ2WjyRu43EA8N3TpynyQUgQdRa1cXznh0ZqaA7HeasXqoXxF9+YnIkF5aIm53XYIWmRJ+xq27n+QLYi/KIp5+M7MRcvrakuWY0wMNH3kIqHkPH3kvb15CWS5/X5/gDpzfeo/GXHzQwtYDW4Yr5kmmj6mHxrwMEjamplSOKZ6iNsG/+3bvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4kcbDJJIFrnlwxodchgG3EwS3f2FP2dr4e32ojywSVU=; b=oQ1F9JYva+nJP16XGzi22OzAeb2uTmFoU38mdCPmuM6dQDK2GpTWNrc3wYw7Qg3woNKpLuVyotqi5l7fycCv4wKARsiVmCrwZF9QGyDLdVZEx1ip4fP3z/AybCNPuVcPvG2K9J65zIyourEV3jAlPF2t/eIWXz4+Ez5MOWO1LRo= Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB9PR08MB7606.eurprd08.prod.outlook.com (2603:10a6:10:309::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 16:21:00 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 16:21:00 +0000 Message-ID: Date: Thu, 4 Apr 2024 17:20:58 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/7] gdb: Introduce is_address_tagged target hook Content-Language: en-US To: Gustavo Romero , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20240404064819.2848899-1-gustavo.romero@linaro.org> <20240404064819.2848899-6-gustavo.romero@linaro.org> <38508341-c27b-7623-790b-c00fabdc8d84@linaro.org> From: Luis Machado In-Reply-To: <38508341-c27b-7623-790b-c00fabdc8d84@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0053.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::18) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DB9PR08MB7606:EE_|AMS0EPF000001B4:EE_|DBBPR08MB10745:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lNrG+uf08FP2NlltiytkzJoZYJ5zCKdyIF1ZDjW1vxuzAk1g8nXXStc5QguP4Lim5U294ABVPOiH2e+0Q2HZ9BNvC2F/0/GsAzEy5aj0iS0RwD8wsY0IvszTScNa9g99oGLXhvEvfjx2m1pGMlTRRE7JAk/TDg4GuZiT/Wl6P8EzOYTl8dDH/kFnSKfRqa3hF3ZaZH9ZUMcvwlYDEoxqdKz84gRiPl+g99kFGN+zAWeFW5lsxncjlUZRvCUAwbYhFK4HOK9LiM9sZgPEjabOZ1Fp/2Ri1QYdtwmPKFy+CL/96kl7gzCYGnB4j8QE79Ut96Zf4mRJ9NTjUaubuJWG/IMVVvldm0YM75xbeSzbdRObiJdby2e/Sc6+WtrS4CsLVc50Lo94BonwxAd8UJw9yqUGO2Fonhnb7ZRirE2FDviIlbsRREvDtujfiozW2pDf8y0bF8y7UuUg5EcLYzaVzBSin46RQ8bFyDCSC2SXeWcQOARsX9IPxG0RFx7MYWBzT0tf+YTNvCk0cZHRENdbx0hUhygZepmrLKGufsKOy+N5czyFqKSGmXsxCBvgDOdNaoHQRVAznHG5EFx/z5XmLX/qt1yJyMkdBwFjMPD9U0Oi8fky1h86vGTi0aK+tU5f8eNuUGuCix8aHaik+hy6MndYlxPZ2zIpBEDaCEzlKBI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7606 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001B4.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1dba652b-7d2f-4249-1fe6-08dc54c33c21 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zKST7UbNfHfXcP43DiVVVdD0SwBnns45Ckyh7hJXVD8L/jdahmr0lhtzi1s4m4mVZyeBpLZMrdr19Ikx8is83cq36KKu2Zt72eCHFwZ/R0F3p3Qf1zv3SdRIkLqbgIjoZzjVvO+QY1YODlkKaviIBcYYMnSY56nCQqvaFek8cJogIUwH5qvG5eyCk6y90GYFCAkoIW1/x/rdMUp7w9ozDJsrHMAFMz0hPdI6rgKFesTWONQnmzutdffY3mpQ0Ywqkpg0d+ItBaOFXltSX4kvR2p6XNjWb1PKtRi3+bCWPXJ5mxnVW9tTh8yKOfEttaHaiMMI7P809l2+/EogoubMxO9WKhkNDRmCcCb3Gns08O06ZRIam2Luf53zmB4btIsSzZ//Z2gtBHxrnfNxHqx6XseY4yIYUIhDvNME5ASUJfmWmeFJdSV/ta7zQIGHIThygAeLuXPRTGqYFPAhuxJHxjlqFCkKS+zy24FcNPnBNgIQOV2rjdp56WUYciPaw/NvV4O2jPIFyeasiYqDzcZmLWlov8uhIIDY+cNpO2i4zO1ydJ2SqIjVFLTw5scnSfhABnZs51MAt6OXeXKRG7ltvKOQJbLoF60r8k5/VH1MBmYpW7S5sVVD5aEhGtnt1SZfM/iw1LqACStOp90QpEJIlT1m6g65aZR6yHwMkSKdbZhK4zpcake03cK/PYte61fiOnkUZC+4RErYG3UNokkAdHivdEAnWgS7YFYhqJUdnP9l2/H+enqdU4eJXoJC/z5p X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(1800799015)(82310400014)(36860700004)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 16:21:08.3302 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1dba652b-7d2f-4249-1fe6-08dc54c33c21 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001B4.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB10745 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/4/24 17:12, Gustavo Romero wrote: > Hi Luis, > > On 4/4/24 12:45 PM, Luis Machado wrote: >> On 4/4/24 07:48, Gustavo Romero wrote: >>> This commit introduces a new target hook, target_is_address_tagged, >>> which is used instead of the gdbarch_tagged_address_p gdbarch hook in >>> the upper layer (printcmd.c). >>> >>> This change allows the memory tagging address checking to be specialized >>> easily per target in the future. Since target_is_address_tagged >>> continues to use the gdbarch_tagged_address_p hook there is no change >>> in behavior for the targets using the new target hook (the remote.c, >>> aarch64-linux-nat.c, and corelow.c targets). >> >> The above block... >> >>> >>> This change enables easy specialization of memory tagging address >>> check per target in the future. As target_is_address_tagged continues >>> to utilize the gdbarch_tagged_address_p hook, there is no change in >>> behavior for all the targets that use the new target hook (i.e., the >>> remote.c, aarch64-linux-nat.c, and corelow.c targets). >> >> ... seems to be somewhat duplicated above in the commit message. > > Right, it's duplicated. I'll drop the first block in v4. Thanks. > > >> Also, as general rule, we usually make updates clear at the top of the >> commit message. for instace: >> >> Updates in v3: >> >> - Something something. >> - Fixed breakage. >> >> And then those update blocks don't get pushed when the series is >> approved (sometimes some do push it). > > hmm, k, I'll put the updates at the top next, however I put them always in the > cover letter and never in the commit messages. Are you recommending putting > them per commit?" Yes, we usually add them per-patch in the series. As one edits the patches in a series (after reviews), they can add the updates one by one and git send-email the series again. You don't have to do it for this series though. Just a heads-up.