From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by sourceware.org (Postfix) with ESMTPS id 8E07E384EF6E for ; Mon, 12 Dec 2022 20:14:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E07E384EF6E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f43.google.com with SMTP id ja4-20020a05600c556400b003cf6e77f89cso10245155wmb.0 for ; Mon, 12 Dec 2022 12:14:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:subject:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=++ifiwaCua+pC+tXj+DyN3s6jZBPsLodYY5O4NqNO/o=; b=VWBkAflT1U3WFe3Mqd/lFZB5tmg7cRLtFJoq/tJ8u93xJrvt6fBkeL0UlJqA2fWqWM OSnbqWBaXZchOPEjaVnNN8BHv/pI7zdkFuYj+j319abjPGtG54wvWUNTwLSXJ5UkHJDG w4s4aQBhaUY2ywkD1AMB/IXD9dA4/G0Vk/ePiR1cuccLGTw6dOq7dRyYQcTXKyMNIyeE z7h9lghM2PmEUAeQTCbnAop09fi8AFI+ZasFUpZwc/tn7RYHeeNSQYooOqCkcmhB+2EY 7g7DBl5XSbyuXVamCvzQsUWoJUl2v7Ub9AraTiVRwL5zmGhKD39ApNnWPLUpbVptAxDs Z4zw== X-Gm-Message-State: ANoB5plWT19Nz28XdguTFemFn+8WIQwIYVPXjxWsrbfIlhjmf+ufUle1 uWUyVwJi3QypoeyL/hsrB98SWSXf1xJLyw== X-Google-Smtp-Source: AA0mqf7I0Qj0soqaFb9g4GZDbXhJhyHGZJTMbtLaDnsVe7i0oXl4t7LgSkD0MyZT2nm96XX1j1r+6A== X-Received: by 2002:a05:600c:4fd0:b0:3d1:c0a1:4804 with SMTP id o16-20020a05600c4fd000b003d1c0a14804mr13718882wmq.17.1670876060355; Mon, 12 Dec 2022 12:14:20 -0800 (PST) Received: from ?IPv6:2001:8a0:f912:6700:afd9:8b6d:223f:6170? ([2001:8a0:f912:6700:afd9:8b6d:223f:6170]) by smtp.gmail.com with ESMTPSA id j9-20020adfe509000000b0023662245d3csm9724501wrm.95.2022.12.12.12.14.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 12:14:20 -0800 (PST) From: Pedro Alves Subject: Re: [PATCH v2 06/29] Avoid duplicate QThreadEvents packets To: Simon Marchi , gdb-patches@sourceware.org References: <20220713222433.374898-1-pedro@palves.net> <20220713222433.374898-7-pedro@palves.net> <91d4f1a1-4554-85e7-dccf-0e1f373c6119@simark.ca> Message-ID: Date: Mon, 12 Dec 2022 20:14:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <91d4f1a1-4554-85e7-dccf-0e1f373c6119@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-07-21 3:30 a.m., Simon Marchi wrote: > > > On 2022-07-13 18:24, Pedro Alves wrote: >> Similarly to QProgramSignals and QPassSignals, avoid sending duplicate >> QThreadEvents packets. >> >> Change-Id: Iaf5babb0b64e1527ba4db31aac8674d82b17e8b4 >> --- >> gdb/remote.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/gdb/remote.c b/gdb/remote.c >> index c0bd075e9e5..00ed82dc466 100644 >> --- a/gdb/remote.c >> +++ b/gdb/remote.c >> @@ -314,6 +314,10 @@ class remote_state >> the target know about program signals list changes. */ >> char *last_program_signals_packet = nullptr; >> >> + /* Similarly, the last QThreadEvents state we sent to the >> + target. */ >> + bool last_thread_events; > > This field is read before it is ever set, isn't it bad? Dunno, it is? :-P :-) Fixed, thanks.