From: Simon Marchi <simon.marchi@polymtl.ca>
To: Stafford Horne <shorne@gmail.com>
Cc: GDB patches <gdb-patches@sourceware.org>,
Openrisc <openrisc@lists.librecores.org>
Subject: Re: [PATCH v3 2/4] reggroups: Convert reggroups from post_init to pre_init
Date: Thu, 21 Dec 2017 03:03:00 -0000 [thread overview]
Message-ID: <d20052f285f17131db38cd33468376df@polymtl.ca> (raw)
In-Reply-To: <20171219142257.13402-3-shorne@gmail.com>
On 2017-12-19 09:22, Stafford Horne wrote:
> Currently the reggroups gdbarch_data cannot be manipulated until after
> the gdbarch is completely initialized. This is usually done when the
> object init depends on architecture specific fields. In the case of
> reggroups it only depends on the obstack being available.
>
> Coverting this to pre_init allows using reggroups during gdbarch
> initialization. This is needed to allow registering arbitrary
> reggroups
> during gdbarch initializations.
>
> gdb/ChangeLog:
>
> 2017-06-06 Stafford Horne <shorne@gmail.com>
>
> * reggroups.c (reggroups_init): Change to depend only on
> obstack rather than gdbarch.
> (reggroup_add): Remove logic for forcing premature init.
> (_initialize_reggroup): Set `reggroups_data` with
> gdbarch_data_register_pre_init() rather than
> gdbarch_data_register_post_init().
> ---
> gdb/reggroups.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/gdb/reggroups.c b/gdb/reggroups.c
> index 2ecd0b494f..5d5e33f2a3 100644
> --- a/gdb/reggroups.c
> +++ b/gdb/reggroups.c
> @@ -26,6 +26,7 @@
> #include "regcache.h"
> #include "command.h"
> #include "gdbcmd.h" /* For maintenanceprintlist. */
> +#include "gdb_obstack.h"
>
> /* Individual register groups. */
>
> @@ -76,10 +77,9 @@ struct reggroups
> static struct gdbarch_data *reggroups_data;
>
> static void *
> -reggroups_init (struct gdbarch *gdbarch)
> +reggroups_init (struct obstack *obstack)
> {
> - struct reggroups *groups = GDBARCH_OBSTACK_ZALLOC (gdbarch,
> - struct reggroups);
> + struct reggroups *groups = OBSTACK_ZALLOC (obstack, struct
> reggroups);
>
> groups->last = &groups->first;
> return groups;
> @@ -105,13 +105,6 @@ reggroup_add (struct gdbarch *gdbarch, struct
> reggroup *group)
> struct reggroups *groups
> = (struct reggroups *) gdbarch_data (gdbarch, reggroups_data);
>
> - if (groups == NULL)
> - {
> - /* ULGH, called during architecture initialization. Patch
> - things up. */
> - groups = (struct reggroups *) reggroups_init (gdbarch);
> - deprecated_set_gdbarch_data (gdbarch, reggroups_data, groups);
> - }
> add_group (groups, group,
> GDBARCH_OBSTACK_ZALLOC (gdbarch, struct reggroup_el));
> }
> @@ -298,7 +291,7 @@ struct reggroup *const restore_reggroup =
> &restore_group;
> void
> _initialize_reggroup (void)
> {
> - reggroups_data = gdbarch_data_register_post_init (reggroups_init);
> + reggroups_data = gdbarch_data_register_pre_init (reggroups_init);
>
> /* The pre-defined list of groups. */
> add_group (&default_groups, general_reggroup, XNEW (struct
> reggroup_el));
LGTM.
prev parent reply other threads:[~2017-12-21 3:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 14:23 [PATCH v3 0/4] Support for arbitrary reggroups Stafford Horne
2017-12-19 14:23 ` [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2017-12-19 16:27 ` Eli Zaretskii
2017-12-19 22:13 ` Stafford Horne
2017-12-20 13:35 ` Stafford Horne
2017-12-20 16:37 ` Eli Zaretskii
2017-12-21 3:29 ` Simon Marchi
2017-12-21 12:55 ` Stafford Horne
2017-12-19 14:23 ` [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature Stafford Horne
2017-12-19 16:23 ` Eli Zaretskii
2017-12-20 10:40 ` Stafford Horne
2017-12-21 2:40 ` Simon Marchi
2017-12-21 3:40 ` Eli Zaretskii
2017-12-21 2:59 ` Simon Marchi
2017-12-24 14:47 ` Stafford Horne
2017-12-19 14:23 ` [PATCH v3 3/4] reggroups: Create reggroup_gdbarch_new for dynamic reggroups Stafford Horne
2017-12-21 3:15 ` Simon Marchi
2017-12-19 14:23 ` [PATCH v3 2/4] reggroups: Convert reggroups from post_init to pre_init Stafford Horne
2017-12-21 3:03 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d20052f285f17131db38cd33468376df@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=openrisc@lists.librecores.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).