From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by sourceware.org (Postfix) with ESMTPS id 49B6F3857B9B; Thu, 10 Aug 2023 12:47:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 49B6F3857B9B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=canonical.com Received: from [192.168.57.45] (unknown [37.120.18.125]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 241C84268A; Thu, 10 Aug 2023 12:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1691671627; bh=NxlbvLpYcdwJZRYItPiMkJbW9DQsNMLjYNkJpkphLh4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=jk+S7mIGkjmUJ/qqzca0Pa8ZVdavOxEeC9V/2NwTMNbkxuupdKasGZB0KvSECwA9u r/sOeoGn8nB+OhgKRhjaQD/0dWVyWa2CCq51fTaTdrycAtRMEljHbLyafM8Jp/I/l0 0/v32O6LwN670VRhswV5ifnS47XBd+H0W7+SmHAmRk2o1ik/3WFad26pCAfp27v9q6 X7mNXA24s1FpMXSmi4YYLpRa4Ou1QTMxlOHojvvPx9/nBI/glifxEfG6AoNiioT7td mQnSTc9HWTMaCdZahTmBSH+9t/jeDmSi9IU0vFsMkVuOj2jM7GLKcI83nX74Qn9CZy xooF3PGZmlcUQ== Message-ID: Date: Thu, 10 Aug 2023 14:47:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCHv2] Use toplevel configure for GMP and MPFR for gdb Content-Language: en-US To: apinski@marvell.com, gdb-patches@sourceware.org, binutils@sourceware.org, gcc-patches@gcc.gnu.org References: <1668107159-16961-1-git-send-email-apinski@marvell.com> From: Matthias Klose In-Reply-To: <1668107159-16961-1-git-send-email-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10.11.22 20:05, apinski--- via Binutils wrote: > From: Andrew Pinski > > This patch uses the toplevel configure parts for GMP/MPFR for > gdb. The only thing is that gdb now requires MPFR for building. > Before it was a recommended but not required library. > Also this allows building of GMP and MPFR with the toplevel > directory just like how it is done for GCC. > We now error out in the toplevel configure of the version > of GMP and MPFR that is wrong. > > OK after GDB 13 branches? Build gdb 3 ways: > with GMP and MPFR in the toplevel (static library used at that point for both) > With only MPFR in the toplevel (GMP distro library used and MPFR built from source) > With neither GMP and MPFR in the toplevel (distro libraries used) this still seems to be broken for a gdb trunk build, using GMP and MPFR system libraries: linking gdb: [...] ../gnulib/import/libgnu.a -Lyes/lib -lmpfr -lgmp -lsource-highlight -lboost_regex -lxxhash -ldebuginfod -ldl -Wl,--dynamic-list=/<>/gdb/proc-service.list ./libtool: line 5209: cd: yes/lib: No such file or directory libtool: link: cannot determine absolute directory name of `yes/lib' make[3]: *** [Makefile:2174: gdb] Error 1 make[3]: Leaving directory '/<>/build/default/gdb' full build log at https://launchpad.net/~doko/+archive/ubuntu/toolchain/+sourcepub/15065515/+listing-archive-extra the toplevel config.log has: configure:8183: checking for the correct version of gmp.h configure:8202: x86_64-linux-gnu-gcc -c -Iyes/include -fPIC conftest.c >&5 configure:8202: $? = 0 configure:8220: x86_64-linux-gnu-gcc -c -Iyes/include -fPIC conftest.c >&5 configure:8220: $? = 0 configure:8221: result: yes configure:8237: checking for the correct version of mpfr.h configure:8255: x86_64-linux-gnu-gcc -c -Iyes/include -fPIC conftest.c >&5 configure:8255: $? = 0 configure:8272: x86_64-linux-gnu-gcc -c -Iyes/include -fPIC conftest.c >&5 configure:8272: $? = 0 configure:8273: result: yes configure:8342: checking for the correct version of the gmp/mpfr libraries configure:8366: x86_64-linux-gnu-gcc -o conftest -Iyes/include -fPIC conftest.c -Lyes/lib -lmpfr -lgmp >&5 configure:8366: $? = 0 configure:8367: result: yes configure:8615: checking for isl 0.15 or later configure:8628: x86_64-linux-gnu-gcc -o conftest -Iyes/include -fPIC -lisl -Lyes/lib -lmpfr -lgmp conftest.c -lisl -lgmp >&5 configure:8628: $? = 0