From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2076.outbound.protection.outlook.com [40.107.6.76]) by sourceware.org (Postfix) with ESMTPS id 49A04385B194 for ; Mon, 28 Nov 2022 11:54:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49A04385B194 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pvy2YdvSQ/gxsculL6q0tRBgpOrqJomGk1rQ6GdqZIyhWr5R8/4072KP/ivc7Zo9eW2IQMU7O/bdxESPzjwNSZkU6OsSZq7m0D5sY+9wRV5kQASSPqkpsxyF0tQU62s8Re6/8+JJkPGZ0+7+Lyoppm13HwGypizRMFRDrpCDDaEx9WemS6enO/U+1bO98TgsAeN+een75hNkMqlaVO4BvDowhuZ9uZ33ux85K8/ZAidsbkoFBOY++dg8WW63DO/LYaJCAL7AJVA7hKW3AuG+NCXKy6dUSuOKrSX85GrkR6VDuYdu6+mJy55AQ4OXEgKDK2dHHk22c+oGFDzCGq0BjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VCgFdVdDEgkhfiNMiH+Czy6z6BG0drFPQdxjsZ9jz7k=; b=nuKxwFfGZPF1g8UWvUxxElvrYb8TJYfKAv7x50l3t/GXZcT8cRZQzxAcN2bUpbuEWzgoioG0fPXyipKmnlH+CQb7IRHkxjY4JyzpCyzT/QSxsdjZt7e5v7NshiidqIp9LBCY3NcB0iN6fX8ZRJM0955x08VudNHXz8TBWFMm88kHONiY+Q/LNt5AQXZorahElkkKik4mvkqjxo28OnZWD3xuPfBD4M0oW2GcCE+Dj+/h7yswZgdsPhYN5sNrA1Pvbx6TaW0RRHaDDu8UU9FnF7e96DKVY6Sa/UJLVNtDALf7mGMFzu8RJz/pXzZ6HWsGYk1gDrfwd+m3hISJVx54AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VCgFdVdDEgkhfiNMiH+Czy6z6BG0drFPQdxjsZ9jz7k=; b=j+ti/fatKXJj5OTzdnpMW8eCJJYyc2sz+k4BTQXWu5JmA8nRgsCk5q2ll1tVCC8FbH59q9QFcoY5kPSHSd1BUxfPrdL4JAIaui3pk77MY8xlvXA42Zl8UrJ2T2XbvZOEEHtknvAgTSvwlNpovIMe51IptJbpyyVGCClNbVLT2Mk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PAVPR08MB8894.eurprd08.prod.outlook.com (2603:10a6:102:329::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Mon, 28 Nov 2022 11:54:16 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::fe5c:b195:a2ad:b19c]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::fe5c:b195:a2ad:b19c%4]) with mapi id 15.20.5880.008; Mon, 28 Nov 2022 11:54:16 +0000 Message-ID: Date: Mon, 28 Nov 2022 11:54:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/6] gdbserver/linux-aarch64: Factor out function to get aarch64_features Content-Language: en-US To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20221126020452.1686509-1-thiago.bauermann@linaro.org> <20221126020452.1686509-4-thiago.bauermann@linaro.org> From: Luis Machado In-Reply-To: <20221126020452.1686509-4-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0553.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::7) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PAVPR08MB8894:EE_ X-MS-Office365-Filtering-Correlation-Id: e6677fcd-73b0-4139-220d-08dad137464f NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pDFyd9ons8I1p0lnf/axPuW4tvnlzv/bMUbFUgMqBRzyZCS2VZooXI1/uTN78JblLTtRHzFfPTe74W/Ueweh/bi7n1CM7pqrWAq/okfPOVmaoQ5EGM/8kJQ2/FTEDhxxeOdoarpuWxle24iE+yRkTC4Cun3SOh/ztN6Q9hMTc28KnX5ZmWHJ4bgXUsD2IZ+HUfH8nZWAh52+uUwYq9LnHpaEO0WN+31LzoCcueOW482y1lGWF29fxLIdisHscGpbBkPKan60NNPBVCbva/XVp5GsM+r1tXQRj7sJToweyQFgaDe6zoKcsobu3YSpkyiKHAjcN4qCz0352h0QaQsogmoc7FKUcuvrC5/nJkWrFum64FdPjOANhtF16IFDKNJ9EtbUMVwwty2lOsj8Kg85r6fKxhugtt/J8YnyypA7H9gETMhjEwztJZwQ3r2oXLThE6UneoXsTnivu2RyNfoptT8qPkwS37Poq/780Li/DFc9Aiy8iGIeoAkpLyJlaC23gzorB61Woi1py2/4Xo4Og31QW8KOEB3C6jHyXXoWshxZBEZ+2w5TvclHwdv5HXYoSllJSR1iNQReSd69/6qpUI3+NOMlfyhwlapFedY0vcMc49sySgHeAiFuPQeL99qOdNJQPZ5pn81WLprbyWu9QHDrcabYhsBWm30sP1NfYMYCIy7y5zrKBA/+8/JiaCnn7mwKKOHioBmiPMJNa6IJTh+2yQsKiTl0ZWIbwqEqQ7Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(451199015)(66946007)(66556008)(66476007)(36756003)(8936002)(41300700001)(5660300002)(44832011)(31696002)(86362001)(26005)(6512007)(6506007)(83380400001)(53546011)(2616005)(186003)(316002)(6486002)(38100700002)(8676002)(478600001)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTVRY21jcFpPLzdmY0s3V2Jxa1hlQUcwaWF1dDBvUlJ4VEd2aUVBNGhqVUpG?= =?utf-8?B?ZnpoYi9jMWZUWnJwVXZobjhQR0R5UFFzODRhaTN2VVJlNzMrMTZLT2o3NHh4?= =?utf-8?B?OWxwL3lCOHZzbVN4NTcxWGpsZENTS0MxMmFpZHVKa21uY2lZT3owSjJBOG5U?= =?utf-8?B?UGhYcklJVCszSXFnaEdBT3h3OFhkc3ZiTkhVcjYxelBibDU3aUY0QS93S1F5?= =?utf-8?B?MUt3MDlxMi80UmhMRDQ2Wlp1VHYvbjlEVFdrZjE1OHduRVFUM0ExQTdRWHJs?= =?utf-8?B?a2F3R0FubnI5NFRybmRHQmdCOURVZjVqcUI4ZGNwR0JwUTY4UEE1QWJBNDZR?= =?utf-8?B?Qk9VRTJHWkNyb3BNbmRmc3dLY3QyaG50ZlVPZjRubjJXbWRPSG1xeVZlVGlp?= =?utf-8?B?ZkFZVXE0SkxkeGdTaHhDWGpwMHFlaGx3VlZ4VWlRSzZ2K09lN3B5Z2ZQUkY3?= =?utf-8?B?T2Q5WW1zM3B6ZkJrbWlLZUE4NXRzWnhkdjVValBBNllPR0dyQ2ZlVG9qcDBx?= =?utf-8?B?YmRET0FDMDNQYWx0aGYycXE1dnNSVTJla1VBVHc2MDQwTEY3eDYrN3M5OFU1?= =?utf-8?B?Z3dzdGNBVldzdVZ3T213dFBzMUdCck55M1RrdDAwYVhxR2xnZ2xnYVZGaTVh?= =?utf-8?B?OFNiQ2JiOFlreWNvRjlzdC9XZ21LWGw2VUFkUndncFV0S2ozSFUwem9SVTV6?= =?utf-8?B?TG9KaVNLLzh5cXNvZ0dmNi9FUVdnZGhFemY0dnZJQVZUZy9EWGdZb1hhaWRt?= =?utf-8?B?S250K3NONlRLTE9pOUlqeStJTVRTZndHQ2FrTFVVK0lDWjNvWGY5OUswU09Z?= =?utf-8?B?YjNvRTZJLzU3UjVodkJzVkRvU0lLYkE5dGV5bWlSaXlGb1JsMVhLODZWS05k?= =?utf-8?B?cUZUL3NUQ1ZHUzZzTmx2d3FMNjJadzB3Z3lvQmZTaVcxQm5xV29sSDRzUUdJ?= =?utf-8?B?NWl3WVFYNUcvS0Y5eHQ3L01QMm81dWhnMW5qT3hzUG5NblRxcU5pa2NmUjQ1?= =?utf-8?B?SjlrRmhQVmU3MHVzajRUdjg5NXp6Zmt6Wms0a0dVYXM3ZExRYTdSRUhWLzln?= =?utf-8?B?TlI5ODVLYTR5OVZpZzVmUllKUmFvUkkxZHRralEvVHUzZ2xiMW1sa1R3Rmd6?= =?utf-8?B?SktLRUtHM3o0dlJlMHRMVFozcGV6L1RzWTVkdWxGWWE1MktQY3h3WFdzamsz?= =?utf-8?B?OTNUbUtUanh3Mk9ncDh0VC95OEtlWkJvQ1pVSm5jbzl5c3l0UVpOempYWVpU?= =?utf-8?B?OHlxMFNzRDc5eS9XV05wREJWd0RpaGhqdS9sMVBaZjJXZHVMekpsenpqY21G?= =?utf-8?B?OXhKUUJ6cTFCMEozVlZnYWVlWXJoMndIbExnYmRETXYyRkNWYU56d3VJR0gz?= =?utf-8?B?SGI0dmNuSEZOczRZM2sxTzNCTExjaGYrNS9xc1pWQVpRUW5KNWJKazFXUUxi?= =?utf-8?B?RVQ2T2RCWGF3K1RpNTVHeVlNdzQrb2ZxSXZ5S2lJdzZjTmhQNW5RQmpsN3h5?= =?utf-8?B?M1Nhc05qakxPWUhqVjhhRTN5MnhvSm9RSjMvWS9ZK0FleEc2VUZ4cVVTZldT?= =?utf-8?B?d3oySklVZmkvTkh0blRxeFV3SFdvZVc0aUsxZHVtblBVeEJRcWsyRmgwa1M2?= =?utf-8?B?Q0NrcnBjVnZEZXlNZjJOcmJxRnBNMFdYYmRSOURnVU1RUUVYcFNEUDYwbzBR?= =?utf-8?B?cng1dGRHY3BJbU5uQXAvcmhuZnVWK2tiMDJXMGE5VmFTanE4Ukd4MnFwQXZF?= =?utf-8?B?SjVuUllOWktkRi9LcngvZFV1Z2U1TkhJc0YweXhKREhhY1pkV1Q5Y0Jqb3U0?= =?utf-8?B?QjMvU3pjeVdMMXczUElDRGxhRy9jVTh4K0xnTzA0cVNUUjFJMnRzRE11MzU4?= =?utf-8?B?UnZiamt0bDZ4ZmwzT3MyaUVsdWJQTllhOWhPQUN2NmNzTjdkSkRVZzhIQmU0?= =?utf-8?B?K29vSWg1Sk0wdStVSG9CNkJVUTJIRWNyOGhGY2ZvZzlIS3RweFFydnRJZ1Nm?= =?utf-8?B?eG9jN21MRGlUUkIyS1ZwMTlvV3B5N2lWdjJFbVp4OGh0M2gxcHFXeWNqdExL?= =?utf-8?B?UUlST0xidk15ZGR1ZUgxT0xXdFJMT3RnaGxhcHk3bEZZNU9XcmpsR0FJdkdh?= =?utf-8?Q?7zdJRPq0cr/rNfGQCAZTZ3jYj?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6677fcd-73b0-4139-220d-08dad137464f X-MS-Exchange-CrossTenant-AuthSource: VI1PR08MB3919.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 11:54:16.0594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cm/bIV5AQfNWf5VjMkHRvqRXPzPTwivV2wv7tV9AQtXo9aOxRHMCxC/itGqv0v43BTg40KaiDhXYERJFgFOtHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8894 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/26/22 02:04, Thiago Jung Bauermann wrote: > It will be used in a subsequent commit. There's no functional change. > --- > gdbserver/linux-aarch64-low.cc | 33 +++++++++++++++++++++------------ > 1 file changed, 21 insertions(+), 12 deletions(-) > > diff --git a/gdbserver/linux-aarch64-low.cc b/gdbserver/linux-aarch64-low.cc > index a6ed68f93029..cab4fc0a4674 100644 > --- a/gdbserver/linux-aarch64-low.cc > +++ b/gdbserver/linux-aarch64-low.cc > @@ -652,6 +652,25 @@ aarch64_target::low_delete_process (arch_process_info *info) > xfree (info); > } > > +/* Matches HWCAP_PACA in kernel header arch/arm64/include/uapi/asm/hwcap.h. */ > +#define AARCH64_HWCAP_PACA (1 << 30) > + > +static struct aarch64_features > +aarch64_get_arch_features (const thread_info *thread) > +{ > + struct aarch64_features features; > + int pid = pid_of (thread); > + > + features.vq = aarch64_sve_get_vq (lwpid_of (thread)); > + /* A-profile PAC is 64-bit only. */ > + features.pauth = linux_get_hwcap (pid, 8) & AARCH64_HWCAP_PACA; > + /* A-profile MTE is 64-bit only. */ > + features.mte = linux_get_hwcap2 (pid, 8) & HWCAP2_MTE; > + features.tls = true; > + > + return features; > +} > + > void > aarch64_target::low_new_thread (lwp_info *lwp) > { > @@ -804,9 +823,6 @@ aarch64_adjust_register_sets (const struct aarch64_features &features) > } > } > > -/* Matches HWCAP_PACA in kernel header arch/arm64/include/uapi/asm/hwcap.h. */ > -#define AARCH64_HWCAP_PACA (1 << 30) > - > /* Implementation of linux target ops method "low_arch_setup". */ > > void > @@ -822,15 +838,8 @@ aarch64_target::low_arch_setup () > > if (is_elf64) > { > - struct aarch64_features features; > - int pid = pid_of (current_thread); > - > - features.vq = aarch64_sve_get_vq (tid); > - /* A-profile PAC is 64-bit only. */ > - features.pauth = (linux_get_hwcap (pid, 8) & AARCH64_HWCAP_PACA); > - /* A-profile MTE is 64-bit only. */ > - features.mte = linux_get_hwcap2 (pid, 8) & HWCAP2_MTE; > - features.tls = true; > + struct aarch64_features features > + = aarch64_get_arch_features (current_thread); > > current_process ()->tdesc = aarch64_linux_read_description (features); > LGTM Reviewed-by: Luis Machado