From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 104363858D20 for ; Wed, 1 May 2024 18:11:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 104363858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 104363858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714587118; cv=none; b=QPtditBgxJqOZC2o7MNxJOlguf2oeSza64Q12oK9vb2L9Q7HUr54yeHLODXCNFwR+73L+1q0Z1PlvWIktsH2MVg57dvjlL39+ffv9e2Jil1tVj+WRI6uXVvEclMDIx72EwVn7mog5XsB1pc47FbOchKAqLRikbTxITB+tQvWvHA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714587118; c=relaxed/simple; bh=wJVwvPeNXHsfGFa+mTC5af7couGtCBtxa5FJcM8aqaA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=eg2go02bnCLkJXVZ80pYdgddv3axfN2Ho5SenhVueuf+Mfg32TB+cCBbYppSqipJvcbkkMX8XA4tiiwpYTQlNqDA4BWn98AxeFVNtRFxiSrPZDEvP53LY8WYFFyi1Qp8dJE6iZyO700wUN2VY/3lBXY2ExmpiGmAYgncYZRCvCw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1714587115; bh=wJVwvPeNXHsfGFa+mTC5af7couGtCBtxa5FJcM8aqaA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uk3M01bKUerBeleAww0H22JM+bkhSjLN+v6bzKlQyXazcKdkDF3VAXJFBF++wH4dv fgyWh0gutgMTdL9c5PJTLwaI443dtb08USiqS/FicriHSfmfYdGXzGaheN/cE5erqg qKRa5qcK6eXNf61A+wdkZMM0aSWa5sgSZhVoUq88= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9F0131E092; Wed, 1 May 2024 14:11:55 -0400 (EDT) Message-ID: Date: Wed, 1 May 2024 14:11:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: reject inserting breakpoints between functions To: Andrew Burgess , Klaus Gerlicher , simon.marchi@efficios.com Cc: Simon.Marchi@amd.com, gdb-patches@sourceware.org References: <20220408200536.235329-1-simon.marchi@efficios.com> <6630b03f.050a0220.6a68d.6289SMTPIN_ADDED_BROKEN@mx.google.com> <87ttjhoocc.fsf@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87ttjhoocc.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-05-01 05:47, Andrew Burgess wrote: > Klaus Gerlicher writes: > >> Hi Simon, >> >> I verified that your patch addresses many of the issues we would also >> like to solve in this area. >> >> It appears this has not published yet and it seems to be more than 2 >> years old. >> >> Could you please tell me if there are any plans to commit this? > > Given I reviewed this once upon a time, I still had my review branch > kicking around. > > I rebased onto something close to HEAD of master. I addressed the minor > nits I pointed out in my review. I'd be happy to see this merged once > my full regression run (still on going) has completed. > > I think I'd like Simon to give a +1 before I pushed this though. > > Thanks, > Andrew Thanks for reminding me about this, it clearly fell through the cracks. And thanks Andrew for following up on it. What you posted looks good to me. We discussed it internally, Pedro suggested to maybe wait after the GDB 15 branch is created before pushing this one, to give it more testing time in master before it reaches a release. Simon