From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2080.outbound.protection.outlook.com [40.107.20.80]) by sourceware.org (Postfix) with ESMTPS id 58D7F3858298 for ; Fri, 13 Oct 2023 14:44:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58D7F3858298 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0yez4/ht3TylGbrhLPw0+coDICZKSRc96isCQo69mHM=; b=eSl5KicC699lLVqQppxcsMt/X+rxFmk8Gq62WgOICqn/TSiQPGX0MDaWOzJcoHETTUiZSQq7NtNHKhCDNfhn5RakYNFZUJ4it0QYmkl+kTXTUAKc18H43BZSrEVzUMtvbT+VjfQ3FPeiOA7F1X//ZZjXqnCp2bqYkFiqPg/sApc= Received: from AS9PR06CA0573.eurprd06.prod.outlook.com (2603:10a6:20b:486::8) by AM0PR08MB5299.eurprd08.prod.outlook.com (2603:10a6:208:18d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Fri, 13 Oct 2023 14:44:37 +0000 Received: from AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:486:cafe::c5) by AS9PR06CA0573.outlook.office365.com (2603:10a6:20b:486::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.29 via Frontend Transport; Fri, 13 Oct 2023 14:44:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT026.mail.protection.outlook.com (100.127.140.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.30 via Frontend Transport; Fri, 13 Oct 2023 14:44:37 +0000 Received: ("Tessian outbound 9aeaca65ec26:v211"); Fri, 13 Oct 2023 14:44:37 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f5b38bd8feef4735 X-CR-MTA-TID: 64aa7808 Received: from 28a48ccf92a9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9171E6AB-FEAF-4942-A849-CE3F1BB4AA89.1; Fri, 13 Oct 2023 14:44:29 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 28a48ccf92a9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 13 Oct 2023 14:44:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P6zvcwlKVDfubkZZksKgUX4sR2Lwpeyg4W1k0+NkRjn8cLj4fdnNSLMWyl443/qUD0XhabW4sUbfXtsKaxp/CrTbV3GHGSU+mropuWOZMpCKUIFVtEnPp5uw29L7kZ4PaH/SO3ABUrf56YhJEYfaLIXPkAT+BP+VO2TGC0HyoT96JBA2Lf5+aOMgVwslApb5WgjehnxT07yRn8P8DCIUCpwGBPDw+JEMA4JjvSZimIwSitzqeJ55mbQM69FcVTp92adE/6B6Cq49qT2PtHeHxz9Q5IL71ttWtdD3cQHVAeuXPlu03Rv3epvO9+NIxJSnwuIUN9Hw6psvDec6k2v8FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0yez4/ht3TylGbrhLPw0+coDICZKSRc96isCQo69mHM=; b=RYD4Tegy4bVRcp9LSKcdON4k8086yhdKBHCkhyEn+1evNQuWrbwUFbpgkay7IItr1dwHI7GdJooH8MHDYEraghyU/k78lONMd50AgTwYQOtXr0+hMtxqMFPpfGFGSMIrdLzn0FwDCI3MPVPi5rNTFHkqZQcLp7pESsH2iMfbGuOzlHUbSxKx1cQkwF79tCts/154eiN6/PNXA36m5HuXwEt/3Q+VFYZWWHgzl7P3hymwlulH2jJtQraJJCHTw68m8Nnw/6pYbL6TDtKC65yTNHp/3M02FEyQHm1eV++bQQE5Oi+ZWMbTnm3kJO3aN0wgI1H/Il8/SzYsGGSzIawp9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0yez4/ht3TylGbrhLPw0+coDICZKSRc96isCQo69mHM=; b=eSl5KicC699lLVqQppxcsMt/X+rxFmk8Gq62WgOICqn/TSiQPGX0MDaWOzJcoHETTUiZSQq7NtNHKhCDNfhn5RakYNFZUJ4it0QYmkl+kTXTUAKc18H43BZSrEVzUMtvbT+VjfQ3FPeiOA7F1X//ZZjXqnCp2bqYkFiqPg/sApc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB6181.eurprd08.prod.outlook.com (2603:10a6:20b:29a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Fri, 13 Oct 2023 14:44:26 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c126:1009:20a5:195]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c126:1009:20a5:195%4]) with mapi id 15.20.6863.032; Fri, 13 Oct 2023 14:44:24 +0000 Message-ID: Date: Fri, 13 Oct 2023 15:44:21 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 05/18] [gdb/aarch64] sme: Enable SME registers and pseudo-registers Content-Language: en-US To: Tom Tromey , Luis Machado via Gdb-patches Cc: thiago.bauermann@linaro.org References: <20230918212651.660141-1-luis.machado@arm.com> <20230918212651.660141-6-luis.machado@arm.com> <87edhyu0xp.fsf@tromey.com> From: Luis Machado In-Reply-To: <87edhyu0xp.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0215.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::22) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB6181:EE_|AM7EUR03FT026:EE_|AM0PR08MB5299:EE_ X-MS-Office365-Filtering-Correlation-Id: 17498726-9b02-42fe-39d7-08dbcbfaecc8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +FmIvscjQKlN7XfiJJiMEBVpM6P4yRJol4hAUeWq26OYKd91szR+bzHMDuV3B2H9JukK4kAKgyJvRkVF8VmXC5WPqwcizfEwIdnPEjxPi4yd9bEVcbuSDs4Cn/3e28PhM/qVndDND6G98eOba+Y/AzKTkM5dM+zoNU776l6ejrpq8iF7n5jCPyL5IIpJ2CdnZvFsaLcuoY3jlrSjhX4C/zgXPNdhjNTAOkuhJNUpTh18VsQvHMpFy6EGFe1kYf+cilHKA3psId59qO1NpwxtILe8YSR6+vwTz24P58ScKpRcwAAHNIz1+41MnUuh6uz0C6jYanOQJKDTtGadFuMaRa3YDxmjeOzcCCi0WUhInvXmKIuCYMDNY5QRS0JZMeQR5LGyJrkQkboqyO8pLY5IozmC3VNRMlMKqrJgrQU4B2e8dt0anKSG2TWgMLFb3qzWJVKboNayOkFSibGNJpv8TUj3QlHYvCeU0So7uXobAMBHU1Yxg3NtiX6YionYjZezX7ab8dfitCPhv5vg/QxSkkbTgU4EbljQ3s/HGhzq9r32kEWY6oeomDteVeQB51DaP0jhcCRPHee5SdTFITzwGbbBqQuPkyKkTWNLpx/SjMvdNiDbjm+jBftdKVl/Zmmhm+s2aY4YkoxS2tJLf7itAw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(366004)(346002)(39860400002)(136003)(376002)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(2616005)(6666004)(6506007)(6512007)(26005)(53546011)(83380400001)(41300700001)(44832011)(5660300002)(4326008)(2906002)(8936002)(478600001)(6486002)(66946007)(66556008)(66476007)(316002)(110136005)(38100700002)(31696002)(8676002)(36756003)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6181 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 44d27c36-8382-4ac8-31a1-08dbcbfae4a0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lf0d+cOXDn3ct5xLmtDEGILqvqav+Yi0eWpXr2NKLDYE1H1mT8PyesDULWXYCWRTrQWTjhbYDRW+YURiztAxg24c05Urq6I/Q7nMBjNo4vi9UNi7U8QQxFp9JvcpdeNa5xXUIh3CArlB66ypGgruTOBihOvOg8YX2nx0oh3pvu1FoW4ooS1jPOabK/EaCE89qiJZhtlMICokI1lY0XKe73V6qLk3Hdnahj2NARUvehfRvFX5iiO9XKuqy5Ssl3bJQxry32pG3qHyqVBeSItsA/Qenha+3HClm691iWNfuZ+yvQb91QJDscEOQG1J8WuNi2NOUT/2dsBEluso/M0KtUfbUJqKsJex7Ab+8jarFA2FsxVFoiw7aHF/lGZ6CEj5wAANqdYyCaFl6HwVawThkCxI0nD34FL0JYsegqPeJEcni2vd+fOjd0GzDln3NJQvQd1ijfsVkqzLbidVNbzWS/Rdmd2HUsTwDHnoXUg8fey79wO73G1v0X9tgRaVRMWZV17FSM5gT3x0LbEUCtLbTcI1iZBdtUcCqV85OkVL/j+zgmFiLBbRzr5H26QgVF2BIkDCLw06D1tk+YPvpJhuV6rHBT1m14b8AnETagxuTC/7//HJbvVsVS1rqtSAczJOMY6R4FP5luKSdWkKhoJKgnXFKVmYtld1U9fGIFDoeQs1bUm/lcyeu0SwvjkGXVuV1PrxrZ5kmL0kGbVE8VpKAEggZTr2m+izaKZxHLah05FQVGxuqDYUYGA3GglfTd38dhwtlvT+2Mg18Oq8p2WkKQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(376002)(39860400002)(396003)(136003)(346002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(82310400011)(40470700004)(36840700001)(46966006)(36860700001)(53546011)(6506007)(478600001)(83380400001)(47076005)(31686004)(8676002)(40460700003)(26005)(40480700001)(2616005)(81166007)(336012)(6512007)(5660300002)(31696002)(2906002)(41300700001)(86362001)(8936002)(6666004)(4326008)(6486002)(44832011)(70586007)(316002)(70206006)(110136005)(356005)(107886003)(82740400003)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 14:44:37.7239 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17498726-9b02-42fe-39d7-08dbcbfaecc8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5299 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/13/23 14:06, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado via Gdb-patches writes: > > Hi Luis. > > This patch caused a gdbserver build failure on aarch64-linux. > > In file included from ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-ptrace.h:36, > from ../../src/gdbserver/linux-aarch64-low.cc:48: > ../../src/gdbserver/linux-aarch64-low.cc: In function 'void aarch64_adjust_register_sets(const aarch64_features&)': > ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-sigcontext.h:304:45: error: '__SVE_VQ_BYTES' was not declared in this scope; did you mean 'SVE_VQ_BYTES'? > 304 | ((sizeof (struct user_za_header) + (__SVE_VQ_BYTES - 1)) \ > | ^~~~~~~~~~~~~~ > ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-sigcontext.h:325:10: note: in expansion of macro 'ZA_PT_ZA_OFFSET' > 325 | (ZA_PT_ZA_OFFSET + ZA_PT_ZA_SIZE(vq)) > | ^~~~~~~~~~~~~~~ > ../../src/gdbserver/linux-aarch64-low.cc:941:28: note: in expansion of macro 'ZA_PT_SIZE' > 941 | regset->size = ZA_PT_SIZE (features.svq); > | ^~~~~~~~~~ > CXX nat/aarch64-linux.o > > Luis> +/* Make sure we only define these if the kernel header doesn't. */ > Luis> +#ifndef ZA_PT_SIZE > ... > Luis> +/* Offset from the start of struct user_za_header to the register data */ > Luis> +#define ZA_PT_ZA_OFFSET \ > Luis> + ((sizeof (struct user_za_header) + (__SVE_VQ_BYTES - 1)) \ > Luis> + / __SVE_VQ_BYTES * __SVE_VQ_BYTES) > > Is it safe to just remove the "__" as the compiler suggests? > > thanks, > Tom Should be, if it is defined. Let me look into it.