From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2080.outbound.protection.outlook.com [40.107.92.80]) by sourceware.org (Postfix) with ESMTPS id 4F2453858C83 for ; Tue, 26 Apr 2022 23:44:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F2453858C83 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eWnyA6/th49UnD7SR7v0jM5QhJ/gTncaGh4LFWax7SrxR2h0cefHr8jF+UxCY4JLcK53RX/I49eeIr2aKjRcbV2Q3iKMKofmfJZRY4dMUl6Ob/AIz5KtiVuupILYx4zJ4hZMBX6+A1fR7FGkNcGg/9NkVJWo0mhI5Pj5cCB2bPoyTgDtCByswuAGCIaCpFmBlN0on4x6OTuGg2FcF6aPpD0sLZ1uxUJcPSxiuFOTAzFMoKQZLW2QiUO6cHKNTi6AOabnrulx8aZvP+s4Tua3HCTHvRF4t+JmMUrqSHH6ofRGaMU4enn/oyvx4CU2SfFPqPWwBCs8dBFr+vujIcL9vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T4e7cAh6nWfDXujKm3/Eez8kMFRn16p8CztOpAHEULk=; b=UoQLOxHgikOb0P6+tDA81Lv86SaV857B/fbhQA+bhLCjLJTX92mDDcUcptHmqDZaFqp2BjfEMjjOWjY0LmYgFp/dYjZZXUyLk2yL5Zp3WKMr1yHezKJZM6EIy6XwHuZV9I0PTZJ5SujEImwp4Htt6wjeEGMQQAm3i8PUqERFnYMrfC7ilS9+XIcKfNr9RYEdm9rGRxATcYnmjDSrIMEvNHEy9niGYu5zqxgVuBHCV4hEPgUOH0rzOe+KWBrh0EjcQNYqaULM3XRfxUvto4AM8tzr9CQLUoikDYibPuTg87RBqnJIF+BVZq7eHfXReMut9hBUkKnXy9yRMHfUiDaooA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from PH0PR12MB5452.namprd12.prod.outlook.com (2603:10b6:510:d7::16) by SA0PR12MB4541.namprd12.prod.outlook.com (2603:10b6:806:9e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr 2022 23:44:09 +0000 Received: from PH0PR12MB5452.namprd12.prod.outlook.com ([fe80::91ae:2b15:fc7b:23b1]) by PH0PR12MB5452.namprd12.prod.outlook.com ([fe80::91ae:2b15:fc7b:23b1%7]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022 23:44:08 +0000 Message-ID: Date: Wed, 27 Apr 2022 00:44:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] gdb: cooked_index_functions::expand_symtabs_matching: require psymtab Content-Language: en-US To: Tom Tromey , Lancelot SIX via Gdb-patches Cc: lsix@lancelotsix.com References: <20220426141917.2887797-1-lancelot.six@amd.com> <877d7bod8r.fsf@tromey.com> From: Lancelot SIX In-Reply-To: <877d7bod8r.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0009.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::14) To PH0PR12MB5452.namprd12.prod.outlook.com (2603:10b6:510:d7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4240b94-3466-49fd-0fba-08da27dea82e X-MS-TrafficTypeDiagnostic: SA0PR12MB4541:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JRUYXE/fZgLZZX5SmcOhFkc3kjPxhRAT32Q5SRTC7+NinG5cIVur4AtjwjdyKCBcc3VY1mSct3BPSpb4NkClfP9BDmFlhQKZxPQaaQXYCHfE5+dsb+c7VhqmTMdngrQpst5jHOj1fv1Cms/sgnDljvgkQzCgS7QWlFaZwnxxpXmY5V6sHrE5cXRGad6S2Q2QWokT43Zqn8FzDVXqCyMGr/o5DcAzaNchYVTavkJ7pJ6AR7HbbTmgmuJIfT/2pnm/q0UCxTXmq1llOGCUd2WrkvvZdD/aSALNFehF64fvXSN8KoQPn0Ba5KOmUt2R7lvCoKS1nLgf/yhnl8dmEc1e2kRqIic69uaczAZju8N+MGXOu2CnUQWhuxbDSzDt6vhq3LWEHUsRk8bZdd7QPTvAQ7SiqHpUwIfiObNBYvxMlIcnToQeF9WgfH76N/w/wCqIhv5zGG7xdXxKLzBlL4/tIQpRt18pQ2YWdKPndVg5k0/lUAIvTeuTGCy3cMMZtJZrG/mPk/ASe6wP5KfXrsO6cDuRiq8tGkF5dnRjE2FjAh+RjE38AotvLrIcUc6wV/k0oxdOspq3hq7MvNJQZ1//QSeEJ8bryqnbK9Q1Zc5USg86OBEvUt7pfhGLZm1uDjmZq4FtWtzTZiWOghtzT8ns8X90zh9fOzZcnX59fgcxssuWcS1MrryZLPNE5YpXemTT0JGngvv0vKwp4CohpaEOqBg6/n4yaUeFalTE/AM4L2o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR12MB5452.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(38100700002)(31696002)(86362001)(2906002)(316002)(5660300002)(8936002)(66946007)(66476007)(66556008)(8676002)(4326008)(2616005)(6666004)(83380400001)(6512007)(186003)(6506007)(110136005)(6486002)(508600001)(31686004)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cENtakR2cmhybXpSRExteUpOVUQ2NUxRaVFYSDhVRFkwSGJ2TGYrS2hZdkFy?= =?utf-8?B?Z2VRZWwrREUzQkQ3YnM3N3FNOTIwcGtrTVZOZHNNVzIvcDdzSkJLcGFJb3F3?= =?utf-8?B?bHEra281cUFCT3ZUVUJlQUJ3L1V4cDNHMUdYYzNEMUp0dkR4aXdkVmFKWG50?= =?utf-8?B?VzhPcW4yZmZPQ1owWG9EdUxiQ3J0UWJWNFduQ3BjWEFLS2JhOTFsc0pMeFoy?= =?utf-8?B?N2dXNTdTaUJ4clNXZERqKy9qL2ZJbzZIUGN5Qk1ITjFrYi9rNXpwbUJCdjFP?= =?utf-8?B?QUhHaUVQaHl5dXF0UmpJM3ZzQVAzVWtNeXNFQTBVR2NkNGZSRXNBZGFWMGJy?= =?utf-8?B?SEh6UGZRdWc1MkJOSk1ETGpWbFJVK29XUGsyaW1NcnRteDA5N1FQR0wzL2d0?= =?utf-8?B?TUlEMS9rK2s0TlBWUkJUVEQyMmJIU05SL1d6bjBHNnNVZWg4aDhaUDFrRkYv?= =?utf-8?B?dWpBZ1ZXL1RlMTJ0bGl5SUtsSjdkNk5qVFNQdEFnZUpualdFclRGOU9ZVjBN?= =?utf-8?B?ZS8raTAvMWpFWTkrWjF2WG5kY3lTVWtQL2pzTzQwb20xSExEUFFtcTRKZ1lu?= =?utf-8?B?dFVHSCtRNENGZmR4ZTJIbnp6Yi9ORmx2bXk1bjdHa2hETFlzQlBQMzFkTGNW?= =?utf-8?B?SnBpMjV5WW8zNGZCOHFOVW02bFVRaS9uZjlCYlZiSXR6ZVpVK2Z4VVZ2ZkZB?= =?utf-8?B?bWxOblVsa2hKNWlsSW9qWUZDTVk2U3pzdGgyM0hPMjVqRU1BN0llNG11aGd5?= =?utf-8?B?T0RLQytMajlYcWsxcll6MUZ6b0hLekd6Z0tSNzZJTjVTa3g4ZlY2d0FzeHZ4?= =?utf-8?B?NWxvTmZpU0tKWFBDUzJ0VWVLUWFtRUQxN294NjlKRmFPSGdZbWVVWkd4MG9i?= =?utf-8?B?MG1heTI4eldMU0Ria3A0d3RkQjJobWhDR2lhdnp5VXlUNjJFZTVoalJzWTBl?= =?utf-8?B?RjRTZmdxTklveXdHd2FVUjFGa1RKVVE1bmtxTVl3K3g2NjdzWVZkaXI1WGE2?= =?utf-8?B?c0VtcU8vQ25mN2lMTXB4dVMzUE9xVVdFYWgrRXVlZkt3c1RxQmxlVzRPNVZZ?= =?utf-8?B?VWpia1hRNVZJalZIcVBMeHhVeEJKbU4xYlY5UldhRDh5cUMvUVBPRW9hd3dM?= =?utf-8?B?cW81OHB1NmgraXlFMW9xWG02Q3dCcFdoL2ZpU2RPRmtvMGhEazczYk9nMkZE?= =?utf-8?B?MFRPSjNSdnVER0FqQ1p2dWFSUE1sbnk0bmtxSUhmMXpTRjR5UEJvWVNXa3Nt?= =?utf-8?B?Skp1OVVYNUV3ZXhLWi9GazhkRE5EbDVjNGZldElSRjVUQWhFQy9ib0VONjZG?= =?utf-8?B?TitrMmdYSXdSVU1rV1Rxa3AxNFlvdWcxOVB2eFF6UUxXZW9kU1RlV2p2QUhF?= =?utf-8?B?U3NucW8zVlhidk1BTmJsbXNpckdMYnk3ckU4OFdkR0xDRGRSaGd6VTEvdmhm?= =?utf-8?B?OWdwMjVMVENhNW9TU0pVWDdxRWZoSnplNWpxVUVWWlU3TDFnM1UwVXhXNkZt?= =?utf-8?B?RjF0ZDBWU2IxWUxvY2draXZnbHJHMjdHV3hHZVRabXc0dXIyTFA2akxwd2pJ?= =?utf-8?B?b1hPREg1dmZCSldhMXVBTkxMcVhOUGRHMnYvamwvcGV0WHBJdzJjK3dSVkZp?= =?utf-8?B?Q3FJYWJRVkxKTFJTNnNqV0g5NXNvLzZEZFpvMjRUa2lnYnpwVlJaN3BqaHJD?= =?utf-8?B?RGhWUGJpcTJsZkxlTzFJNnhoYVp5UUxEVnNaUXcvM3dmbC9pTkQrc2pTV1Fz?= =?utf-8?B?RW9hSGNhR1RwZkpwMVp6eEJxWnZ0Z1VGR1E2K0ZDbjJqQ0p1TGQ3OFdzVm9V?= =?utf-8?B?alFKcTQ3N2R6cjNBeUYzRndEL3NGbTMvLzVMT284SkRlelc1bU9DVlZ0RzJS?= =?utf-8?B?ZFZ3OVdza1UydEg2WlZ4OGV1MmJTRDVtNVBZSjR0a25Jbm11c2FCUjVmOCtW?= =?utf-8?B?K3JnZWZqK3Z6RW1CTWpZOHloYno5YXBaelhITlB1aFBLRjk0Z0xZWTNYbkIx?= =?utf-8?B?R2ZaMXlYeXJPUUFOTC9WZTkya2s5bHRMWmJtbDNpaktVTzdKaHMrZ0dzRFNX?= =?utf-8?B?cjYxUFo4QmFPQWJJQ0F3Y21Ic2lIc3R1YXNjK2lMTGVNRm1IL0pWTVRhTE9X?= =?utf-8?B?ZDN0WllFcTNCNjFYTExoWnhURkNhNnlLRXIxL3kvRVdTb1RlY25wdlRyNGlS?= =?utf-8?B?VjZod25WN1BqMjVpR3JERG5qa3ovWmhQbjBqRnltdmRrbmJrNG50R1duVWZt?= =?utf-8?B?T2UwcUVGZUZGeGdmVTg2dm4wdkhPN1NOS2RSUUMyRDV3d3ZXUmx5NmdDMGc4?= =?utf-8?B?dmRtM1JNcEhPUmpRSnlPT0JsNWRYNFpaNldlRmN2clZmSThJVnhUUVVUc1FF?= =?utf-8?Q?eGz+leYEIBZvdLt8yWe+oAYUeBfeXUsLUbDfrTJ8T3+TY?= X-MS-Exchange-AntiSpam-MessageData-1: rwerY+Odk4EbDQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4240b94-3466-49fd-0fba-08da27dea82e X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 23:44:08.8378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3ulsC5P0LYohNYNAlsPVdRi6MumsU4M40QQA3w6sIK+CdssRCK3fDdlk0t5wcBHm2CrtQWaBNpujtV7mFD0+TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4541 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 23:44:13 -0000 >> The new indexer's expand_symtabs_matching callback does not have a call >> to the objfile's require_partial_symbols, so there is not mechanism to >> ensure that the psymtab is laded at this point. > > I wonder if this lazy loading is even worthwhile any more. > Perhaps just removing SYMFILE_NO_READ entirely is the way to go. > > Tom Hi, Thanks. This is not something I initially considered since I guess that some benefit is expected from this (at least I guess this was the case at some point in time). I did some quick digging, and it looks like this was introduced in b11896a5276900e7fda0bb6b7cd9d2b31a4945b3. However the commit message is short of context (or maybe this is due to some import process to git at some point in time, I do not really know). Is this lazy loading made for cases where a process forks and the child execs just after? In such case, it makes sense not to bother loading the psymtab since it will become unnecessary pretty soon. I'll have a look into removing the lazy loading machinery (mostly SYMFILE_NO_READ and OBJF_PSYMTABS_READ related code should be what I am looking for) and come up with an alternative patch. Best, Lancelot.