From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] PR python/20190 - compute TLS symbol without a frame
Date: Tue, 26 Jul 2016 17:28:00 -0000 [thread overview]
Message-ID: <d33f445a-11a2-c938-9b25-fe80108fcaf6@redhat.com> (raw)
In-Reply-To: <87wpk8l52c.fsf@tromey.com>
On 07/26/2016 05:47 PM, Tom Tromey wrote:
> I tried sending this once before, but for some reason it appears not to
> have gone through.
>
> Pedro> I see. Maybe add some small comment to the test mentioning
> Pedro> that "symbol.value" takes an optional frame argument and we're
> Pedro> purposely not passing one?
>
> Here's a version that adds this comment.
LGTM.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-07-26 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 21:16 Tom Tromey
2016-06-28 14:11 ` Yao Qi
2016-06-28 21:15 ` Tom Tromey
2016-07-22 11:18 ` Pedro Alves
2016-07-22 11:14 ` Pedro Alves
2016-07-24 16:53 ` Tom Tromey
2016-07-25 16:00 ` Pedro Alves
2016-07-26 16:47 ` Tom Tromey
2016-07-26 17:28 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d33f445a-11a2-c938-9b25-fe80108fcaf6@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).