From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-134220-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 121107 invoked by alias); 20 Oct 2016 22:01:32 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 121098 invoked by uid 89); 20 Oct 2016 22:01:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 22:01:31 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 002FE935A7;	Thu, 20 Oct 2016 22:01:30 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9KM1SYx009957;	Thu, 20 Oct 2016 18:01:28 -0400
Subject: Re: [RFA v2 15/17] Convert DWARF expr functions to methods
To: Tom Tromey <tom@tromey.com>
References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-16-git-send-email-tom@tromey.com> <77fe3ede-66ea-93a3-eb9f-50f9c22a06e4@redhat.com> <87lgxihewg.fsf@tromey.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <d351c8ba-f090-88cc-01f9-c0dc3a4b9d95@redhat.com>
Date: Thu, 20 Oct 2016 22:01:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <87lgxihewg.fsf@tromey.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-10/txt/msg00631.txt.bz2

On 10/20/2016 10:46 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> I notice that several of the intro comments to functions that 
> Pedro> are now methods still talk about CTX.  Should they be
> Pedro> tweaked?  Maybe to "to this context's stack".  Or maybe they're clear
> Pedro> as is anyway.
> 
> I've updated this patch as appended.

LGTM.

Thanks,
Pedro Alves