Re: [PATCH] PowerPC, fix gdb.reverse/finish-reverse-bkpt.exp and gdb.reverse/next-reverse-bkpt-over-sr.exp

[Bruno Larsen <blarsen@redhat.com>]

On 22/11/2022 17:53, Carl Love wrote:
> PowerPC, fix gdb.reverse/finish-reverse-bkpt.exp and gdb.reverse/next-reverse-bkpt-over-sr.exp
>
> The tests set a break point with the command break *func.  This sets a
> breakpoint on the first instruction of the function.  PowerPC uses
> Global Entry Points (GEP) and Local Entry Points (LEP).  The first
> instruction in the function is the GEP.  The GEP sets up register
> r2 before reaching the LEP.  When the function is called with func() the
> function is entered via the LEP and the test fails because GDB does not
> see the breakpoint on the GEP.  However, if the function is called via a
> function pointer, execution begins at the GEP as the test expects.
>
> The tests were modified to call the function with a function pointer so
> the test will work correctly on both PowerPC with a GEP and LEP as well as
> on other systems.  The GEP is the same as the LEP on non PowerPC systems.
>
> This patch fixes two PowerPC test failures in each of the tests
> gdb.reverse/finish-reverse-bkpt.exp and
> gdb.reverse/next-reverse-bkpt-over-sr.exp.
>
> Patch tested on PowerPC and Intel X86-64 with no regressions.

Regressions have been fixed and style looks good.

Reviewed-By: Bruno Larsen <blarsen@redhat.com>

Let's hope a maintainer shows up soon :)

-- 
Cheers,
Bruno