From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 10BB63854564 for ; Wed, 23 Nov 2022 08:44:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 10BB63854564 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669193053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ExZheURLQAyAd22P4JjJYtxLBq0cIv5GbF9ZbbFo8Z4=; b=c+jS6GEwX9+LNEivXJhVg0DY5wXYY7TpwCyVy+OvWZwC8iHe0lHhnWxR9CoWzfh18rauEV /7zn39RlkuxdZtRX1wOpEFz+AMUwzJ0VihFrWYaInR+tqjR0m2+MqjzJTo+hgX5Xb4ymmr O8P4lmpCn9+vyrTeAiMMArkysVAjIac= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-468-IWz9Z4CGO1273-Eyxuqm6Q-1; Wed, 23 Nov 2022 03:44:12 -0500 X-MC-Unique: IWz9Z4CGO1273-Eyxuqm6Q-1 Received: by mail-ej1-f70.google.com with SMTP id hs34-20020a1709073ea200b007ad86f91d39so9634389ejc.10 for ; Wed, 23 Nov 2022 00:44:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ExZheURLQAyAd22P4JjJYtxLBq0cIv5GbF9ZbbFo8Z4=; b=5nwMbc2nBTFoGxHVf7vrq6FLXm2ClI/bk8uc0dA8lEU2FkbRyfD0Ii5gS/UlH6zrdH v+2Sebt2/tC8JQ9fVyrNSivG2miuzIfEzgMV/iT5n8isPQYHL/SfeRO5ZVQZKuWhTaYN q/gmDs/4HZklLvGGqwdp0mBffBNrOtSsC4yLU3KYEgusGJ5Udlk+Pfuy024jtDnkjgFm u+Vax8/ZjxfMTwh/OuJSYd7c8L7I5Vr09QCLlUDLWpopA1VGWXK3jgEl8jvr1AYP8ipR +6TRLJDJmSXxE/bAgoVZjPFPvG1bIaJw2l4KCikHPbB1mCOtCkvq1LJEjl8bqdvfTnJC TeTQ== X-Gm-Message-State: ANoB5plI/u1j27EkrUyMzNDKPRB6alAzoaVmWDffG7EOxOyTwVxeWSaf +gS/TXn8b4nruN47NjKZk4oYYAjEfhK4ByDel5L+QM0wkzx3Uu1lVx4nRVFaTzrzNqYc7qfuuiZ SsjKAVAF2kWe7mASKJ6a9ww== X-Received: by 2002:a17:906:369b:b0:78d:34a:f466 with SMTP id a27-20020a170906369b00b0078d034af466mr22933545ejc.162.1669193051196; Wed, 23 Nov 2022 00:44:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf7C/I4LgE8zT99HgJlwFqelTH7v8O2GY4UJaL3GAA1bNwmIkOSJ5F+vuJzMgpFrfrRgDKYKQg== X-Received: by 2002:a17:906:369b:b0:78d:34a:f466 with SMTP id a27-20020a170906369b00b0078d034af466mr22933532ejc.162.1669193050987; Wed, 23 Nov 2022 00:44:10 -0800 (PST) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id d23-20020a170906641700b007ab1b4cab9bsm6927392ejm.224.2022.11.23.00.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 00:44:10 -0800 (PST) Message-ID: Date: Wed, 23 Nov 2022 09:44:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] PowerPC, fix gdb.reverse/finish-reverse-bkpt.exp and gdb.reverse/next-reverse-bkpt-over-sr.exp To: Carl Love , "gdb-patches@sourceware.org" Cc: Ulrich Weigand , Will Schmidt References: <69b2451b-1baf-8bd4-25dd-a1b46963981f@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/11/2022 17:53, Carl Love wrote: > PowerPC, fix gdb.reverse/finish-reverse-bkpt.exp and gdb.reverse/next-reverse-bkpt-over-sr.exp > > The tests set a break point with the command break *func. This sets a > breakpoint on the first instruction of the function. PowerPC uses > Global Entry Points (GEP) and Local Entry Points (LEP). The first > instruction in the function is the GEP. The GEP sets up register > r2 before reaching the LEP. When the function is called with func() the > function is entered via the LEP and the test fails because GDB does not > see the breakpoint on the GEP. However, if the function is called via a > function pointer, execution begins at the GEP as the test expects. > > The tests were modified to call the function with a function pointer so > the test will work correctly on both PowerPC with a GEP and LEP as well as > on other systems. The GEP is the same as the LEP on non PowerPC systems. > > This patch fixes two PowerPC test failures in each of the tests > gdb.reverse/finish-reverse-bkpt.exp and > gdb.reverse/next-reverse-bkpt-over-sr.exp. > > Patch tested on PowerPC and Intel X86-64 with no regressions. Regressions have been fixed and style looks good. Reviewed-By: Bruno Larsen Let's hope a maintainer shows up soon :) -- Cheers, Bruno