From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 38756385EC57 for ; Mon, 21 Mar 2022 18:23:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38756385EC57 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 22LIN29p016856 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Mar 2022 14:23:07 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 22LIN29p016856 Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 93CB41F0BB; Mon, 21 Mar 2022 14:23:02 -0400 (EDT) Message-ID: Date: Mon, 21 Mar 2022 14:23:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCHv3] gdb/python: add gdb.format_address function Content-Language: tl To: Andrew Burgess , gdb-patches@sourceware.org Cc: Andrew Burgess References: <20220304105031.2706582-1-aburgess@redhat.com> <20220307123317.3966024-1-aburgess@redhat.com> From: Simon Marchi In-Reply-To: <20220307123317.3966024-1-aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 21 Mar 2022 18:23:03 +0000 X-Spam-Status: No, score=-3039.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 18:23:12 -0000 > diff --git a/gdb/python/py-arch.c b/gdb/python/py-arch.c > index 0f273b344e4..53906ce506e 100644 > --- a/gdb/python/py-arch.c > +++ b/gdb/python/py-arch.c > @@ -62,16 +62,25 @@ arch_object_data_init (struct gdbarch *gdbarch) > } > > /* Returns the struct gdbarch value corresponding to the given Python > - architecture object OBJ. */ > + architecture object OBJ, which must be a gdb.Architecture object. */ > > struct gdbarch * > arch_object_to_gdbarch (PyObject *obj) > { > - arch_object *py_arch = (arch_object *) obj; > + gdb_assert (PyObject_TypeCheck (obj, &arch_object_type)); Since we have a function for that, I'd do: gdb_assert (gdbpy_is_architecture (obj)); > diff --git a/gdb/python/py-progspace.c b/gdb/python/py-progspace.c > index 1e01068c59b..f9f2a969e2b 100644 > --- a/gdb/python/py-progspace.c > +++ b/gdb/python/py-progspace.c > @@ -504,6 +504,23 @@ pspace_to_pspace_object (struct program_space *pspace) > return gdbpy_ref<>::new_reference (result); > } > > +/* See python-internal.h. */ > + > +struct program_space * > +progspace_object_to_program_space (PyObject *obj) > +{ > + gdb_assert (PyObject_TypeCheck (obj, &pspace_object_type)); Same here, use gdbpy_is_progspace. Otherwise, LGTM. Simon