From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 4/6] gdb/continuations: do minor cleanup
Date: Wed, 21 Apr 2021 14:57:29 +0200 [thread overview]
Message-ID: <d3abdded87d37b86cab6807ac2b39fc3c44ea667.1619009681.git.tankut.baris.aktemur@intel.com> (raw)
In-Reply-To: <cover.1619009681.git.tankut.baris.aktemur@intel.com>
In-Reply-To: <cover.1619009681.git.tankut.baris.aktemur@intel.com>
Inferior continuations are no longer used by the until and finish
command. It is used only by the attach command and the remote target
upon detecting new inferiors. Update the comment accordingly.
Also update another comment about non-existent thread continuations and
remove an unused #include.
gdb/ChangeLog:
2021-04-21 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* continuations.h: Update the general comment.
* inferior.h (class inferior) <continuations>: Update the comment.
* interps.c: Do not include "continuations.h".
---
gdb/continuations.h | 4 ++--
gdb/inferior.h | 3 +--
gdb/interps.c | 1 -
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/gdb/continuations.h b/gdb/continuations.h
index 7ebe82af1c5..39130c65f0f 100644
--- a/gdb/continuations.h
+++ b/gdb/continuations.h
@@ -25,8 +25,8 @@ struct inferior;
/* To continue the execution commands when running gdb asynchronously.
A continuation structure contains a pointer to a function to be called
to finish the command, once the target has stopped. Such mechanism is
- used by the finish and until commands, and in the remote protocol
- when opening an extended-remote connection. */
+ used by the attach command and the remote target when a new inferior
+ is detected. */
/* Prototype of the continuation callback functions. ARG is the
continuation argument registered in the corresponding
diff --git a/gdb/inferior.h b/gdb/inferior.h
index 66fc180ce53..9ca510e4e6e 100644
--- a/gdb/inferior.h
+++ b/gdb/inferior.h
@@ -509,8 +509,7 @@ class inferior : public refcounted_object
bool detaching = false;
/* What is left to do for an execution command after any thread of
- this inferior stops. For continuations associated with a
- specific thread, see `struct thread_info'. */
+ this inferior stops. */
continuation *continuations = NULL;
/* True if setup_inferior wasn't called for this inferior yet.
diff --git a/gdb/interps.c b/gdb/interps.c
index d15a36a4266..ec19822b571 100644
--- a/gdb/interps.c
+++ b/gdb/interps.c
@@ -37,7 +37,6 @@
#include "interps.h"
#include "completer.h"
#include "top.h" /* For command_loop. */
-#include "continuations.h"
#include "main.h"
/* Each UI has its own independent set of interpreters. */
--
2.17.1
next prev parent reply other threads:[~2021-04-21 12:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 12:57 [PATCH 0/6] Refactoring around inferior continuations Tankut Baris Aktemur
2021-04-21 12:57 ` [PATCH 1/6] gdb/infcmd: remove the unused parameter 'args' in 'attach_post_wait' Tankut Baris Aktemur
2021-04-21 19:24 ` Tom Tromey
2021-04-21 19:32 ` Simon Marchi
2021-04-21 19:47 ` Tom Tromey
2021-04-22 5:57 ` Aktemur, Tankut Baris
2021-04-21 12:57 ` [PATCH 2/6] gdb/infcmd: update the comment for 'attach_post_wait' Tankut Baris Aktemur
2021-04-21 19:25 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 3/6] gdb/continuations: remove the 'err' from 'do_all_inferior_continuations' Tankut Baris Aktemur
2021-04-21 19:29 ` Tom Tromey
2021-04-21 12:57 ` Tankut Baris Aktemur [this message]
2021-04-21 19:31 ` [PATCH 4/6] gdb/continuations: do minor cleanup Tom Tromey
2021-04-21 12:57 ` [PATCH 5/6] gdb/continuations: use lambdas instead of function pointers Tankut Baris Aktemur
2021-04-21 19:43 ` Tom Tromey
2021-04-22 7:49 ` Aktemur, Tankut Baris
2021-04-22 12:50 ` Tom Tromey
2021-04-22 14:07 ` Aktemur, Tankut Baris
2021-04-22 14:12 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 6/6] gdb/continuations: turn continuation functions into inferior methods Tankut Baris Aktemur
2021-04-21 19:46 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3abdded87d37b86cab6807ac2b39fc3c44ea667.1619009681.git.tankut.baris.aktemur@intel.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).